[GitHub] kafka pull request #2295: MINOR: Mx4jLoader always returns false even if mx4...
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/2295 MINOR: Mx4jLoader always returns false even if mx4j is loaded & started Mx4jLoader.scala should explicitly `return true` if the class is successfully loaded and started, otherwise it will return false even if the class is loaded. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka mx4jloader-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2295.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2295 commit e6344181b4719fd8ba0de59862f39871d787c62a Author: Edward Ribeiro Date: 2016-12-29T21:10:14Z MINOR: Mx4jLoader always returns false even if mx4j is loaded --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA 2578 Client Metadata internal state shou...
Github user eribeiro closed the pull request at: https://github.com/apache/kafka/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA 2578 Client Metadata internal state shou...
Github user eribeiro closed the pull request at: https://github.com/apache/kafka/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA 2578 Client Metadata internal state shou...
GitHub user eribeiro reopened a pull request: https://github.com/apache/kafka/pull/263 KAFKA 2578 Client Metadata internal state should be synchronized You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka KAFKA-2578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit 67b792339090006589799604a47d183e402b465c Author: Edward Ribeiro Date: 2015-09-29T21:23:19Z KAFKA-2578 Client Metadata internal state should be synchronized --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: Client Metadata internal state should be synch...
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/263 Client Metadata internal state should be synchronized You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka KAFKA-2578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/263.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #263 commit ff5719dbcce8aef03494d2982131a8c8034a5680 Author: Edward Ribeiro Date: 2015-09-29T21:23:19Z Client Metadata internal state should be synchronized --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2599 Metadata#getClusterForCurrentTopics...
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/262 KAFKA-2599 Metadata#getClusterForCurrentTopics can throw NPE even wit⦠â¦h null checking You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka KAFKA-2599 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/262.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #262 commit 960107edf131a710e1af808fe93a6ad8566098a5 Author: Edward Ribeiro Date: 2015-09-29T20:42:31Z KAFKA-2599 Metadata#getClusterForCurrentTopics can throw NPE even with null checking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: MINOR: MockClient's disconnect() method has tw...
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/183 MINOR: MockClient's disconnect() method has two bugs (and a prospetive refactoring) * First, it compares Strings using `==` instead of `equals()` * Second, it tries to remove a String from a Set. As disconnect() method is only called by a single method on SenderTest then it's safe to refactor it to make it both explicit that its argument is a node id and perform a Integer.valueOf() before trying to remove from `ready`. * Third, not a bug, but the Iterator logic can be simplified, shrinking the scope of the Iterator without changing the logic. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka mockclient-disconnect Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/183.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #183 commit 91189feb46e16b17a86596a011e12df9fefbbb49 Author: Edward Ribeiro Date: 2015-09-01T03:24:04Z MINOR: MockClient's disconnect() method has two bugs (and a prospetive refactoring) * First, it compares Strings using `==` instead of `equals()` * Second, it tries to remove a String from a Set. As disconnect() method is only called by a single method on SenderTest then it's safe to refactor it to make it both explicity that its argument is a node id and do a Integer.valueOf() before trying to remove from `ready`. * Third, not a bug, but the Iterator logic can be simplified, shrinking the scope of the Iterator without changing the logic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: MINOR: Quota's equals() is buggy.
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/182 MINOR: Quota's equals() is buggy. It compares upper bound with itself. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka equals-bug Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/182.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #182 commit 527c978ab92a2216d5700519138c6dc3a5cd3592 Author: Edward Ribeiro Date: 2015-09-01T02:26:16Z MINOR: Quota's equals() is buggy. It compares upper bound with itself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-1811 Ensuring registered broker host:por...
GitHub user eribeiro opened a pull request: https://github.com/apache/kafka/pull/168 KAFKA-1811 Ensuring registered broker host:port is unique Adds a ZKLock recipe implementation to guarantee that the host:port pair is unique among the brokers registered on ZooKeeper. You can merge this pull request into a Git repository by running: $ git pull https://github.com/eribeiro/kafka KAFKA-1811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #168 commit a9941892833e8e25c36ee0aac8704143863db452 Author: Edward Ribeiro Date: 2015-08-25T15:29:12Z KAFKA-1811 Ensuring registered broker host:port is unique --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
