[GitHub] kafka pull request #4345: KAFKA-6390: Update ZooKeeper to 3.4.11, Gradle and...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4345

KAFKA-6390: Update ZooKeeper to 3.4.11, Gradle and other minor updates

Updates:
- Gradle, gradle plugins and maven artifact updated
- Bug fix updates for ZooKeeper, Jackson, EasyMock and Snappy

Not updated:
- RocksDB as it often causes issues, so better done separately
- args4j as our test coverage is weak and the update was a
feature release

Release notes for ZooKeeper 3.4.11:
https://zookeeper.apache.org/doc/r3.4.11/releasenotes.html

Notable fix is improved handling of UnknownHostException:
https://issues.apache.org/jira/browse/ZOOKEEPER-2614

Manually tested that IntelliJ import and build still works.
Relying on existing test suite otherwise.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-6390-zk-3.4.11-and-other-updates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4345


commit 5df853f9ea5425e08794507d1d104d050b56dde2
Author: Ismael Juma <ismael@...>
Date:   2017-12-20T10:27:57Z

KAFKA-6390: Update ZooKeeper to 3.4.11, Gradle and other minor updates

Updates:
- Gradle, gradle plugins and maven artifact updated
- Bug fix updates for ZooKeeper, Jackson, EasyMock and Snappy

Release notes for ZooKeeper 3.4.11:
https://zookeeper.apache.org/doc/r3.4.11/releasenotes.html

Notable fix is improved handling of UnknownHostException:
https://issues.apache.org/jira/browse/ZOOKEEPER-2614




---

[GitHub] kafka pull request #4297: KAFKA-6317: Maven artifact for kafka should not de...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4297

KAFKA-6317: Maven artifact for kafka should not depend on log4j

It should only depend on slf4j-api (like kafka-clients). The
release tarball still includes log4j and slf4j-log4j12.

Manually verified that there are no duplicate dependencies
in the release tarball and `./gradlew core:dependencies`
looks good.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-6317-kafka-slf4j-api-only

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4297


commit 544195cf3f1af84c32da9ecc1fe7bd6d2cb83748
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-12-06T16:58:29Z

KAFKA-6317: Maven artifact for kafka should not depend on log4j




---

[GitHub] kafka pull request #4283: (WIP) KAFKA-6193: Flaky shouldPerformMultipleReass...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4283

(WIP) KAFKA-6193: Flaky 
shouldPerformMultipleReassignmentOperationsOverVariousTopics

I have been unable to reproduce it locally, so enabled additional
logging while running it in Jenkins.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-6193-flaky-shouldPerformMultipleReassignmentOperationsOverVariousTopics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4283


commit 3bbbae786432275ed690733f69289fff76f78a9e
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-12-01T15:21:56Z

KAFKA-6193: Flaky 
shouldPerformMultipleReassignmentOperationsOverVariousTopics




---

[GitHub] kafka pull request #4265: KAFKA-6065: Latency metric for KafkaZkClient

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4265

KAFKA-6065: Latency metric for KafkaZkClient

Measures the latency of each request batch.

Updated existing `ZkUtils` test to use `KafkaZkClient`
instead.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-6065-async-zk-metrics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4265


commit 900cc6f1e4a075ec8c87ac61ab8aa5fb58daa6f8
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-26T01:32:43Z

KAFKA-6065: Latency metric for KafkaZkClient




---

[GitHub] kafka pull request #4262: MINOR: Temporarily disable testLogStartOffsetCheck...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4262

MINOR: Temporarily disable testLogStartOffsetCheckpoint

It's failing often and it seems like there are multiple
reasons. PR #4238 will re-enable it.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
temporarily-disable-test-log-start-offset-checkpoint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4262


commit a24d17011c886ef66a099972d76ee2962f9839e2
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-24T14:28:50Z

MINOR: Temporarily disable testLogStartOffsetCheckpoint

It's failing often and it seems like there are multiple
reasons. PR #4238 will re-enable it.




---

[GitHub] kafka pull request #4261: MINOR: Avoid intermediate strings when parsing/dec...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4261

MINOR: Avoid intermediate strings when parsing/decoding ZK JSON

Also:
- Fix bug in result type of `createSequentialPersistentPath`
- Remove duplicated code from `ReplicationUtils`
- Move `propagateIsrChanges` from `ReplicationUtils` to `KafkaZkClient`
- Add tests
- Minor clean-ups

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka zk-data-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4261


commit df33ed9ef331931cc32a5310d2717f1c65fae202
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-24T12:52:06Z

Avoid intermediate Strings when parsing/encoding JSON

commit 2e7f1913fde1a5a041e382e21d6355c322815b97
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-24T12:52:34Z

Minor clean-ups

commit fc2c8f8f153ec6a01477445c426115687680b7bd
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-24T13:18:09Z

Add test for `createSequentialPersistentPath` and fix bug

commit 8296e3e98121fadacdff00def7277c2f852b8079
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-24T13:55:39Z

Remove isr change duplication and more tests




---

[GitHub] kafka pull request #4250: KAFKA-6261: Fix exception thrown by request loggin...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4250

KAFKA-6261: Fix exception thrown by request logging if acks=0

Only expect responseAsString to be set if request logging is
enabled _and_ responseSend is defined.

Also fixed a couple of issues that would manifest themselves
if trace logging is enabled:

- `MemoryRecords.toString` should not throw exception if data is corrupted
- Generate `responseString` correctly if unsupported api versions request is
received.

Unit tests were added for every issue fixed. Also changed
SocketServerTest to run with trace logging enabled as
request logging breakage has been a common issue.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
fix-issues-when-trace-logging-is-enabled

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4250


commit 0d63d0100cfacfb76f7f28190084d28c5e468422
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-22T16:00:29Z

Generate responseString correctly if unsupported api versions request is 
received

commit 3973541214e8f442dcf29a947610ca0bd31b42a9
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-22T16:01:13Z

MemoryRecords.toString should not throw exception is data is corrupted

commit a563bac859bdc7f210f6f61f104d5b93fb129878
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-22T16:03:18Z

Don't throw exception on no op responses if request logging is enabled

commit 90993c573c52a0b675b54053f635165a3f6c4854
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-22T16:07:06Z

Fix nit




---

[GitHub] kafka pull request #4220: KAFKA-6210: IllegalArgumentException if 1.0.0 is u...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4220

KAFKA-6210: IllegalArgumentException if 1.0.0 is used for 
inter.broker.protocol.version or log.message.format.version

Added unit test for ApiVersion and testApiVersions from
Scala to Java.

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-6210-iae-if-1.0.0-inter-broker-protocol-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4220


commit 6a58580b9ae4848c730e6fee7b2424b5bdf13c97
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-15T16:04:46Z

KAFKA-6210: IllegalArgumentException if 1.0.0 is used for 
inter.broker.protocol.version or log.message.format.version




---

[GitHub] kafka pull request #4219: MINOR: Fix NPE in unregisterPartitionReassignmentI...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4219

MINOR: Fix NPE in unregisterPartitionReassignmentIsrChangeHandlers

I was looking at a transient failures of 
`shouldPerformMultipleReassignmentOperationsOverVariousTopics`
and came across a NPE and misleading log line (see below).

Not sure if this will fix the transient failure, but worth fixing anyway.

[2017-11-15 10:30:13,869] ERROR Error while creating ephemeral at 
/controller with return code: OK (kafka.zk.KafkaZkClient$CheckedEphemeral:101)
[2017-11-15 10:30:14,155] ERROR Haven't been able to send leader and isr 
requests, current state of the map is Map(101 -> Map(topic1-0 -> 
PartitionState(controllerEpoch=2, leader=101, leaderEpoch=3, isr=101, 
zkVersion=3, replicas=100,102,101, isNew=false)), 100 -> Map(topic1-0 -> 
PartitionState(controllerEpoch=2, leader=101, leaderEpoch=3, isr=101, 
zkVersion=3, replicas=100,102,101, isNew=false)), 102 -> Map(topic1-0 -> 
PartitionState(controllerEpoch=2, leader=101, leaderEpoch=3, isr=101, 
zkVersion=3, replicas=100,102,101, isNew=false))). Exception message: 
java.lang.InterruptedException 
(kafka.controller.ControllerBrokerRequestBatch:101)
[2017-11-15 10:30:14,156] ERROR Haven't been able to send metadata update 
requests to brokers Set(102, 103, 104, 101, 105), current state of the 
partition info is Map(topic1-0 -> PartitionState(controllerEpoch=1, leader=101, 
leaderEpoch=2, isr=[101], zkVersion=2, replicas=[100, 102, 101], 
offlineReplicas=[100])). Exception message: java.lang.InterruptedException 
(kafka.controller.ControllerBrokerRequestBatch:101)
[2017-11-15 10:30:14,158] ERROR [Controller id=101] Forcing the controller 
to resign (kafka.controller.KafkaController:101)
[2017-11-15 10:30:14,158] ERROR [Controller id=101] Error completing 
reassignment of partition topic1-0 (kafka.controller.KafkaController:107)
java.lang.NullPointerException
at 
kafka.controller.KafkaController$$anonfun$unregisterPartitionReassignmentIsrChangeHandlers$1.apply(KafkaController.scala:784)
at 
kafka.controller.KafkaController$$anonfun$unregisterPartitionReassignmentIsrChangeHandlers$1.apply(KafkaController.scala:783)

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-npe-unregister-zk-listener

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4219


commit 7ff71b19c5ff24a2e67a94579fc770dfd67722cd
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-15T14:27:37Z

Avoid NPE in `unregisterPartitionReassignmentIsrChangeHandlers`

commit df05c6e2f26bde5bff747792a479cf1226adc7c6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-15T14:30:54Z

Improve logging if ephemeral node creation fails




---

[GitHub] kafka pull request #4202: MINOR: Exclude Committer Checklist section from co...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4202

MINOR: Exclude Committer Checklist section from commit message

### Committer Checklist
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
exclude-committer-checklist-when-merging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4202.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4202


commit 23605d55643d1e517944bebe0aaaf42e6b602322
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-10T11:50:48Z

MINOR: Exclude Committer Checklist section from commit message




---

[GitHub] kafka pull request #4201: MINOR: Exclude PULL_REQUEST_TEMPLATE.md from rat c...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4201

MINOR: Exclude PULL_REQUEST_TEMPLATE.md from rat checks

### Committer Checklist
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
exclude-pull-request-template-from-rat

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4201


commit 55da17602c3fdd9198c509652c6d709528e2182d
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-10T10:23:35Z

MINOR: Exclude PULL_REQUEST_TEMPLATE.md from rat checks




---

[GitHub] kafka pull request #551: KAFKA-2858; Introduce `SimplePrincipal` and use it ...

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/551


---

[GitHub] kafka pull request #4200: MINOR: Update to Scala 2.11.12 (part 2)

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4200

MINOR: Update to Scala 2.11.12 (part 2)

Missed a few places in the previous commit.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka scala-2.11.12-part2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4200


commit 491e33b8f37ec259f82efbad34c305d5e34eb275
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-09T16:46:57Z

MINOR: Update to Scala 2.11.12 (part 2)

Missed a few places in the previous commit.




---

[GitHub] kafka pull request #4192: MINOR: Remove unnecessary batch iteration in FileR...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4192

MINOR: Remove unnecessary batch iteration in FileRecords.downConvert



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
avoid-unnecessary-batch-iteration-in-down-convert

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4192


commit 7d1f1d1741079b0f5a255a91c3a17c101049bec2
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-08T08:55:35Z

MINOR: Remove unnecessary batch iteration in FileRecords.downConvert




---

[GitHub] kafka pull request #4185: MINOR: Update Scala 2.11 to 2.11.12

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4185

MINOR: Update Scala 2.11 to 2.11.12

The main change is Java 9 support.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka scala-2.11.12

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4185


commit 832a5ea7e2b12a0f50565a541d5f3edd660e2832
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-06T23:39:27Z

MINOR: Update Scala 2.11 to 2.11.12

The main change is Java 9 support.




---

[GitHub] kafka pull request #4174: MINOR: Add pull request template

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4174

MINOR: Add pull request template



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka pull-request-template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4174


commit d4334d8e1fd144ce08dae8767cb8181f16223157
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-03T13:06:03Z

Add pull request template




---

[GitHub] kafka pull request #4172: MINOR: Remove clients/out directory

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4172

MINOR: Remove clients/out directory

It was committed inadvertently.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-out-folder

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4172


commit 3d87fe67a23d254fbb04bc1012e69482f91ef05a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-11-02T20:34:06Z

MINOR: Remove clients/out directory

It was committed inadvertently.




---

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

[ijuma]

Github user ijuma commented on a diff in the pull request:

https://github.com/apache/kafka-site/pull/107#discussion_r148400321
  
--- Diff: 100/javadoc/script.js ---
@@ -1,30 +0,0 @@
-function show(type)
-{
-count = 0;
-for (var key in methods) {
-var row = document.getElementById(key);
-if ((methods[key] &  type) != 0) {
-row.style.display = '';
-row.className = (count++ % 2) ? rowColor : altColor;
-}
-else
-row.style.display = 'none';
-}
-updateTabs(type);
-}
-
-function updateTabs(type)
-{
-for (var value in tabs) {
-var sNode = document.getElementById(tabs[value][0]);
-var spanNode = sNode.firstChild;
-if (value == type) {
-sNode.className = activeTableTab;
-spanNode.innerHTML = tabs[value][1];
-}
-else {
-sNode.className = tableTab;
-spanNode.innerHTML = "" + tabs[value][1] + "";
-}
-}
-}
--- End diff --

Hmm, is it OK that this file was deleted?


---

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

[ijuma]

Github user ijuma commented on a diff in the pull request:

https://github.com/apache/kafka-site/pull/107#discussion_r148393662
  
--- Diff: 10/documentation.html ---
@@ -69,15 +69,15 @@
 8. Kafka Connect
 
 
-9. Kafka 
Streams
+9. Kafka 
Streams
 
 Kafka Streams is a client library for processing and analyzing 
data stored in Kafka. It builds upon important stream processing concepts such 
as properly distinguishing between event time and processing time, windowing 
support, exactly-once processing semantics and simple yet efficient management 
of application state.
 
 
 Kafka Streams has a low barrier to entry: You can quickly 
write and run a small-scale proof-of-concept on a single machine; and you only 
need to run additional instances of your application on multiple machines to 
scale up to high-volume production workloads. Kafka Streams transparently 
handles the load balancing of multiple instances of the same application by 
leveraging Kafka's parallelism model.
 
 
-Learn More about Kafka Streams read this Section.
+Learn More about Kafka Streams read this Section.
--- End diff --

Seems like this is not right?


---

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

[ijuma]

Github user ijuma commented on a diff in the pull request:

https://github.com/apache/kafka-site/pull/107#discussion_r148303796
  
--- Diff: downloads.html ---
@@ -9,48 +9,75 @@
 
 You can verify your download by following these http://www.apache.org/info/verification.html;>procedures and using 
these http://kafka.apache.org/KEYS;>KEYS.
 
+1.0.0
 
-   1.0.0
-   
-   
-   Released November 1, 
2017
-   
-   
-   https://dist.apache.org/repos/dist/release/kafka/1.0.0/RELEASE_NOTES.html;>Release
 Notes
-   
-   
-   Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.sha512;>sha512)
-   
-   
-   Binary downloads:
-   
-   
Scala 2.11 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.11-1.0.0.tgz;>kafka_2.11-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.sha512;>sha512)
-   
Scala 2.12 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.12-1.0.0.tgz;>kafka_2.12-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.sha512;>sha512)
-   
-   We build for multiple 
versions of Scala. This only matters if you are using Scala and you want a 
version built for the same Scala version you use. Otherwise any version should 
work (2.11 is recommended).
-   
-   
+
+
+Released November 1, 2017
+
+
+Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.md5;>md5)
--- End diff --

I was linking to the sha512 file since md5 is deprecated these days.


---

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

[ijuma]

Github user ijuma commented on a diff in the pull request:

https://github.com/apache/kafka-site/pull/107#discussion_r148303944
  
--- Diff: downloads.html ---
@@ -9,48 +9,75 @@
 
 You can verify your download by following these http://www.apache.org/info/verification.html;>procedures and using 
these http://kafka.apache.org/KEYS;>KEYS.
 
+1.0.0
 
-   1.0.0
-   
-   
-   Released November 1, 
2017
-   
-   
-   https://dist.apache.org/repos/dist/release/kafka/1.0.0/RELEASE_NOTES.html;>Release
 Notes
-   
-   
-   Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.sha512;>sha512)
-   
-   
-   Binary downloads:
-   
-   
Scala 2.11 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.11-1.0.0.tgz;>kafka_2.11-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.sha512;>sha512)
-   
Scala 2.12 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.12-1.0.0.tgz;>kafka_2.12-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.sha512;>sha512)
-   
-   We build for multiple 
versions of Scala. This only matters if you are using Scala and you want a 
version built for the same Scala version you use. Otherwise any version should 
work (2.11 is recommended).
-   
-   
+
+
+Released November 1, 2017
+
+
+Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.md5;>md5)
+
+
+Binary downloads:
+
+Scala 2.11 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.11-1.0.0.tgz;>kafka_2.11-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.md5;>md5)
+Scala 2.12 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.12-1.0.0.tgz;>kafka_2.12-1.0.0.tgz
 (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.asc;>asc,
 https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.md5;>md5)
+
+We build for multiple versions of Scala. This only matters 
if you are using Scala and you want a version built for the same Scala version 
you use. Otherwise any version should work (2.11 is recommended).
+
+
+
+
+Kafka 1.0.0 is no mere bump of the version number. The Apache 
Kafka Project Management Committee has packed a number of valuable enhancements 
into the release. Here is a summary of a few of them:
+
+
+
+
+Since its introduction in version 0.10, the Streams API 
has become hugely popular among Kafka users, including the likes of Pinterest, 
Rabobank, Zalando, and The New York Times. In 1.0, the the API continues to 
evolve at a healthy pace. To begin with, the builder API has been improved 
(KIP-120). A new API has been added to expose the state of active tasks at 
runtime (KIP-130). The new cogroup API makes it much easier to deal with 
partitioned aggregates with fewer StateStores and fewer moving parts in your 
code (KIP-150). Debuggability gets easier with enhancements to the print() and 
writeAsText() methods (KIP-160).

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

[ijuma]

Github user ijuma commented on a diff in the pull request:

https://github.com/apache/kafka-site/pull/107#discussion_r148303219
  
--- Diff: 10/documentation.html ---
@@ -0,0 +1,83 @@
+
+
+<!--#include virtual="js/templateData.js" -->
+
+
+
+
+
+
+   
+   
+   
+Documentation
+Kafka 0.11.0 Documentation
+Prior releases: 0.7.x, 0.8.0, 0.8.1.X, 0.8.2.X, 0.9.0.X, 0.10.0.X, 0.10.1.X, 0.10.2.X.
--- End diff --

This needs to be updated.


---

[GitHub] kafka pull request #4158: KAFKA-2903: FileRecords.read doesn't handle size >...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4158

KAFKA-2903: FileRecords.read doesn't handle size > sizeInBytes when start 
is not zero



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-2903-file-records-read-slice-size-greater

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4158


commit b251038e2c569fda88376b85918a5003927b8152
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-30T11:45:00Z

KAFKA-2903: FileRecords.read doesn't handle size > sizeInBytes when start 
is not zero




---

[GitHub] kafka pull request #4154: KAFKA-4203: Align broker default for max.message.b...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4154

KAFKA-4203: Align broker default for max.message.bytes with Java producer 
default



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-4203-align-broker-max-message-bytes-with-java-producer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4154


commit 15cf53bf2643bd0ea164d70f76e36acdd65d0990
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-28T15:46:44Z

KAFKA-4203: Align broker default for max.message.bytes with Java producer 
default




---

[GitHub] kafka pull request #4152: MINOR: Eliminate unnecessary Topic(And)Partition a...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4152

MINOR: Eliminate unnecessary Topic(And)Partition allocations in Controller

- Eliminated all the unnecessary allocations of `TopicPartition` and
`TopicAndPartition` in the Controller. We now use the former
in the Controller (bringing it inline with the rest of the non legacy
code).
- Fixed missed `Listener` -> `Handler` renames for companion
objects.
- More String.format -> String interpolation conversions (the former
is roughly 5 times more expensive).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
controller-topic-partition-and-other-clean-ups

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4152


commit 109dc13dbbf2ef3ae8c1d4857cc30c059295b4b8
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-27T10:25:34Z

Use TopicPartition in Controller and avoid allocations

commit 4d04e0c69c17d3c9dd16e901d54e158c76962087
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-28T08:04:23Z

Missed `Listener` -> `Handler` renames in companion objects

commit a259462c921454a129471a019700f44f16c33ab1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-28T08:33:43Z

Various log clean-ups




---

[GitHub] kafka pull request #4144: MINOR: Ensure that the producer in testAlterReplic...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4144

MINOR: Ensure that the producer in testAlterReplicaLogDirs is always closed

Failure to close the producer could cause a transient failure, more details
below.

The request timeout was only 2 seconds, exceptions thrown were not
propagated and the producer would not be closed. If the exception
was thrown during `send`, we did not increment `numMessages`
allowing the test to pass.

I have increased the timeout to 10 seconds and made sure that
exceptions are propagated.

Example of the error:

```text
kafka.api.SaslSslAdminClientIntegrationTest > classMethod STARTED

kafka.api.SaslSslAdminClientIntegrationTest > classMethod FAILED
java.lang.AssertionError: Found unexpected threads, 
allThreads=Set(metrics-meter-tick-thread-2, Signal Dispatcher, main, Reference 
Handler, scala-execution-context-global-164, kafka-producer-network-thread | 
producer-1, scala-execution-context-global-166, Test worker, 
scala-execution-context-global-1249, /0:0:0:0:0:0:0:1:58910 to 
/0:0:0:0:0:0:0:1:43025 workers Thread 2, Finalizer, /0:0:0:0:0:0:0:1:58910 to 
/0:0:0:0:0:0:0:1:43025 workers Thread 3, scala-execution-context-global-163, 
metrics-meter-tick-thread-1)
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
ensure-producer-is-closed-test-alter-replica-log-dirs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4144


commit 11153a454cd7c561202ce3b86891715a3670b2c6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-27T12:58:59Z

MINOR: Ensure that the producer in testAlterReplicaLogDirs is always closed

The request timeout was only 2 seconds and if an exception was thrown,
it would not be propagated and the producer would be leaked. If the 
exception
was thrown during `send`, we would not increment the counter and the
test would pass.

Increased the timeout to 10 seconds and made sure that a producer
exception is now propagated.




---

[GitHub] kafka pull request #4143: MINOR: PartitionReassignmentHandler should generat...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4143

MINOR: PartitionReassignmentHandler should generate event only when znode 
is created and eliminate unnecessary allocations

As suggested by Jun in https://github.com/apache/kafka/pull/4141, we
only need to generate the event when the znode is created (
controller failover restarts the reassignment without generating
an event).

I also took the chance to eliminate all the unnecessary allocations
of `TopicPartition` and `TopicAndPartition`. We now use the former
in the Controller (bringing it inline with the rest of the non legacy
code).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
partition-reassignment-ignore-handle-deletion-and-data-change

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4143


commit f2a81b5ef493e428d93be3340148f101089d87e3
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-27T09:46:02Z

Don't create PartitionReassignment event if the znode is deleted or changed

commit 9f448fda833db54e2d558fc69f0e882f9262fab6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-27T10:25:34Z

Use TopicPartition in Controller and avoid allocations




---

[GitHub] kafka pull request #4142: MINOR: Use Scala Future in CoreUtils test

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4142

MINOR: Use Scala Future in CoreUtils test

Also rename UtilsTest to CoreUtilsTest and note
that `getOrElseUpdate` has the right behaviour
in Scala 2.12.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
use-scala-futures-in-core-utils-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4142


commit 5a1b360f29dbecca0e66e74e0516b51f686baaef
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-27T02:46:46Z

MINOR: Use Scala Future in CoreUtils test

Also rename UtilsTest to CoreUtilsTest.




---

[GitHub] kafka pull request #4138: MINOR: Revert EmbeddedZooKeeper rename

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4138

MINOR: Revert EmbeddedZooKeeper rename

Even though this class is internal, it's widely
used by other projects and it's better to avoid
breaking them until we have a publicly supported
test library.

Also made some fields private since users should
not need access to them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka revert-embedded-zookeeper-rename

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4138


commit 0f2a1e3559c0760c4337b875eb426f0b361bb2dc
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-26T10:52:01Z

MINOR: Revert EmbeddedZooKeeper rename

Even though this class is internal, it's widely
used by other projects and it's better to avoid
breaking them until we have a publicly supported
test library.

Also made some fields private since users should
not need access to them.




---

[GitHub] kafka pull request #4117: MINOR: Configure owasp.dependencycheck gradle plug...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4117

MINOR: Configure owasp.dependencycheck gradle plugin

It seems to output a few false positives, but still
worth verifying.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka dependency-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4117


commit 9a4860f94c10685a1b88592e3248ae460072753d
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-23T10:49:07Z

MINOR: Configure owasp.dependencycheck gradle plugin

It seems to output a few false positives, but still
worth verifying.




---

[GitHub] kafka pull request #4112: MINOR: Rename ZookeeperClient to ZooKeeperClient a...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4112

MINOR: Rename ZookeeperClient to ZooKeeperClient and move it to 
kafka.zookeeper



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
rename-zookeeper-client-and-move-to-zookeper-package

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4112


commit 96f641df6293cef149181c80f4cc1d14bce11e39
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-22T07:57:26Z

MINOR: Rename ZookeeperClient to ZooKeeperClient and move it to 
kafka.zookeeper




---

[GitHub] kafka pull request #4102: MINOR: Update Scala to 2.12.4

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4102

MINOR: Update Scala to 2.12.4

Mainly for Java 9 fixes and improved compilation times (5-10% reduction).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka update-scala-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4102


commit b82a1df618f5fbe8c8cfc3fa8759c1e62888a9fa
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-20T09:58:40Z

MINOR: Update Scala to 2.12.4




---

[GitHub] kafka pull request #4097: MINOR: Update docs with regards to max.in.flight a...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4097

MINOR: Update docs with regards to max.in.flight and idempotent producer

The idempotent producer doesn't change that setting any more and the
accepted range has changed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
fix-javadoc-wrt-max-in-flight-for-idempotent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4097


commit 6966d70353374a68ad53dcaf8250b2c966d111c3
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-19T09:38:50Z

MINOR: Update docs with regards to max.in.flight and idempotent producer

The idempotent producer doesn't change that setting any more and the
accepted range has changed.




---

[GitHub] kafka pull request #4088: MINOR: Controller and async ZookeeperClient improv...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4088

MINOR: Controller and async ZookeeperClient improvements (WIP)

More to come.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka async-zkclient-cleanups

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4088.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4088


commit e538ba1acbcfc97e752f596e746fea2f2d4c8b38
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-18T17:27:46Z

WIP




---

[GitHub] kafka pull request #4087: MINOR: Remove dead code

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4087

MINOR: Remove dead code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-dead-code

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4087


commit 9acf274dab1f9df0818d9fce3819b7a0543188f0
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-18T15:54:55Z

MINOR: Remove dead code




---

[GitHub] kafka pull request #4067: MINOR: Merge script improvements

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4067

MINOR: Merge script improvements

- Remove "list commits" since we never use it
- Fix release branch detection to just look
for branches that start with digits
- Make script executable

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka merge-script-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4067






---

[GitHub] kafka pull request #4066: MINOR: Don't register signal handlers if running o...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4066

MINOR: Don't register signal handlers if running on Windows

Also remove stray printStackTrace in test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
dont-register-signal-handler-windows

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4066


commit a0f21badac9794b0dc456df7a5c5d15c4bedd8f8
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-12T12:02:09Z

MINOR: Don't register signal handlers if running on Windows

Also remove stray printStackTrace in test.




---

[GitHub] kafka pull request #4040: KAFKA-5829; Remove stray `printStackTrace()` in te...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4040

KAFKA-5829; Remove stray `printStackTrace()` in test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-5829-follow-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4040


commit c82c2050127b6d1d53a05f7ad73b77a58b0af01e
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-08T11:56:42Z

Remove stray `printStackTrace()` in test




---

[GitHub] kafka pull request #4034: MINOR: Remove TLS renegotiation code

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4034

MINOR: Remove TLS renegotiation code

This has been disabled since the start and since
it's removed in TLS 1.3, there are no plans to
ever support it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-tls-renegotiation-support

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4034


commit c99acab314d699ee69a46a9dd2fd0cd135832dd8
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-06T10:39:00Z

MINOR: Remove TLS renegotiation code

This has been disabled since the start and since
it's removed in TLS 1.3, there are no plans to
ever support it.




---

[GitHub] kafka pull request #4023: KAFKA-5829: Only delete producer snapshots before ...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4023

KAFKA-5829: Only delete producer snapshots before the recovery point



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5829-avoid-reading-older-segments-on-hard-shutdown

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4023.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4023


commit 2a98d68a85f97507423cc50cd002e2db27a47c60
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-05T13:26:04Z

Several clean ups in Log, LogManager, etc.

commit 291c73e54b808d0c0af57c08107c3c8f357e8188
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-05T13:57:07Z

KAFKA-5829: Only delete producer snapshots before the recovery point




---

[GitHub] kafka pull request #4016: MINOR: Simplify log cleaner and fix compiler warni...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4016

MINOR: Simplify log cleaner and fix compiler warnings

- Simplify LogCleaner.cleanSegments and add comment regarding thread
unsafe usage of `LogSegment.append`. This was a result of investigating
KAFKA-4972.
- Fix compiler warnings.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
simplify-log-cleaner-and-fix-warnings

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4016.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4016


commit 3b26b21c4a41b9857d48a09a63a560228924df4f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-04T13:57:03Z

Simplify LogCleaner.cleanSegments and add comment regarding thread unsafe 
usage of `LogSegment.append`

commit a1e50d8fbffc977646397f0446efeaa798816d87
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-04T13:57:20Z

Fix compiler warnings




---

[GitHub] kafka pull request #4007: MINOR: Java 9 version handling improvements

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/4007

MINOR: Java 9 version handling improvements

- Upgrade Gradle to 4.2.1, which handles Azul Zulu 9's version
correctly.
- Add tests to our Java version handling code
- Refactor the code to make it possible to add tests
- Rename `isIBMJdk` method to use consistent naming
convention.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
java-9-version-handling-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4007


commit 1ef63b35c7b1fb5b568f0a71924f3a3483c6eb1b
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-03T11:16:01Z

Add tests for java version compatibility methods

commit 236bffc910bd46601715ed1086f5986229b74cb9
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-03T11:16:33Z

Rename `Java.isIBMJdk` method to use consistent convention

commit c82ca6b7c522efa4be432ab3f2c67145aa0870d8
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-10-03T11:17:01Z

Update to Gradle 4.2.1




---

[GitHub] kafka pull request #3996: KAFKA-5746; Return 0.0 from Metric.value() instead...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3996

KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception

This is less likely to break custom metric reporters and since the method
is deprecated, people will be warned about this potential issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
avoid-exception-in-measurable-value

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3996


commit e97844d036dfe1bc2e795ddb12b5c61201ab3c9c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-29T20:14:57Z

KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception

This is less likely to break custom metric reporters and since the method
is deprecated, people will be warned about this potential issue.




---

[GitHub] kafka pull request #3989: KAFKA-5746; Fix conversion count computed in `down...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3989

KAFKA-5746; Fix conversion count computed in `downConvert`

It should be the number of records instead of the
number of batches.

A few additional clean-ups: minor renames,
removal of unused code, test fixes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5746-health-metrics-follow-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3989.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3989


commit a85feb150a4aea8d879535c27ddb857278790e63
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-29T01:40:29Z

KAFKA-5746; Fix downConvert's conversion count

It should be the number of records instead of the
number of batches.

A few additional clean-ups: minor renames,
removal of unused code, test fixes.




---

[GitHub] kafka pull request #3954: KAFKA-5758: Don't fail fetch request if replica is...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3954

KAFKA-5758: Don't fail fetch request if replica is no longer a follower for 
a partition

We log a warning instead, which is what we also do if the partition hasn't 
been created
yet.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5758-dont-fail-fetch-request-if-replica-is-not-follower

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3954


commit 7e12d408619b41a37cc40f4c294d47875df312ce
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-25T07:33:46Z

KAFKA-5758: Don't fail fetch request if replica is no longer a follower for 
a partition

We log a warning instead, which is what we also do if the partition hasn't 
been created
yet.




---

[GitHub] kafka pull request #3945: MINOR: Move ChannelState.exception() to its own cl...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3945

MINOR: Move ChannelState.exception() to its own class

Given that Java doesn't support pattern matching, the benefit
is not as clear.

Also implemented ChannelState.toString and removed some
unused imports.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka improve-channel-state-structure

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3945.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3945


commit 78a04b1044b7d987a057a74361a5372feded30de
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-22T09:36:52Z

MINOR: Move ChannelState.exception() to its own class

Given that Java doesn't support pattern matching, the benefit
is not as clear.

Also implemented ChannelState.toString and removed some
unused imports.




---

[GitHub] kafka pull request #3930: KAFKA-5856; AdminClient.createPartitions() follow-...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3930

KAFKA-5856; AdminClient.createPartitions() follow-up (KIP-195)

- Remove DelayedCreatePartitions to reduce code duplication
- Avoid unnecessary ZK calls (call it once per request instead
of once per topic, if possible)
- Simplify code
- A few minor clean-ups

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5856-admin-client-creation-partitions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3930






---

[GitHub] kafka pull request #3923: MINOR: Upgrade to Gradle 4.2

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3923

MINOR: Upgrade to Gradle 4.2

It includes the usual performance improvements, but
the nicest improvement for me is that the findBugs
plugin no longer outputs almost 1000 lines in
Jenkins builds:


https://docs.gradle.org/4.2/release-notes.html#findbugs-plugin-does-not-render-analysis-progress-anymore

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka gradle-4.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3923.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3923


commit 79517c5dabcabe4aaf7b9d7c495d54a032db4f56
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-20T15:49:00Z

MINOR: Upgrade to Gradle 4.2

It includes the usual performance improvements, but
the nicest improvement for me is that the findBugs
plugin no longer outputs almost 1000 lines in
Jenkins builds:


https://docs.gradle.org/4.2/release-notes.html#findbugs-plugin-does-not-render-analysis-progress-anymore




---

[GitHub] kafka pull request #3910: MINOR: Only include transactional id in LogContext...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3910

MINOR: Only include transactional id in LogContext if it's set



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
transactional-id-should-be-optional-in-log-context

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3910.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3910


commit 372e5608035776103c793e7457012cdad78fde24
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-19T21:03:26Z

MINOR: Only include transactional id in LogContext if it's set




---

[GitHub] kafka pull request #3901: MINOR: Fix unresolvable address in `testUnresolvab...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3901

MINOR: Fix unresolvable address in `testUnresolvableConnectString`

Before this change, the test always failed on my MacBook Pro.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
fix-unresolvable-address-in-zookeeper-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3901


commit 5911eac6a25c1212d2b54664ea6ae478279bfdac
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-19T09:46:08Z

MINOR: Fix unresolvable address in `testUnresolvableConnectString`

Before this change, the test always failed on my MacBook Pro.




---

[GitHub] kafka pull request #3895: MINOR: Protocol schema refactor follow-up

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3895

MINOR: Protocol schema refactor follow-up

Minor clean-ups from the review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
protocol-schema-refactor-follow-ups

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3895


commit 133253b286003bdefeb40c487a2ca12d648db057
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-19T04:10:36Z

MINOR: Protocol schema refactor follow-up

Minor clean-ups from the review.




---

[GitHub] kafka pull request #3890: MINOR: Fix replica_verification_tool.py to handle ...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3890

MINOR: Fix replica_verification_tool.py to handle slight change in output 
format

The string representation of TopicPartition was changed to be
{topic}-{partitition} consistently in the following commit:

f6f56a645bb1c5ec6810c024ba517e43bf77056c

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-replica-verification-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3890


commit 530f64eb4645ba71330330341e8dccea8a54bc2c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-18T12:14:39Z

MINOR: Fix replica_verification_tool.py to handle slight change in output 
format

The string representation of TopicPartition was changed to be
{topic}-{partitition} consistently in the following commit:

f6f56a645bb1c5ec6810c024ba517e43bf77056c




---

[GitHub] kafka pull request #3881: MINOR: Update powermock and enable its tests when ...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3881

MINOR: Update powermock and enable its tests when running with Java 9

Also fix WorkerTest to use the correct `Mock` annotations. 
`org.easymock.Mock`
is not supported by PowerMock 2.x.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-5884-powermock-java

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3881


commit 3913864db02dde559c97808e2e5fc3a0833f38b6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-17T09:54:11Z

MINOR: Update powermock and enable its tests when running with Java 9




---

[GitHub] kafka pull request #3879: KAFKA-5915: Support unmapping of mapped/direct buf...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3879

KAFKA-5915: Support unmapping of mapped/direct buffers in Java 9

As mentioned in MappedByteBuffers' class documentation, its
implementation was inspired by Lucene's MMapDirectory:


https://github.com/apache/lucene-solr/blob/releases/lucene-solr/6.6.1/lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java#L315

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5915-unmap-mapped-buffers-java-9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3879


commit e168f970ed726524b1d7f6ec70dfb4bfff8da754
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-16T02:05:50Z

KAFKA-5915: Support unmapping of mapped/direct buffers in Java 9




---

[GitHub] kafka pull request #3609: MINOR: Make the state change log more consistent

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/3609


---

[GitHub] kafka pull request #3869: MINOR: Make the state change log more consistent

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3869

MINOR: Make the state change log more consistent

Use logIdent to achieve this.

Also fixed an issue where we were logging about replicas going offline with
an empty set of replicas (i.e. no replicas had gone offline so no need to 
log).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka improve-state-change-log

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3869


commit a9e3c540a4bf480059678708701af3680da8a589
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-02T10:39:59Z

MINOR: Only log about marking replicas as offline if there is a replica

I noticed a bunch of these log messages with an empty set for the replicas.

commit c3cee6f9cbb16d9173fde25e28b4c7afb6383803
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-03T12:36:24Z

Use `logIdent` for more consistent state change logger

commit 3eaa96ed421f40a20a4a093a7e752c17de53d6f1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-03T12:38:52Z

Remove duplication in `KafkaController` log messages

We were repeating information already available due to the `logIdent`.

commit 01a7d243501fb949e4825318431beafd1c33b051
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-03T12:43:07Z

Avoid unnecessary `toArray`

commit aa04ef55dbc0d1e362c042d605700fb222f6b065
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-15T01:45:24Z

Make it possible to add the controller epoch to the log prefix

commit 7c99c85947f04036d544025fc2b3c873198334c3
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-15T01:55:20Z

Share an instance of the underlying state change logger

commit d040105e629dcdf7770eb70e8b81bff02f0330d7
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-15T10:49:35Z

Logging consistency improvements




---

[GitHub] kafka pull request #3856: MINOR: Remove unused SecurityProtocol.TRACE

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3856

MINOR: Remove unused SecurityProtocol.TRACE

It adds complexity for no benefit since we don't use
it anywhere.

Also removed a few unused imports, variables and
default parameters.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-security-protocol-trace

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3856


commit 92583abba75954cf84efe58e2d28a5632143269a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-14T09:38:23Z

MINOR: Remove unused SecurityProtocol.TRACE

It adds complexity for no benefit since we don't use
it anywhere.

commit c69e3be11afdda12b00993e3242e786ec33aac73
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-14T09:39:00Z

Remove unused imports, variables and default parameters




---

[GitHub] kafka pull request #3845: KAFKA-4501: Fix EasyMock and disable PowerMock tes...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3845

KAFKA-4501: Fix EasyMock and disable PowerMock tests under Java 9

- EasyMock 3.5 supports Java 9.
- Removed unnecessary PowerMock dependency from 3 tests.
- Disable remaining PowerMock tests when running with Java 9
until https://github.com/powermock/powermock/issues/783 is
done.
- Once we merge this PR, we can run tests on PRs with Java 9.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-4501-easymock-powermock-java-9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3845


commit ab60da36358a792e1079aed25859828602c1a619
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-21T13:51:00Z

Use EasyMock instead of PowerMock in 3 connect tests

commit 6e0f8c7d9c147d0340c711b6edd8cbadac344a31
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-21T13:51:37Z

Exclude PowerMock tests if running with Java 9

commit f076943217f522d6a5a516a559939dc1e7711b40
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-13T12:02:35Z

Upgrade easymock to 3.5




---

[GitHub] kafka pull request #3844: MINOR: Use sha512 instead of sha2 suffix in releas...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3844

MINOR: Use sha512 instead of sha2 suffix in release artifacts

As per Apache guidelines:

http://www.apache.org/dev/release-distribution#sigs-and-sums

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-sha512-naming

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3844


commit 63683bbe7a6ad19dd4f54456e9e1b502cee73687
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-13T11:34:57Z

MINOR: Use sha512 instead of sha2 suffix in release artifacts

As per Apache guidelines:
http://www.apache.org/dev/release-distribution#sigs-and-sums




---

[GitHub] kafka pull request #3834: MINOR: Tweak detection of kafka server start-up in...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3834

MINOR: Tweak detection of kafka server start-up in system tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
tweak-system-test-regex-for-detecting-server-start-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3834


commit e378b22c63437cf513104126ecbe273a04185883
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-12T03:43:35Z

MINOR: Tweak detection of kafka server start-up in system tests




---

[GitHub] kafka pull request #3808: MINOR: Always specify the keystore type in system ...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3808

MINOR: Always specify the keystore type in system tests

Also throw an exception if a null keystore type is seen
in `SecurityStore`. This should never happen.

The default keystore type has changed in Java 9 (
http://openjdk.java.net/jeps/229), so we need to
be explicit to have consistent behaviour across
Java versions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka set-jks-explicitly-in-system-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3808


commit cc9d9b50736ce80e93d318485e2762976050204f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-07T14:37:58Z

MINOR: Always specify the keystore type in system tests

Also throw an exception if a null keystore type is seen
in `SecurityStore`. This should never happen.

The default keystore type has changed in Java 9 (
http://openjdk.java.net/jeps/229), so we need to
be explicit to have consistent behaviour across
Java versions.




---

[GitHub] kafka pull request #3801: MINOR: Include response in request log

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3801

MINOR: Include response in request log

It's implemented such that there is no overhead if request logging is
disabled.

Also:
- Reduce metrics computation duplication in `updateRequestMetrics`
- Change a couple of log calls to use string interpolation instead of 
`format`
- Fix a few compiler warnings related to unused imports and unused default
arguments.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka log-response-in-request-log

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3801.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3801


commit f3d3c7436e5049b833655797757af736b0d8f7a1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-06T12:23:44Z

MINOR: Add response to the request log

commit 529a6fdd2bb929c04abe76d9e2644ca1fcd47d85
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-06T12:39:22Z

Attempt at reducing duplication in `updateRequestMetrics`

commit da2dd69c92ca44b44ca436d1bf682f79596c8c0d
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-06T12:40:12Z

Use string interpolation instead of `format` in a couple of log calls

commit 200915466ca5647ffd20198d35790412ae90f5c9
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-06T12:40:54Z

Fix some compiler warnings




---

[GitHub] kafka pull request #3789: MINOR: Fix a couple of ftp related issues in relea...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3789

MINOR: Fix a couple of ftp related issues in release.py



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka ftp-release-py-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3789.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3789


commit 11d7afeeb36b694ed4df06a0f48ed501b2c54edb
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-09-05T09:17:56Z

MINOR: Fix a couple of ftp related issues in release.py




---

[GitHub] kafka pull request #3738: KAFKA-5790: SocketServer.processNewResponses shoul...

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/3738


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3738: MINOR: Remove try/finally from processNewResponses

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3738

MINOR: Remove try/finally from processNewResponses

The previous code would skip a response if an exception was thrown.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-process-new-responses

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3738


commit 68175a15c327ab9f31e9e2120601310694e1c57a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-25T10:16:03Z

MINOR: Remove try/finally from processNewResponses




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3734: KAFKA-5785; Always close connection if KafkaChanne...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3734

KAFKA-5785; Always close connection if KafkaChannel.setSend throws exception



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5785-always-close-connection-if-set-send-throws-exception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3734


commit 12d2fb4c151b2786b9f6db687cae6cda55155f37
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-25T09:06:32Z

KAFKA-5785; Always close connection if KafkaChannel.setSend throws exception




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka-site issue #71: KAFKA-4869: Update 0.10.2.0 upgrade notes

[ijuma]

Github user ijuma commented on the issue:

https://github.com/apache/kafka-site/pull/71
  
Thanks for the PR, we also need to fix it in the main repo: 
https://github.com/apache/kafka/blob/0.10.2/docs/upgrade.html#L90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3706: KAFKA-5753: ShellTest.testRunProgramWithErrorRetur...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3706

KAFKA-5753: ShellTest.testRunProgramWithErrorReturn fails on macOS



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-shell-test-mac

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3706


commit 0992b7ae018fb2c9d6875431ea217329525f05cd
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-21T14:53:46Z

KAFKA-5753: ShellTest.testRunProgramWithErrorReturn fails on macOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3658: MINOR: AdminClient should register with `AppInfoPa...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3658

MINOR: AdminClient should register with `AppInfoParser`

Also make "created" message more consistent across clients.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
admin-client-should-register-with-app-info-parser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3658


commit 446c25e01486c823dfa5ba6d98821452ee0c7b0c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-11T12:37:05Z

MINOR: AdminClient should register with `AppInfoParser`

Also make "created" message more consistent across clients.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3647: KAFKA-4501: Java 9 compilation fixes

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3647

KAFKA-4501: Java 9 compilation fixes

Compilation fixes:
- Avoid ambiguity error when appending to Properties in Scala code
- Use position() and limit() to fix ambiguity issue
- Disable findBugs if Java 9 is used

Warning fixes:
- Avoid deprecated Class.newInstance in Utils.newInstance
- Silence a few Java 9 deprecation warnings
- var -> val and unused fixes

Also:
- Set --release option if building with Java 9

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-4501-support-java-9

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3647.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3647


commit e9cde9fe45997b84f87985637deb2ec6872aaa4d
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:14:03Z

Avoid ambiguity error when appending to Properties in Scala code

commit bce6848a5e03efb13e56b3a915e86d7f889ca16e
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:14:40Z

Avoid deprecated Class.newInstance in Utils.newInstance

commit 5d36fb7ff6559e6bb9211fcfc665a69393fb829a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:26:41Z

Use position() and limit() to fix ambiguity issue

commit e1b9849da180da6bc8fe3fbc6b0895c4f3f9fc7c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:29:18Z

var -> val and unused fixes

commit 86d81ccc370ebbad3f6f542d6b5c92306a3810a0
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:30:04Z

Silence a few Java 9 deprecation warnings

commit 1fca2f0acc53e71904aa0c37f871892e82679d1f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-01T10:05:54Z

Enable --release and disable findBugs if Java 9 is used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3634: MINOR: Deprecate LogConfig.Compact

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3634

MINOR: Deprecate LogConfig.Compact

It actually refers to the `delete` cleanup policy.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-misleading-compact-log-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3634


commit fba45066f843f6f65d871e82a13b393f82315d1a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-07T11:34:19Z

MINOR: Deprecate LogConfig.Compact

It actually refers to the `delete` cleanup policy.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3619: MINOR: Update dependencies for 1.0.0 release

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3619

MINOR: Update dependencies for 1.0.0 release

Notable updates:

1. Gradle 4.1 includes a number of performance and
CLI improvements as well as initial Java 9 support.
There's also the option of disabling the noisy
findBugs output during builds, which I have done.

2. Scala 2.12.3 has substantial compilation time
improvements.

3. lz4-java 1.4 allows us to remove a workaround in
KafkaLZ4BlockInputStream (not done in this PR).

4. snappy-java 1.1.4 improved performance of compression (5%)
and decompression (20%). There was a slight increase in the
compressed size in one of our tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka update-deps-for-1.0.0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3619


commit d15cedcbf7454bc9296d4a1782ea4f2f23aa28d1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-03T14:17:19Z

MINOR: Update dependencies for 1.0.0 release

Notable updates:

1. Gradle 4.1 includes a number of performance and
CLI improvements as well as initial Java 9 support.

2. Scala 2.12.3 has substantial compilation time
improvements.

3. lz4-java 1.4 allows us to remove a workaround in
KafkaLZ4BlockInputStream (not done in this PR).

4. snappy-java 1.1.4 improved performance of compression (5%)
and decompression (20%). There was a slight increase in the
compressed size in one of our tests.

commit f2ccc15ae792adda8ffccb64a8f982916aec235b
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-03T21:06:01Z

Disable noisy findBugs output




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3609: MINOR: Only log about marking replicas as offline ...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3609

MINOR: Only log about marking replicas as offline if there is a replica

I noticed a bunch of these log messages with an empty set for the replicas.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
remove-unnecessary-state-change-log-message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3609


commit f5f368bcb14da17e6f5aa630060e3029dc7e51d6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-08-02T10:39:59Z

MINOR: Only log about marking replicas as offline if there is a replica

I noticed a bunch of these log messages with an empty set for the replicas.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3596: MINOR: Null out all buffer references in RequestCh...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3596

MINOR: Null out all buffer references in RequestChannel.Request

The previous code kept two references to `Buffer` and only nulled
out one of them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka release-buffer-in-request

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3596


commit fe601e8afc7cf33d06ea4325f7f536aee38c9be4
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-29T08:22:48Z

MINOR: Null out all buffer references in RequestChannel.Request

The previous code kept two references to `Buffer` and only nulled
out one of them.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3595: MINOR: Request log should be enabled by debug leve...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3595

MINOR: Request log should be enabled by debug level

At some point, we lost the ability to output request
logging at debug level (which is a little less
verbose than at trace level).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-debug-request-log

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3595


commit 3471e7b235c9b3bcb49cfe7e388eef1e488bf92a
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-29T07:23:42Z

MINOR: Request log should be enabled by debug level

At some point, we lost the ability to output request
logging at debug level (which is a little less
verbose than at trace level).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3579: Bump version to 0.11.0.1-SNAPSHOT

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/3579


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3587: MINOR: Support versions with 3 segments in _kafka_...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3587

MINOR: Support versions with 3 segments in _kafka_jar_versions

The bump from 0.11.1.0-SNAPSHOT to 1.0.0-SNAPSHOT broker a couple
of tests:

* TestVerifiableProducer.test_simple_run
* KafkaVersionTest.test_multi_version

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-_kafka_jar_versions

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3587.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3587


commit 80101e832bd4263f41d249e82faedae6d65ffe4c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-27T13:55:08Z

MINOR: Support versions with 3 segments in _kafka_jar_versions

The bump from 0.11.1.0-SNAPSHOT to 1.0.0-SNAPSHOT broker a couple
of tests:

* TestVerifiableProducer.test_simple_run
* KafkaVersionTest.test_multi_version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3580: MINOR: Next release will be 1.0.0

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3580

MINOR: Next release will be 1.0.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka bump-to-1.0.0-SNAPSHOT

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3580


commit 81b59454c49f5c7f2d1b14d96d2a620b4c91f8c4
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-26T11:46:55Z

MINOR: Bump version to 1.0.0-SNAPSHOT

commit 4d36d9a79717934c040697368eb13d753f01
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-26T11:54:51Z

Update ApiVersion and upgrade.html




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3579: Bump version to 0.11.0.1-SNAPSHOT

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3579

Bump version to 0.11.0.1-SNAPSHOT



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka bump-to-0.11.0.1-SNAPSHOT

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3579


commit d37e2173a7ead123607b4be0111d100d23e441c4
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-26T11:43:34Z

Bump version to 0.11.0.1-SNAPSHOT




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3572: MINOR: Remove unused GroupState.state field

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3572

MINOR: Remove unused GroupState.state field

This field doesn't seem to be used and the value for
`AwaitingSync` seems to be wrong (it seems like it
should have been `2` instead of `5`).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-unused-group-state-field

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3572


commit 7d42953c769a3e03c4811777fa3a2ecba4322a08
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-25T13:19:30Z

MINOR: Remove unused GroupState.state field




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3562: MINOR: Improve log warning to include the log name

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3562

MINOR: Improve log warning to include the log name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka tweak-log-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3562


commit 601da3310c9921d108b4037843bba53ec0cd7966
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:38:43Z

Improve log warning to include the log name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3560: MINOR: Improve log warning to include the log name

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/3560


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3561: MINOR: Give correct instructions for retaining pre...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3561

MINOR: Give correct instructions for retaining previous unclear leader 
election behaviour



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
fix-upgrade-note-for-unclean-leader-election

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3561


commit c09ab368c2840b89ca7b0e1d2e8f20dcef217c7f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:39:50Z

MINOR: Give correct instructions for retaining previous unclear leader 
election behaviour




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3560: MINOR: Improve log warning to include the log name

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3560

MINOR: Improve log warning to include the log name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka tweak-log-and-upgrade-note

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3560


commit 601da3310c9921d108b4037843bba53ec0cd7966
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-21T12:38:43Z

Improve log warning to include the log name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3553: KAFKA-5608: Follow-up to fix potential NPE and cla...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3553

KAFKA-5608: Follow-up to fix potential NPE and clarify method name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka kafka-5608-follow-up

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3553


commit 7f43b0f23402c7018532f92aac438929bc83ca68
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-20T11:09:02Z

KAFKA-5608: Follow-up to fix potential NPE and clarify method name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3552: MINOR: Simplify SensorAccess usage

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3552

MINOR: Simplify SensorAccess usage

I was investigating an exception in this code and found a few
opportunities for making it clearer.

I also added the `out` folder to `.gitignore` as IntelliJ sometimes
uses that as the build folder.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka minor-quota-improvements

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3552


commit 456459490f6aa41d56158038ea609459d414cf27
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-20T10:55:30Z

MINOR: Simplify SensorAccess usage

commit 7b31c240f15459b429645489bd6ad8e0899fbdb5
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-20T10:56:00Z

Add `out` folder to `.gitignore` as IntelliJ can use it as the build folder




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3543: MINOR: Remove flaky assertion in verifyCloseOldest...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3543

MINOR: Remove flaky assertion in 
verifyCloseOldestConnectionWithStagedReceives

This seems to fail a lot in Jenkins although it always passes locally
for me. Removing the assertion to restore Jenkins stability while
we investigate in more detail.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka remove-selector-test-assertion

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3543


commit f2a20063763138d3ae488668cb11e5e4bcc8395c
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-18T07:14:26Z

MINOR: Remove flaky assertion in 
verifyCloseOldestConnectionWithStagedReceives

This seems to fail a lot in Jenkins although it always passes locally
for me. Removing the assertion to restore Jenkins stability while
we investigate in more detail.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3527: MINOR: Mention systemTestLibs in docker system tes...

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/3527


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3527: MINOR: Mention systemTestLibs in docker system tes...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3527

MINOR: Mention systemTestLibs in docker system test instructions

Otherwise NoClassFoundExceptions are thrown for tests that attempt
to start MiniKdc.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka systemTestLibs-in-docker-readme

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3527


commit 613a91334e90078aa872bbf61192dc52545add6e
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-14T14:15:17Z

MINOR: Mention systemTestLibs in docker system test instructions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3503: KAFKA-5570: Join request's timeout should be sligh...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3503

KAFKA-5570: Join request's timeout should be slightly higher than the 
rebalance timeout

- Introduce per request timeouts in NetworkClient
- Use rebalanceTimeout + 5s for join request timeout
- A few minor clean-ups in NetworkClient and ConsumerNetworkClient

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5570-join-request-timeout-higher-than-rebalance-timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3503


commit 1a1060f3a04f9f7e376df9df953ff47d829ca076
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-07T14:00:44Z

Introduce per request timeouts in NetworkClient

commit 6cb76f8e73ffe13870270a93b757caf72ed43a48
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-07T14:07:07Z

Use rebalanceTimeout + 5s for join request timeout

commit 2dec4b149675e6158ec851b06117e606963afe49
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-07T14:07:39Z

A few minor clean-ups in NetworkClient and ConsumerNetworkClient




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3501: MINOR: Improve versioning in docs when a full vers...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3501

MINOR: Improve versioning in docs when a full version is required

Also fix quickstart.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
introduce-full-version-variable-in-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3501


commit 0f4f33310370dce6292fd9a0ccd1f500bbdcf6dd
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-07-07T13:34:36Z

MINOR: Improve versioning in docs when a full version is required

Fix quickstart.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka-site issue #64: MINOR: Add release dates to downloads page

[ijuma]

Github user ijuma commented on the issue:

https://github.com/apache/kafka-site/pull/64
  
Good idea. As you said, the dates seem to differ slightly from: 
https://issues.apache.org/jira/browse/KAFKA/?selectedTab=com.atlassian.jira.jira-projects-plugin:versions-panel

It would be nice to get pre-0.8.2 dates since we're doing this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3464: MINOR: Enable a number of xlint scalac warnings

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3464

MINOR: Enable a number of xlint scalac warnings

Update the code where possible to fix the warnings. The unused
warning introduced in Scala 2.12 is quite handy and provides
a reason to compile with Scala 2.12.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka scala-xlint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3464


commit 206b761d21ea88e876284f54abd373f4d99784ef
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-05-02T13:20:00Z

Enable a number of Xlint scalac warnings

commit 7a19665a4885a24f51c8ff5f2fc8f0055fcd4253
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-29T20:53:04Z

Remove unused imports

commit c152050aed3c7467c1d26c45281330cc25e83797
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-29T20:53:45Z

var -> val

commit c6aa06f66c8729543de7a8fed618450d0fe294a7
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:34:53Z

More consistent usage of side-effect notation

commit 5fb37f93e5e8cbb0d4206f3542fbe4fa86c23c41
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:39:23Z

Remove unused code

commit c6954ffd6709dfa906849107f05f3eb1cb4efee1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:40:29Z

JavaConversions -> JavaConverters

commit 6ecfdccfc1a88a6b6d8edb7571e712d4cb034672
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:40:49Z

Avoid shadowing

commit 9c7401f100a2d98b8b86b9cc4b591ff0c219bd03
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:41:18Z

Remove unnecessary default argument

commit 259fd9f3ae3311f1777970f0c3ef64d052d69e34
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:42:43Z

Avoid unnecessary mutation

commit afbba3538d6366084ad35d529e9e4ef53053a64f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:42:56Z

Remove unnecessary rounding

commit ad106db87e403ec53630d7d82d4c85114f49bd85
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:43:09Z

Add missing string interpolator

commit d690623254f27f0e6a5c64a69b0859f3692554e0
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:43:30Z

Class visibility should be consistent with method returning it

commit 15d63cb1bfe1bc4cc7db7fb8f59fa946b5a014e6
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-30T05:43:46Z

Add deprecated annotation to avoid warning




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3454: MINOR: Compatibility and upgrade tests for 0.11.0....

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3454

MINOR: Compatibility and upgrade tests for 0.11.0.x



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka test-upgrades-from-0.11.0.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3454.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3454


commit 3c077f80d55d44e2178061b2851801e027f90ee0
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-28T14:55:37Z

MINOR: Compatibility and upgrade tests for 0.11.0.x




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3451: MINOR: Implement `toString` in some Validator inst...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3451

MINOR: Implement `toString` in some Validator instances

This is used in the generated config table. Also fix a couple
of typos in the process.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka fix-doc-typos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3451


commit 6764690393e05ba04f5cb593c936022ad25f711b
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-28T10:21:21Z

MINOR: Implement `toString` in some Validator instances

This is used in the generated config table. Also fix a couple
of typos in the process.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3446: MINOR: Improve TransactionIndex.sanityCheck() mess...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3446

MINOR: Improve TransactionIndex.sanityCheck() message



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
improve-transaction-index-exception-sanity-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3446


commit 08a833db60da405a5474d3efb1e721e3bc655052
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-27T22:08:09Z

MINOR: Improve TransactionIndex.sanityCheck() message




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3431: MINOR: Adjust checkstyle suppression paths to work...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3431

MINOR: Adjust checkstyle suppression paths to work on Windows

Use the file name whenever possible and replace / with [/\\]
when it's not.

Also remove unnecessary suppresions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
fix-checkstyle-suppressions-on-windows

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3431


commit 9166fefccfea9e4e41026e09cf0ce03ea8174ca1
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-26T10:43:28Z

MINOR: Adjust checkstyle suppression paths to work on Windows

Use the file name whenever possible and replace / with [/\\]
when it's not.

Also remove unnecessary suppresions.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3422: MINOR: SaslChannelBuilder should be idempotent

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3422

MINOR: SaslChannelBuilder should be idempotent



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka sasl-channel-builder-idempotent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3422.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3422


commit fe342f85f08469d43851449ce5e15f950c6392c3
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-23T13:05:28Z

MINOR: SaslChannelBuilder should be idempotent




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3420: KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3420

KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

Also avoid eager toString call in parameter passed to log.debug.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-5506-offset-fetch-request-to-string-npe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3420.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3420


commit 89343195d62227af42d535a11da97d4b497ed05f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-23T12:18:54Z

KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

commit b3a17f57510215bb22acede4e17430a2465e702f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-23T12:20:42Z

Pass parameter to log.debug without calling toString

This way we don't pay the cost unnecessarily




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3409: MINOR: Switch ZK client logging to INFO

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/3409

MINOR: Switch ZK client logging to INFO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka tweak-log-config

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3409


commit 412a6c58ba3b027863d7f9db20ec25d6f32e559d
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2017-06-22T14:55:31Z

MINOR: Switch ZK client logging to INFO




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---