[GitHub] kafka pull request #3762: KAFKA-5807 - Check Connector.config() and Transfor...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3762 KAFKA-5807 - Check Connector.config() and Transformation.config() returns a valid ConfigDef You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5807 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3762.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3762 commit 484447a755aeb14d62a7844530b7d95e0426eb2f Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-08-30T20:40:09Z KAFKA-5807 check for null when calling into user code. Throw a descriptive exception rather than the eventual NPE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3556: KAFKA-5620
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3556 KAFKA-5620 Expose the ClassCastException as the cause for the SerializationException. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5620 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3556 commit 42af71d407e39c1ef4d13fecab05ed59a9c8354f Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-20T16:48:00Z KAFKA-5620 - Expose the ClassCastException as the cause for the SerializationException. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3517: KAFKA-5579 check for null.
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3517 KAFKA-5579 check for null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5579 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3517.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3517 commit 645b10b1b6ba780d9d4bdbae8c213c26df63c205 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-10T21:45:17Z KAFKA-5579 check for null. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3511: KAFKA-5575 - Add SchemaBuilder.from
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3511 KAFKA-5575 - Add SchemaBuilder.from Added `SchemaBuilder.from` method which allows creating a schema builder prepopulated with the details from the schema. Added tests for structs, maps, arrays, primitives, and logical types. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5575 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3511.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3511 commit 1acb99a6b96b50958956659c770a055c3fd4d133 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-10T05:36:38Z KAFKA-5575 Added `SchemaBuilder.from` method which allows creating a schema builder prepopulated with the details from the schema. Added tests for structs, maps, arrays, primitives, and logical types. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3508: KAFKA-5572 - ConfigDef should be able to escape co...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3508 KAFKA-5572 - ConfigDef should be able to escape comma(s) Allow escaping ',' character with '\,' as an escape sequence. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3508.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3508 commit f22af833e6e9ce7fb6437994e29ae3dc8bfd6611 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-08T16:19:00Z KAFKA-5572 - Allow escaping ',' character with '\,' as an escape sequence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3507: KAFKA-5550
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3507 KAFKA-5550 Changed call to use the overload of ConnectSchema.validate method with the field name passed in. Ensure that field in put call is not null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5550 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3507.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3507 commit 91741942912426e33ad032cdddfeecbc66edd37c Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-01T02:07:10Z KAFKA-5550 Changed call to use the overload of ConnectSchema.validateValue() method with the field name passed in. Ensure that field in put call is not null. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3474: KAFKA-5548 - Extended validation for SchemaBuilder...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/3474 KAFKA-5548 - Extended validation for SchemaBuilder methods. More input validation for SchemaBuilder methods. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-5548 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3474.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3474 commit 7389763d751ffdca963a4120c35cfd3328f1b414 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2017-07-01T01:17:57Z KAFKA-5548 - Added test cases validating input for SchemaBuilder map(), array(), and field() methods. Changed methods to throw a SchemaBuilderException if nulls are passed into the SchemaBuilder map(), array(), and field() methods. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1602: KAFKA-3943 - ConfigDef with Builder pattern
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/1602 KAFKA-3943 - ConfigDef with Builder pattern Added Builder class and define() method with no arguments. Added testcase validating the ConfigDef using the current implementation against the new builder implementation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3943 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1602.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1602 commit de7873c57a382b9b8976e50fea1c2842ad3aa961 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-07-09T23:33:40Z Added Builder class and define() method with no arguments. Added test case validating the ConfigDef using the current implementation against the new builder implementation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1560: KAFKA-3906 - Connect logical types do not support ...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/1560 KAFKA-3906 - Connect logical types do not support nulls. Initial commit with failing unit tests for proposed functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3906 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1560.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1560 commit 5e5d26fcb26988f1f067a91864b74f9da0851871 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-06-27T19:02:59Z Modified method signatures for Date, Time, Timestamp to allow nulls. Added tests for logical types with nulls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #952: KAFKA-3263 - Support for markdown generation.
Github user jcustenborder closed the pull request at: https://github.com/apache/kafka/pull/952 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3407 - ErrorLoggingCallback trims helpfu...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/1079 KAFKA-3407 - ErrorLoggingCallback trims helpful diagnostic information. This should help when diagnosing issues with the console producer. This allows the logger to use `exception` rather than `exception.getMessage()`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3407 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1079.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1079 commit fe80be8e3837dd6f03f69947e3ac8f7a8c4fe14b Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-03-16T02:21:01Z KAFKA-3407 - Changed to use exception instead of exception.getMessage(). This will return callstack and inner exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3347 - Configure java to prefer ipv4
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/1026 KAFKA-3347 - Configure java to prefer ipv4 Modified KAFKA_JVM_PERFORMANCE_OPTS to include -Djava.net.preferIPv4Stack=true. Added an additional space at the end of the string to be consistent with the other variables. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3347 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1026.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1026 commit e717faa1e1e82ed6fe2146db4663a3f4ac528c3b Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-03-07T23:14:33Z KAFKA-3347 - Modified KAFKA_JVM_PERFORMANCE_OPTS to include -Djava.net.preferIPv4Stack=true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3263 - Support for markdown generation.
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/952 KAFKA-3263 - Support for markdown generation. Added support to generate markdown from ConfigDef entries. Added test toMarkdown() to ConfigDefTest. Added toMarkdown() to ConfigDef. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3263 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/952.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #952 commit f2f91fadfe5a4fb3647b0d521cae967129651967 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-02-23T06:51:54Z KAFKA-3263 - Added support to generate markdown from ConfigDef entries. Added test toMarkdown() to ConfigDefTest. Added toMarkdown() to ConfigDef. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3260 - Added SourceTask.commitRecord
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/950 KAFKA-3260 - Added SourceTask.commitRecord Added commitRecord(SourceRecord record) to SourceTask. This method is called during the callback from producer.send() when the message has been sent successfully. Added commitTaskRecord(SourceRecord record) to WorkerSourceTask to handle calling commitRecord on the SourceTask. Updated tests for calls to commitRecord. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3260 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/950.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #950 commit f4e1826f659af99e39189d45af214fd9f030b77b Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-02-22T23:22:02Z KAFKA-3260 - Added commitRecord(SourceRecord record) to SourceTask. This method during the callback from producer.send() when the message has been sent successfully. Added commitTaskRecord(SourceRecord record) to WorkerSourceTask to handle calling commitRecord on the SourceTask. Updated tests for calls to commitRecord. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3237 - Remove test cases testInvalidDefa...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/936 KAFKA-3237 - Remove test cases testInvalidDefaultRange() and testInva⦠Remove test cases testInvalidDefaultRange() and testInvalidDefaultString(). Defaults if not overridden will get checked on parse. Testing the defaults is unnecessary. This allows you to set that a parameter is required while setting a validator for that parameter. Added a test case testNullDefaultWithValidator that allows a null default with a validator for certain strings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3237 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/936.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #936 commit 249e4d781235311742d270033a13b92bea582745 Author: Jeremy Custenborder <jcustenbor...@gmail.com> Date: 2016-02-19T06:04:46Z KAFKA-3237 - Remove test cases testInvalidDefaultRange() and testInvalidDefaultString(). Defaults if not overridden will get checked on parse. Testing the defaults is unnecessary. This allows you to set that a parameter is required while setting a validator for that parameter. Added a test case testNullDefaultWithValidator that allows a null default with a validator for certain strings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3225: Method commit() of class SourceTas...
GitHub user jcustenborder opened a pull request: https://github.com/apache/kafka/pull/909 KAFKA-3225: Method commit() of class SourceTask never invoked 1. Added a test case to prove commit() on SourceTask was not being called. 2. Added commitSourceTask() which logs potential exceptions. 3. Added after call to finishSuccessfulFlush(). You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcustenborder/kafka KAFKA-3225 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/909.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #909 commit 8bd329d3f8edfb0ad817da2cc9c205ef4f647c94 Author: Jeremy Custenborder <jer...@scarcemedia.com> Date: 2016-02-12T21:46:30Z KAFKA-3225 Added test case for missing commit call on WorkerSourceTask. Added commitSourceTask() to follow finishSuccessfulFlush() which calls SourceTask.commit() and log exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
