[gradle build] The wrapper should be in the repository
Hi everyone, When following the setup page [ https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup] running : ./gradlew eclipse I hit an error : Could not find or load main class org.gradle.wrapper.GradleWrapperMain When looking at the gradle documentation [ https://docs.gradle.org/current/userguide/gradle_wrapper.html] the explanation is simple : gradle/wrapper/ *should* be submitted to your version control system. Thus, 2 solutions: - adding the gradle/wrapper/* files and precise the gradle version in build.gradle - remove the wrapper, since it is of no use, because one has to run for instance gradle wrapper --gradle-version 2.0 , which means he already has gradle. The first solution seems to be the one to take. I can do the modification and push a pull request, but I still want to be sure to check with you before doing so. Regards.
Re: setting up kafka github
Hello, I'm new to kafka too, but I think this page can help you : https://help.github.com/articles/using-pull-requests/ It describes exactly the process to follow. Regards. 2015-11-14 11:49 GMT+01:00 mojhaha kiklasds : > Hello, > > I'm new to github usage but I want to contribute to kafka. I am trying to > setup my github repo based on the instructions mentioned here: > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes#ContributingCodeChanges-PullRequest > > I have one doubt though. Which repo shall I configure as the remote - > apache-kafka or my fork ? > > If I configure apache-kafka as remote, will I be able to submit pull > requests? > > If I sync my committed changes to my fork (hosted on github), will I issue > pull requests from this fork to apache-kafka ? > > Thanks, > Mojhaha >
Re: [gradle build] The wrapper should be in the repository
Thank you :) 2015-11-17 7:26 GMT+01:00 Ewen Cheslack-Postava : > Hi, > > Those instructions simply fell out of date -- you can see in the README in > the repository that the first step after checkout is to bootstrap the > gradle wrapper. The wrapper is not included due to licensing issues when > creating packages from the repository. I've updated the wiki to explain how > to generate the wrapper before building (which is still useful since you > can generate the wrapper with different versions of gradle, but it will > build with the version specified by the project). > > -Ewen > > On Fri, Nov 13, 2015 at 3:46 PM, jeanbaptiste lespiau < > jeanbaptiste.lesp...@gmail.com> wrote: > > > Hi everyone, > > > > When following the setup page [ > > https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup] > > running : > > > > ./gradlew eclipse > > > > I hit an error : > > > > Could not find or load main class org.gradle.wrapper.GradleWrapperMain > > > > When looking at the gradle documentation [ > > https://docs.gradle.org/current/userguide/gradle_wrapper.html] > > > > the explanation is simple : gradle/wrapper/ *should* be submitted to your > > version control system. > > > > Thus, 2 solutions: > > - adding the gradle/wrapper/* files and precise the gradle version in > > build.gradle > > - remove the wrapper, since it is of no use, because one has to run for > > instance gradle wrapper --gradle-version 2.0 , which means he already has > > gradle. > > > > The first solution seems to be the one to take. > > > > I can do the modification and push a pull request, but I still want to be > > sure to check with you before doing so. > > > > Regards. > > > > > > -- > Thanks, > Ewen >
