[GitHub] kafka pull request #2944: KAFKA-3940: Replaced File.mkdir/mkdirs/delete by t...
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/2944 ---
[GitHub] kafka pull request #4231: MINOR: Small cleanups/refactoring in kafka.control...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4231 MINOR: Small cleanups/refactoring in kafka.controller - Updated logging to use string templates - Minor refactors - Fixed a few typos ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka controller_refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4231 commit 427c6b1d5e0829116eddbd8c44941939e5428033 Author: Mickael Maison Date: 2017-11-18T18:28:49Z MINOR: Small cleanups/refactoring in kafka.controller Updated logging to use string templates Fixed a few typos ---
[GitHub] kafka pull request #4217: MINOR: Updated KafkaZkClient.pathExists() to use E...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4217 MINOR: Updated KafkaZkClient.pathExists() to use ExistsRequest rather than using GetDataRequest You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka pathExists Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4217 commit 34b8e89d62d777af5dfbb75301c114a574a8d945 Author: Mickael Maison Date: 2017-11-11T14:42:51Z MINOR: Updated KafkaZkClient.pathExists() to use ExistsRequest rather than using GetDataRequest ---
[GitHub] kafka pull request #4196: MINOR: KafkaZkClient refactor. Use match instead o...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4196 MINOR: KafkaZkClient refactor. Use match instead of if/else chains Follow up from https://github.com/apache/kafka/pull/4111 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka zkclient_refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4196 commit a570d29587eae543c3dd3069965c6fe73fc9f347 Author: Mickael Maison Date: 2017-11-08T20:33:07Z MINOR: Refactored KafkaZkClient. Use match instead of if/else chains commit c81f3c567324c90ae14b1ac23c8cec5169d42f4c Author: Mickael Maison Date: 2017-11-08T20:56:59Z Refactor exception cases ---
[GitHub] kafka pull request #4111: KAFKA-6073: Use ZookeeperClient in KafkaApis
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4111 KAFKA-6073: Use ZookeeperClient in KafkaApis I kept zkUtils for the call to AdminUtils.createTopic(). AdminUtils can be done in another PR You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-6073 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4111.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4111 commit fbced9bd1a7e090ec9572aa28592546d85ef34f8 Author: Mickael Maison Date: 2017-10-21T18:37:48Z KAFKA-6073: Use ZookeeperClient in KafkaApis ---
[GitHub] kafka pull request #4058: MINOR: Fixed format string
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/4058 MINOR: Fixed format string Use Scala string templates instead of format You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka minor_AFT_logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4058.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4058 commit 5ffd9bf721e8f8e4f3081df11c1493278d1f37cc Author: Mickael Maison Date: 2017-10-11T17:09:40Z MINOR: Fixed format string Use Scala string templates instead of format ---
[GitHub] kafka pull request #3906: KAFKA-5735: KIP-190: Handle client-ids consistentl...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3906 KAFKA-5735: KIP-190: Handle client-ids consistently Developed with @edoardocomar You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3906.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3906 commit 274e52db0f800785d485c01280b03632eac8c2b6 Author: Mickael Maison Date: 2017-09-16T13:00:05Z KAFKA-5735: KIP-190: Handle client-ids consistently Developed with @edoardocomar ---
[GitHub] kafka pull request #3785: KAFKA-5830: kafka-configs.sh should allow deletion...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3785 KAFKA-5830: kafka-configs.sh should allow deletion of all configs for⦠⦠an entity Added a --delete-all-configs flag to delete all configurations for a given entity You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5830 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3785.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3785 commit bba8715f97bdd152c30f9786b375fe52583995f6 Author: Mickael Maison Date: 2017-09-03T17:33:20Z KAFKA-5830: kafka-configs.sh should allow deletion of all configs for an entity Added a --delete-all-configs flag to delete all configurations for a given entity ---
[GitHub] kafka pull request #3780: MINOR: Updated KafkaConsumer.commitSync() javadoc
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3780 MINOR: Updated KafkaConsumer.commitSync() javadoc Throws IllegalArgumentException is the offset is negative You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka commitSync_javadoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3780.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3780 commit c344d31306179b6c75b647ab4b7b602e8cb31246 Author: Mickael Maison Date: 2017-09-03T17:40:11Z MINOR: Updated KafkaConsumer.commitSync() javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3684: KIP-81: KAFKA-4133: Bound memory usage of the Cons...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3684 KIP-81: KAFKA-4133: Bound memory usage of the Consumer This is in-progress but there should be enough to start the reviews. Although the KIP doesn't mention metrics, I think we should expose the memory pool usage metrics like in KIP-72. Also this need more tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4133 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3684.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3684 commit c5bebf8df80e90f920a82a7d7a1ae8fe31ca4d84 Author: Mickael Maison Date: 2017-07-26T20:27:37Z KIP-81: KAFKA-4133: Bound Consumer memory usage The Consumer can now use a MemoryPool to bound its memory usage commit c9a110b2310fc2872ca8e63c150249733bf496b0 Author: Mickael Maison Date: 2017-08-17T10:03:48Z Minor fixes following Vahid's review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3670: MINOR: fixed StickyAssignor javadoc
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3670 MINOR: fixed StickyAssignor javadoc StickyAssignor javadoc has a bunch of formatting issues which make it pretty hard to read: http://kafka.apache.org/0110/javadoc/org/apache/kafka/clients/consumer/StickyAssignor.html cc @vahidhashemian You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka sticky_assignor_javadoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3670.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3670 commit 204f0ba542d026149ed7c48f2fdb16d9dbcb510c Author: Mickael Maison Date: 2017-08-15T10:25:02Z MINOR: fixed StickyAssignor javadoc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3635: KAFKA-3417: Quote client-id and wrap reporter call...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3635 KAFKA-3417: Quote client-id and wrap reporter calls in try/catch blocks You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3417 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3635.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3635 commit ec36fa8052ea60411c77ed82c4b3d7b83fb1f4d3 Author: Mickael Maison Date: 2017-08-07T11:51:49Z KAFKA-3417: Quote client-id and wrap reporter calls in try/catch blocks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3452: KAFKA-5483: Shutdown of scheduler should come afte...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3452 KAFKA-5483: Shutdown of scheduler should come after LogManager Close the scheduler after all components using it have been shutdown @hachikuji Can you have a look ? You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3452.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3452 commit 3481adaf02426e55639f6395c5ed9d49128a7d3a Author: Mickael Maison Date: 2017-06-27T16:04:45Z KAFKA-5483: Shutdown of scheduler should come after LogManager Close the scheduler after all components using it have been shutdown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3296: KAFKA-3123: Follower Broker cannot start if offset...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3296 KAFKA-3123: Follower Broker cannot start if offsets are already out o⦠â¦f range From https://github.com/apache/kafka/pull/1716#discussion_r112000498, ensure the cleaner is restarted if Log.truncateTo throws You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3123 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3296 commit e12690320d68c7686ecf9ceebe53a4498b8a5f0d Author: Mickael Maison Date: 2017-06-10T18:49:43Z KAFKA-3123: Follower Broker cannot start if offsets are already out of range --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3295: KAFKA-5418: ZkUtils.getAllPartitions() may fail if...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3295 KAFKA-5418: ZkUtils.getAllPartitions() may fail if a topic is marked for deletion Skip topics that don't have any partitions in zkUtils.getAllPartitions() You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5418 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3295.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3295 commit 0aeca093c2acf47b8d4fa01b68eaef79f625e091 Author: Mickael Maison Date: 2017-06-10T20:10:40Z KAFKA-5418: ZkUtils.getAllPartitions() may fail if a topic is marked for deletion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3105: KAFKA-5294: PlainSaslServerFactory should allow a ...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3105 KAFKA-5294: PlainSaslServerFactory should allow a null Map in getMech⦠â¦anismNames If props is null, use POLICY_NOPLAINTEXT default value: false As far as I can tell, none of the other classes implementing SaslServerFactory use the properties Map You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5294 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3105 commit 432c48c3f49ccc3090646671bdba82a2ef05b839 Author: Mickael Maison Date: 2017-05-19T19:38:13Z KAFKA-5294: PlainSaslServerFactory should allow a null Map in getMechanismNames If props is null, use POLICY_NOPLAINTEXT default value: false --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3036: KAFKA-3356: Remove ConsumerOffsetChecker
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3036 KAFKA-3356: Remove ConsumerOffsetChecker You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3356 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3036.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3036 commit c1ec0258e0d1cc76672eece84f2ed0a5aca2d67a Author: Mickael Maison Date: 2017-05-12T17:45:03Z KAFKA-3356: Remove ConsumerOffsetChecker, deprecated in 0.9, in 0.11 Deleted both the script and tool --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3034: MINOR: Fixed testBrokerTopicMetricsBytesInOut fail...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3034 MINOR: Fixed testBrokerTopicMetricsBytesInOut failures We've had to tweak the other tests to make them pass. `testBrokerTopicMetricsUnregisteredAfterDeletingTopic` seemed completely broken, as it's was creating a topic but producing/consuming to another one. With @mpburg You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka Fix-testBrokerTopicMetricsBytesInOut Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3034.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3034 commit de6ff4da54e71c038d66caabcab365530f8968bb Author: Mickael Maison Date: 2017-05-12T14:39:06Z MINOR: Fixed testBrokerTopicMetricsBytesInOut failures With @mpburg --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3003: KAFKA-5194: KIP-153: Include only client traffic i...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/3003 KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec me⦠â¦tric Also added 2 new metrics to account for incoming/outgoing traffic due to internal replication - ReplicationBytesInPerSec - ReplicationBytesOutPerSec We had a look at creating an integration test to verify the Bytes/Replication In/Out metrics but had issues. When running using IntegrationTestHarness, all the brokers were using the same Yammer Metrics registry and metrics name collided. Also although we only update the global value for the 2 new metrics, we can see an inner node for each topic (that stays 0). eg: kafka.server:type=BrokerTopicMetrics,name=ReplicationBytesOutPerSec,topic=testtopic It looks like something forced by BrokerTopicMetrics. If there's no way to remove them, then we might want to update them accordingly to give them meaningful values You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-5194 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3003.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3003 commit ce34c59e80d3ecd6d0473b2867b839da5edd1bb6 Author: Mickael Maison Date: 2017-05-08T16:44:51Z KAFKA-5194: KIP-153: Include only client traffic in BytesOutPerSec metric Also added 2 new metrics to account for incoming/outgoing traffic due to internal replication - ReplicationBytesInPerSec - ReplicationBytesOutPerSec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2944: KAFKA-3940: Replaced File.mkdir/mkdirs/delete by t...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2944 KAFKA-3940: Replaced File.mkdir/mkdirs/delete by their Files equivalent You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3940 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2944 commit 189ead578f8cf99f555aa1de8572d771e7c7b15e Author: Mickael Maison Date: 2017-04-17T17:13:13Z KAFKA-3940: Replaced File.mkdir/mkdirs/delete by their Files equivalent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2878: KAFKA-3070: SASL unit tests dont work with IBM JDK
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2878 KAFKA-3070: SASL unit tests dont work with IBM JDK Use IBM Kerberos module for SASL tests if running on IBM JDK Developed with @edoardocomar Based on https://github.com/apache/kafka/pull/738 by @rajinisivaram You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3070 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2878.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2878 commit d64b569cfc652f0e15450f47999c9c07e97f2ab7 Author: Mickael Maison Date: 2017-04-19T17:56:54Z KAFKA-3070: SASL unit tests dont work with IBM JDK Use IBM Kerberos module for SASL tests if running on IBM JDK Developed with @edoardocomar Based on https://github.com/apache/kafka/pull/738 by @rajinisivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2326: MINOR: Various small scala cleanups
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2326 MINOR: Various small scala cleanups - Removed unnecessary semicolons You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka minor-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2326 commit 849f9b91f896786040f32538eae19ede80f5b0fa Author: Mickael Maison Date: 2017-01-06T18:10:44Z MINOR: Various small scala cleanups - Removed unnecessary semicolons --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2011: KAFKA-4291: TopicCommand --describe shows topics m...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/2011 KAFKA-4291: TopicCommand --describe shows topics marked for deletion ⦠â¦as under-replicated and unavailable TopicCommand --describe now shows if a topic is marked for deletion. Developed with @edoardocomar You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4291 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2011.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2011 commit a849efdad6cd1611580e17e76ccac61c9b503a31 Author: Mickael Maison Date: 2016-10-11T15:21:15Z KAFKA-4291: TopicCommand --describe shows topics marked for deletion as under-replicated and unavailable TopicCommand --describe now shows if a topic is marked for deletion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...
GitHub user mimaison reopened a pull request: https://github.com/apache/kafka/pull/1827 KAFKA-4081: Consumer API consumer new interface commitSync does not v⦠â¦erify the validity of offset Commit throws InvalidOffsetException if the offset is negative You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4081 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1827 commit 7ec08416868180422dd6df8e921c9f6027218bfa Author: Mickael Maison Date: 2016-09-19T17:22:34Z KAFKA-4081: Consumer API consumer new interface commitSync does not verify the validity of offset Commit will now fail with an IllegalArgumentException when trying to commit an offset that is either negative or larger than the consumer's current position commit e1c1674b8f661e4063e4d5bc04a86ad069a3f317 Author: Edoardo Comar Date: 2016-09-21T16:14:36Z KAFKA-4081: Consumer API consumer new interface commitSync does not verify the validity of offset Commit will now fail with an IllegalArgumentException when trying to commit an offset that is either negative or larger than the consumer's current position --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/1827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1827: KAFKA-4081: Consumer API consumer new interface co...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1827 KAFKA-4081: Consumer API consumer new interface commitSync does not v⦠â¦erify the validity of offset Commit throws InvalidOffsetException if the offset is negative You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4081 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1827.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1827 commit 334f82f60416c511665519362ce23d4ab22cc5fd Author: Mickael Maison Date: 2016-09-01T16:41:16Z KAFKA-4081: Consumer API consumer new interface commitSync does not verify the validity of offset Commit throws InvalidOffsetException if the offset is negative --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1754: KAFKA-4057: Allow to specify the request version a...
Github user mimaison closed the pull request at: https://github.com/apache/kafka/pull/1754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1759: KAFKA-4056: Kafka logs values of sensitive configs...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1759 KAFKA-4056: Kafka logs values of sensitive configs like passwords In case of unknown configs, only list the name without the value You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1759.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1759 commit bd3c0a9ceb2661cd027319bae17fbd3c6df7d54d Author: Mickael Maison Date: 2016-08-18T15:01:26Z KAFKA-4056: Kafka logs values of sensitive configs like passwords In case of unknown configs, only list the name without the value --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1754: KAFKA-4057: Allow to specify the request version a...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1754 KAFKA-4057: Allow to specify the request version and replica ID in ka⦠â¦fka.javaapi.FetchRequest - Added new arguments for versionId and replicaId in the constructor instead of using hardcoded values You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-4057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1754.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1680: KAFKA-3946: Protocol guide should say that Produce...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1680 KAFKA-3946: Protocol guide should say that Produce request acks can o⦠â¦nly be 0, 1, or -1 Rephrased the documentation string for the Produce request Updated the acks configuration docs to state that -1, 0, and 1 are the only allowed values You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3946 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1680 commit afa886cf387b3b184f127c2b9b62e480e25d6730 Author: Mickael Maison Date: 2016-07-29T10:13:34Z KAFKA-3946: Protocol guide should say that Produce request acks can only be 0, 1, or -1 Rephrased the documentation string for the Produce request Updated the acks configuration docs to state that -1, 0, and 1 are the only allowed values --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1675: MINOR: Fixed a few warnings in clients
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1675 MINOR: Fixed a few warnings in clients - Removed an unnecessary annotation - Parameterized a couple of raw types You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka warnings Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1675.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1675 commit a02364364d3159dbb6ddc5167bdad22bebedb64e Author: Mickael Maison Date: 2016-07-28T16:46:50Z MINOR: Fixed a few warnings in clients --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: MINOR: Fix tracing in KafkaApis.handle()
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1435 MINOR: Fix tracing in KafkaApis.handle() requestObj() returns null for the o.a.k.c.requests objects so use header() for these. Once all the requests will have been replaced by o.a.k.c.requests objects, we should be able to clean that up, but in the meantime it's useful to trace both. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka kafkaapis_trace Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1435.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1435 commit 1fb627c8a5f57b4c8762f351564623034daf2158 Author: Mickael Maison Date: 2016-05-26T17:36:55Z MINOR: Fix tracing in KafkaApis.handle() requestObj returns null for the new Java request objects so use header for these. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3732: Add an auto accept option to kafka...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1406 KAFKA-3732: Add an auto accept option to kafka-acl Added a new argument to AclCommand: --yes. When set, automatically answer yes to prompts You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3732 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1406.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1406 commit 4117f205ded6a2569239fa1d3fa1a1a26fe574e8 Author: Mickael Maison Date: 2016-05-19T17:37:32Z KAFKA-3732: Add an auto accept option to kafka-acl Added a new argument to AclCommand: --yes. When set, automatically answer yes to prompts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3587: LogCleaner fails due to incorrect ...
GitHub user mimaison opened a pull request: https://github.com/apache/kafka/pull/1332 KAFKA-3587: LogCleaner fails due to incorrect offset map computation ⦠Removed the over pessimistic require and instead attempt to fill the dedup buffer. Use the (only) map until full; this may allow to process all dirty segment (optimism) or may happen in the middle of a dirt segment. In either case, do compaction using the map loaded that way. This patch was developed with @edoardocomar You can merge this pull request into a Git repository by running: $ git pull https://github.com/mimaison/kafka KAFKA-3587 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1332.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1332 commit e4f4e5ed75a845f0c4cc2b6745dc213f71affe6d Author: Mickael Maison Date: 2016-05-06T15:08:03Z KAFKA-3587: LogCleaner fails due to incorrect offset map computation on a replica Removed the over pessimistic require and instead attempt to fill the dedup buffer. Use the (only) map until full; this may allow to process all dirty segment (optimism) or may happen in the middle of a dirt segment. In either case, do compaction using the map loaded that way. This patch was developed with @edoardocomar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
