Re: [VOTE] KIP-474: To deprecate WindowStore#put(key, value)
Hello everyone, Thanks to who have voted! The final count is :- binding +1: 3 (Matthias, Guozhang, Bill) non-binding +1: 3 (Boyang, Dongjin, John) I'm closing this vote thread. Thanks & Regards Omkar Mestry On Fri, Jun 21, 2019 at 4:36 AM Bill Bejeck wrote: > Sorry for being late to the party. > > I've reviewed the KIP and it's a great step in the right direction. > > +1 (binding) > > Thanks, > Bill > > On Thu, Jun 20, 2019 at 11:42 AM John Roesler wrote: > > > Not that it changes the outcome, but I'm also +1 (nonbinding). > > > > Been wanting to do this for a while, thanks Omkar! > > > > Now, if we can just get one more binding vote... > > > > -John > > > > On Sun, Jun 9, 2019 at 1:04 AM omkar mestry > wrote: > > > > > > Hi, > > > > > > Ok the voting thread is still open. > > > > > > Thanks Regards > > > Omkar Mestry > > > > > > On Sun, 9 Jun 2019 at 11:33 AM, Matthias J. Sax > > > > wrote: > > > > > > > Omkar, > > > > > > > > a KIP is accepted if there are 3 binding votes for it. So far, there > > are > > > > only 2. Hence, the KIP is not accepted yet. The vote stays open. > > > > > > > > Just wait a little longer, until you get one more binding vote. > > > > > > > > > > > > -Matthias > > > > > > > > On 6/7/19 3:33 AM, omkar mestry wrote: > > > > > Thanks to everyone who have voted! I'm closing this vote thread > with > > a > > > > > final count: > > > > > > > > > > binding +1: 2 (Matthias, Guozhang) > > > > > > > > > > non-binding +1: 2 (Boyang, Dongjin) > > > > > > > > > > Thanks & Regards > > > > > Omkar Mestry > > > > > > > > > > On Tue, Jun 4, 2019 at 3:05 AM Guozhang Wang > > wrote: > > > > > > > > > >> +1 (binding). > > > > >> > > > > >> On Sat, Jun 1, 2019 at 3:19 PM Matthias J. Sax < > > matth...@confluent.io> > > > > >> wrote: > > > > >> > > > > >>> +1 (binding) > > > > >>> > > > > >>> On 5/31/19 10:58 PM, Dongjin Lee wrote: > > > > >>>> +1 (non-binding). > > > > >>>> > > > > >>>> Thanks, > > > > >>>> Dongjin > > > > >>>> > > > > >>>> < > > > > >>> > > > > >> > > > > > > > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=icon > > > > >>>> > > > > >>>> Virus-free. > > > > >>>> www.avast.com > > > > >>>> < > > > > >>> > > > > >> > > > > > > > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=link > > > > >>>> > > > > >>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > > >>>> > > > > >>>> On Sat, Jun 1, 2019 at 2:45 PM Boyang Chen > > > > > >> wrote: > > > > >>>> > > > > >>>>> Thanks omkar for taking the initiative, +1 (non-binding). > > > > >>>>> > > > > >>>>> > > > > >>>>> From: omkar mestry > > > > >>>>> Sent: Saturday, June 1, 2019 1:40 PM > > > > >>>>> To: dev@kafka.apache.org > > > > >>>>> Subject: [VOTE] KIP-474: To deprecate WindowStore#put(key, > value) > > > > >>>>> > > > > >>>>> Hi all, > > > > >>>>> > > > > >>>>> Since we seem to have an agreement in the discussion I would > > like to > > > > >>>>> start the vote on KIP-474. > > > > >>>>> > > > > >>>>> KIP 474 :- > > > > >>>>> > > > > >>> > > > > >> > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 > > > > >>>>> > > > > >>>>> Thanks & Regards > > > > >>>>> Omkar Mestry > > > > >>>>> > > > > >>>> > > > > >>>> > > > > >>> > > > > >>> > > > > >> > > > > >> -- > > > > >> -- Guozhang > > > > >> > > > > > > > > > > > > > > > >
Re: [VOTE] KIP-474: To deprecate WindowStore#put(key, value)
Hi, Ok the voting thread is still open. Thanks Regards Omkar Mestry On Sun, 9 Jun 2019 at 11:33 AM, Matthias J. Sax wrote: > Omkar, > > a KIP is accepted if there are 3 binding votes for it. So far, there are > only 2. Hence, the KIP is not accepted yet. The vote stays open. > > Just wait a little longer, until you get one more binding vote. > > > -Matthias > > On 6/7/19 3:33 AM, omkar mestry wrote: > > Thanks to everyone who have voted! I'm closing this vote thread with a > > final count: > > > > binding +1: 2 (Matthias, Guozhang) > > > > non-binding +1: 2 (Boyang, Dongjin) > > > > Thanks & Regards > > Omkar Mestry > > > > On Tue, Jun 4, 2019 at 3:05 AM Guozhang Wang wrote: > > > >> +1 (binding). > >> > >> On Sat, Jun 1, 2019 at 3:19 PM Matthias J. Sax > >> wrote: > >> > >>> +1 (binding) > >>> > >>> On 5/31/19 10:58 PM, Dongjin Lee wrote: > >>>> +1 (non-binding). > >>>> > >>>> Thanks, > >>>> Dongjin > >>>> > >>>> < > >>> > >> > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=icon > >>>> > >>>> Virus-free. > >>>> www.avast.com > >>>> < > >>> > >> > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=link > >>>> > >>>> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > >>>> > >>>> On Sat, Jun 1, 2019 at 2:45 PM Boyang Chen > >> wrote: > >>>> > >>>>> Thanks omkar for taking the initiative, +1 (non-binding). > >>>>> > >>>>> > >>>>> From: omkar mestry > >>>>> Sent: Saturday, June 1, 2019 1:40 PM > >>>>> To: dev@kafka.apache.org > >>>>> Subject: [VOTE] KIP-474: To deprecate WindowStore#put(key, value) > >>>>> > >>>>> Hi all, > >>>>> > >>>>> Since we seem to have an agreement in the discussion I would like to > >>>>> start the vote on KIP-474. > >>>>> > >>>>> KIP 474 :- > >>>>> > >>> > >> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 > >>>>> > >>>>> Thanks & Regards > >>>>> Omkar Mestry > >>>>> > >>>> > >>>> > >>> > >>> > >> > >> -- > >> -- Guozhang > >> > > > >
Re: [VOTE] KIP-474: To deprecate WindowStore#put(key, value)
Thanks to everyone who have voted! I'm closing this vote thread with a final count: binding +1: 2 (Matthias, Guozhang) non-binding +1: 2 (Boyang, Dongjin) Thanks & Regards Omkar Mestry On Tue, Jun 4, 2019 at 3:05 AM Guozhang Wang wrote: > +1 (binding). > > On Sat, Jun 1, 2019 at 3:19 PM Matthias J. Sax > wrote: > > > +1 (binding) > > > > On 5/31/19 10:58 PM, Dongjin Lee wrote: > > > +1 (non-binding). > > > > > > Thanks, > > > Dongjin > > > > > > < > > > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=icon > > > > > > Virus-free. > > > www.avast.com > > > < > > > https://www.avast.com/sig-email?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=link > > > > > > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2> > > > > > > On Sat, Jun 1, 2019 at 2:45 PM Boyang Chen > wrote: > > > > > >> Thanks omkar for taking the initiative, +1 (non-binding). > > >> > > >> > > >> From: omkar mestry > > >> Sent: Saturday, June 1, 2019 1:40 PM > > >> To: dev@kafka.apache.org > > >> Subject: [VOTE] KIP-474: To deprecate WindowStore#put(key, value) > > >> > > >> Hi all, > > >> > > >> Since we seem to have an agreement in the discussion I would like to > > >> start the vote on KIP-474. > > >> > > >> KIP 474 :- > > >> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 > > >> > > >> Thanks & Regards > > >> Omkar Mestry > > >> > > > > > > > > > > > > -- > -- Guozhang >
[VOTE] KIP-474: To deprecate WindowStore#put(key, value)
Hi all, Since we seem to have an agreement in the discussion I would like to start the vote on KIP-474. KIP 474 :- https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 Thanks & Regards Omkar Mestry
Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)
Hi Dongjin, I have updated the KIP please have a look and provide feedback on it. KIP :- https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 Thanks & Regards Omkar Mestry On Mon, May 27, 2019 at 6:25 PM Dongjin Lee wrote: > Hi Omkar, > > Thanks for the KIP. However, discussion thread should include a link to the > KIP document. Since you omitted it, here is the link. > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 > > As far as I understand, the point of the KIP is the current API can result > in inconsistency to should be deprecated and finally, removed. Right? Here > are some comments on the KIP. > > *1. Minor corrections* > > Since the KIP proposes deprecation of an API, not actually removing it, it > would be better to correct the following sentences: > > - "Therefore by removing the method put(key, value), we can prevent > inconsistency." → "Therefore by deprecating (and finally removing) the > method put(key, value), we can prevent inconsistency." > - "Also, there are tests which are needed to be updated after removal of > the specified method." → "Also, there are tests which are needed to be > updated after deprecation of the specified method." > > *2. About 'Motivation' section* > > I think the motivation section can be more clear by referring to the risk > of the current API. How do you think? > > "... Therefore by ..." > > → "... This constraint makes WindowStore error prone. Therefore by ..." > > *3. About 'Rejected Alternatives' section* > > This sections should state why these alternatives were rejected. How about > this? > > "Since this API can be called by the user[^1][^2], updating the method can > break the code; By this reason, this approach is not feasible." > > Regards, > Dongjin > > [^1]: > > https://kafka.apache.org/22/javadoc/org/apache/kafka/streams/state/Stores.html > [^2]: > > https://kafka.apache.org/22/javadoc/org/apache/kafka/streams/state/WindowStore.html > > On Sun, May 26, 2019 at 3:18 PM omkar mestry > wrote: > > > We propose to deprecate the WindowStore#put(key, value), as it does not > > have a timestamp as a parameter. The window store requires a timestamp to > > map the key to a window frame. This method uses the current record > > timestamp(as specified in the description of the method). There is a > method > > present with a timestamp as a parameter which can be used instead. > > > > > -- > *Dongjin Lee* > > *A hitchhiker in the mathematical world.* > *github: <http://goog_969573159/>github.com/dongjinleekr > <https://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr > <https://kr.linkedin.com/in/dongjinleekr>speakerdeck: > speakerdeck.com/dongjin > <https://speakerdeck.com/dongjin>* >
[DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)
We propose to deprecate the WindowStore#put(key, value), as it does not have a timestamp as a parameter. The window store requires a timestamp to map the key to a window frame. This method uses the current record timestamp(as specified in the description of the method). There is a method present with a timestamp as a parameter which can be used instead.
Provide permission for creating KIP
Hello, Please provide access to create KIP on confluence. My user id is omanges. Thanks & Regards Omkar Mestry
Unable to build project in intelliji
Hi, I am unable to build project in intelliji with the following exception :- Could not find method annotationProcessor() for arguments [org.openjdk.jmh:jmh-generator-annprocess:1.21] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler. Branch which I am looking is trunk. Please help to solve this issue. Thanks & Regards Omkar Mestry
To add in contributors list
Hello, My name is Omkar Mahadev Mestry and I am a java developer, currently working on java and kafka streams. I have been working with kafka and would like to contribute to kafka community. Please add me in the contributors list so that I can start working with JIRA. I have attached my resume as well. PFA Thanks & Regards Omkar Mestry
