[GitHub] kafka pull request #4307: KAFKA-6307 mBeanName should be removed before retu...

2017-12-08 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4307

KAFKA-6307 mBeanName should be removed before returning from 
JmxReporter#removeAttribute()


### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4307


commit 82d3f60eaf0548b478c7d873c5fbf4b930a11473
Author: tedyu 
Date:   2017-12-08T19:08:30Z

KAFKA-6307 mBeanName should be removed before returning from 
JmxReporter#removeAttribute()




---

[GitHub] kafka pull request #4288: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-06 Thread tedyu 
Github user tedyu closed the pull request at:

https://github.com/apache/kafka/pull/4288


---

[GitHub] kafka pull request #4299: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-06 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4299

KAFKA-6300 SelectorTest may fail with ConcurrentModificationException

Synchronization is added w.r.t. sockets ArrayList to avoid 
ConcurrentModificationException

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4299


commit 6ae5d0856ba3243f77157507b3cf554bfec4ac56
Author: tedyu 
Date:   2017-12-06T17:48:43Z

KAFKA-6300 SelectorTest may fail with ConcurrentModificationException




---

[GitHub] kafka pull request #4288: KAFKA-6300 SelectorTest may fail with ConcurrentMo...

2017-12-02 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4288

KAFKA-6300 SelectorTest may fail with ConcurrentModificationException

Synchronization is added w.r.t. sockets ArrayList to avoid 
ConcurrentModificationException

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4288.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4288


commit 8943cc9a39f297dacf091e8e02c09b44f6b9a6fe
Author: tedyu 
Date:   2017-12-03T00:13:37Z

KAFKA-6300 SelectorTest may fail with ConcurrentModificationException




---

[GitHub] kafka pull request #4254: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-11-22 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4254

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition

Replace ZkUtils with KafkaZkClient in ReplicaManager and Partition

Utilize existing unit tests

### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation 
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4254


commit f4991b2bd55ba1d0674928b92e525bb40af781e1
Author: tedyu 
Date:   2017-11-22T22:27:33Z

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition




---

[GitHub] kafka pull request #4166: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-11-22 Thread tedyu 
Github user tedyu closed the pull request at:

https://github.com/apache/kafka/pull/4166


---

[GitHub] kafka pull request #4176: KAFKA-6168 Connect Schema comparison is slow for l...

2017-11-03 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4176

KAFKA-6168 Connect Schema comparison is slow for large schemas

Re-arrange order of comparisons in equals() to evaluate non-composite 
fields first
Cache hash code

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4176.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4176


commit 4bae62c8ad64408b20e4925977beadaa42b54619
Author: tedyu 
Date:   2017-11-04T02:03:59Z

KAFKA-6168 Connect Schema comparison is slow for large schemas




---

[GitHub] kafka pull request #4166: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-10-31 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4166

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4166


commit 81298fe6bfdce9dbd30c5c5601b8ea172c2e04c8
Author: tedyu 
Date:   2017-11-01T03:10:10Z

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition




---

[GitHub] kafka pull request #4134: KAFKA-6075 Kafka cannot recover after an unclean s...

2017-10-25 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4134

KAFKA-6075 Kafka cannot recover after an unclean shutdown on Windows

As Vahid commented, Files.deleteIfExists(file.toPath) seems to destabilize 
Windows environment.

This PR reverts to calling delete() directly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4134


commit c734471f496b2bace8359f9c899cca73e636aa8d
Author: tedyu 
Date:   2017-10-25T16:28:18Z

KAFKA-6075 Kafka cannot recover after an unclean shutdown on Windows

commit 7355e8c282b1cb7d70f2c290702b5b216f28d3cd
Author: tedyu 
Date:   2017-10-25T16:36:50Z

Use delete()




---

[GitHub] kafka pull request #4127: MINOR use proper template classes for internalSele...

2017-10-24 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4127

MINOR use proper template classes for internalSelectKey()

As pointed out in this thread: 
http://search-hadoop.com/m/Kafka/uyzND1fy2K7I85G1?subj=Kafka+source+code+Build+Error
 , Eclipse shows syntax error for the following:
```
return new KeyValue<>(mapper.apply(key, value), 
value);
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4127


commit 582f353b08f8bd6c1d12e7e85cc72bc7875abaa7
Author: tedyu 
Date:   2017-10-24T20:07:00Z

MINOR use proper template classes for internalSelectKey()




---

[GitHub] kafka pull request #4124: KAFKA-6074 Use ZookeeperClient in ReplicaManager a...

2017-10-23 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4124

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4124


commit 0164ff44b0e67cbec9e8b56efe6e139ef87e5d69
Author: tedyu 
Date:   2017-10-24T04:51:59Z

KAFKA-6074 Use ZookeeperClient in ReplicaManager and Partition




---

[GitHub] kafka pull request #4118: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-23 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4118

KAFKA-6101 Reconnecting to broker does not exponentially backoff



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4118


commit cd928d3867e42774bb167b3aaf11ca6a8dd8d48f
Author: tedyu 
Date:   2017-10-23T13:49:27Z

KAFKA-6101 Reconnecting to broker does not exponentially backoff




---

[GitHub] kafka pull request #4108: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-23 Thread tedyu 
Github user tedyu closed the pull request at:

https://github.com/apache/kafka/pull/4108


---

[GitHub] kafka pull request #4108: KAFKA-6101 Reconnecting to broker does not exponen...

2017-10-20 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4108

KAFKA-6101 Reconnecting to broker does not exponentially backoff



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4108






---

[GitHub] kafka pull request #4052: KAFKA-6046 DeleteRecordsRequest to a non-leader sh...

2017-10-12 Thread tedyu 
Github user tedyu closed the pull request at:

https://github.com/apache/kafka/pull/4052


---

[GitHub] kafka pull request #4052: KAFKA-6046 DeleteRecordsRequest to a non-leader sh...

2017-10-10 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4052

KAFKA-6046 DeleteRecordsRequest to a non-leader should give proper error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4052.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4052


commit 4f25a3e9ef5cc079ca1ea549787d75f7ca6f8940
Author: tedyu 
Date:   2017-10-10T17:17:13Z

KAFKA-6046 DeleteRecordsRequest to a non-leader should give proper error




---

[GitHub] kafka pull request #4019: KAFKA-6011 AppInfoParser should only use metrics A...

2017-10-04 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/4019

KAFKA-6011 AppInfoParser should only use metrics API and should not 
register JMX mbeans directly

Added app ID to metrics API.

The JMX can be dropped post 1.0.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/4019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4019


commit 28b6a5868327fe827d57328c03e086eb3bb5c19c
Author: tedyu 
Date:   2017-10-04T20:10:22Z

KAFKA-6011 AppInfoParser should only use metrics API and should not 
register JMX mbeans directly




---

[GitHub] kafka pull request #3962: KAFKA-5973 Exit when ShutdownableThread encounters...

2017-09-27 Thread tedyu 
Github user tedyu closed the pull request at:

https://github.com/apache/kafka/pull/3962


---

[GitHub] kafka pull request #3962: KAFKA-5973 Exit when ShutdownableThread encounters...

2017-09-26 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/3962

KAFKA-5973 Exit when ShutdownableThread encounters uncaught exception

This PR installs UncaughtExceptionHandler which calls Exit.exit() .

According to discussion on KAFKA-5973, exiting seems to be the consensus in 
this scenario.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3962


commit 9b0b7671c4a454c5dd2a9fa44ac7cd841c8f71ed
Author: tedyu 
Date:   2017-09-26T16:14:02Z

KAFKA-5973 Exit when ShutdownableThread encounters uncaught exception




---

[GitHub] kafka pull request #3935: MINOR: improvement on top of KAFKA-5793: Tighten u...

2017-09-21 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/3935

MINOR: improvement on top of KAFKA-5793: Tighten up the semantics of the 
OutOfOrderSequenceException

Simplified the condition in Sender#failBatch()
Added log in TransactionManager#updateLastAckedOffset()

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3935


commit 7875acaa1f52b568aa190ac9b00c5d77f35b8219
Author: tedyu 
Date:   2017-09-21T17:00:39Z

MINOR: improvement on top of KAFKA-5793: Tighten up the semantics of the 
OutOfOrderSequenceException




---

[GitHub] kafka pull request #3925: KAFKA-5911 Avoid creation of extra Map for futures...

2017-09-20 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/3925

KAFKA-5911 Avoid creation of extra Map for futures in KafkaAdminClient

This reduces creation of garbage while keeping thread safety untouched.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3925


commit b53379ed9a327b2c195dffc4c5d537fb0a0ace13
Author: tedyu 
Date:   2017-09-20T21:09:21Z

KAFKA-5911 Avoid creation of extra Map for futures in KafkaAdminClient




---

[GitHub] kafka pull request #3812: KAFKA-5657 Connect REST API should include the con...

2017-09-07 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/3812

KAFKA-5657 Connect REST API should include the connector type when 
describing a connector

Embed the type of connector in ConnectorInfo

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3812


commit d51a65c81c576eb6a542adf92e9ab79d51f304d5
Author: tedyu 
Date:   2017-09-07T23:04:48Z

KAFKA-5657 Connect REST API should include the connector type when 
describing a connector




---

[GitHub] kafka pull request #3777: KAFKA-5820 Remove unneeded synchronized keyword in...

2017-09-01 Thread tedyu 
GitHub user tedyu opened a pull request:

https://github.com/apache/kafka/pull/3777

KAFKA-5820 Remove unneeded synchronized keyword in StreamThread

I removed synchronized keyword from 3 methods.

I ran the change thru streams module where test suite passed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tedyu/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3777


commit ef79c50e5e20236c589bbea2588fa7e11a892953
Author: tedyu 
Date:   2017-09-01T15:28:14Z

KAFKA-5820 Remove unneeded synchronized keyword in StreamThread




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---