Re: [DISCUSS] KIP-265: Make Windowed Serde to public APIs
@Xi: 1. SimpleConsumerShell is marked as deprecated in 0.11.0 and will be removed soon in the future releases, so I did not consider it in this KIP. 2. Yes, it is contained in the Public Interfaces section of the wiki, please read the section and let me know (it is slightly different with your proposed PR). Guozhang On Fri, Mar 2, 2018 at 3:43 AM, Damian Guy wrote: > Thanks Guozhang, LGTM > > On Fri, 2 Mar 2018 at 03:00 Hu Xi wrote: > > > Guozhang, > > > > > > Thanks for this KIP. Please help confirm questions below: > > > > 1. Do we also need to retrofit `SimpleConsumerShell` to have it > > support these newly-added serdes? > > 2. Does this KIP cover the changes for ConsoleConsumer as well? > > > > > > > > 发件人: Guozhang Wang > > 发送时间: 2018年3月2日 8:20 > > 收件人: dev@kafka.apache.org > > 主题: [DISCUSS] KIP-265: Make Windowed Serde to public APIs > > > > Hello all, > > > > I'd like to have a discussion on making windowed serde to public APIs of > > Kafka Streams. It involves a couple of new configs, plus a few new public > > classes for windowed serializer and deserializer, and also adding the > > corresponding console consumer options in order to fetch from a topic > > written by a windowed store. > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 265%3A+Make+Windowed+Serde+to+public+APIs > > > > I'd love to hear from your opinions on the proposed APIs, and if you have > > already encountered this and have to implement your own serdes, does the > > current public API fit your needs. > > > > > > Thanks, > > > > -- Guozhang > > > -- -- Guozhang
Re: [DISCUSS] KIP-265: Make Windowed Serde to public APIs
Thanks Guozhang, LGTM On Fri, 2 Mar 2018 at 03:00 Hu Xi wrote: > Guozhang, > > > Thanks for this KIP. Please help confirm questions below: > > 1. Do we also need to retrofit `SimpleConsumerShell` to have it > support these newly-added serdes? > 2. Does this KIP cover the changes for ConsoleConsumer as well? > > > > 发件人: Guozhang Wang > 发送时间: 2018年3月2日 8:20 > 收件人: dev@kafka.apache.org > 主题: [DISCUSS] KIP-265: Make Windowed Serde to public APIs > > Hello all, > > I'd like to have a discussion on making windowed serde to public APIs of > Kafka Streams. It involves a couple of new configs, plus a few new public > classes for windowed serializer and deserializer, and also adding the > corresponding console consumer options in order to fetch from a topic > written by a windowed store. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-265%3A+Make+Windowed+Serde+to+public+APIs > > I'd love to hear from your opinions on the proposed APIs, and if you have > already encountered this and have to implement your own serdes, does the > current public API fit your needs. > > > Thanks, > > -- Guozhang >
答复: [DISCUSS] KIP-265: Make Windowed Serde to public APIs
Guozhang, Thanks for this KIP. Please help confirm questions below: 1. Do we also need to retrofit `SimpleConsumerShell` to have it support these newly-added serdes? 2. Does this KIP cover the changes for ConsoleConsumer as well? 发件人: Guozhang Wang 发送时间: 2018年3月2日 8:20 收件人: dev@kafka.apache.org 主题: [DISCUSS] KIP-265: Make Windowed Serde to public APIs Hello all, I'd like to have a discussion on making windowed serde to public APIs of Kafka Streams. It involves a couple of new configs, plus a few new public classes for windowed serializer and deserializer, and also adding the corresponding console consumer options in order to fetch from a topic written by a windowed store. https://cwiki.apache.org/confluence/display/KAFKA/KIP-265%3A+Make+Windowed+Serde+to+public+APIs I'd love to hear from your opinions on the proposed APIs, and if you have already encountered this and have to implement your own serdes, does the current public API fit your needs. Thanks, -- Guozhang
[DISCUSS] KIP-265: Make Windowed Serde to public APIs
Hello all, I'd like to have a discussion on making windowed serde to public APIs of Kafka Streams. It involves a couple of new configs, plus a few new public classes for windowed serializer and deserializer, and also adding the corresponding console consumer options in order to fetch from a topic written by a windowed store. https://cwiki.apache.org/confluence/display/KAFKA/KIP-265%3A+Make+Windowed+Serde+to+public+APIs I'd love to hear from your opinions on the proposed APIs, and if you have already encountered this and have to implement your own serdes, does the current public API fit your needs. Thanks, -- Guozhang
