Re: [DISCUSS] KIP-318: Replace segments with segmentSize in WindowBytesStoreSupplier

2018-06-20 Thread John Roesler 
Oops! It looks like 318 was taken. I'll re-send this message to a new
thread.

On Wed, Jun 20, 2018 at 12:40 PM John Roesler  wrote:

> Hello All,
>
> I'd like to propose KIP-318 to fix an issue I identified in KAFKA-7080.
> Specifically, we're creating CachingWindowStore with the *number of
> segments* instead of the *segment size*.
>
> Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
> Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ
>
> additionally, here's a draft PR for clarity:
> https://github.com/apache/kafka/pull/5257
>
> Please let me know what you think!
>
> Thanks,
> -John
>

[DISCUSS] KIP-318: Replace segments with segmentSize in WindowBytesStoreSupplier

2018-06-20 Thread John Roesler 
Hello All,

I'd like to propose KIP-318 to fix an issue I identified in KAFKA-7080.
Specifically, we're creating CachingWindowStore with the *number of
segments* instead of the *segment size*.

Here's the jira: https://issues.apache.org/jira/browse/KAFKA-7080
Here's the KIP: https://cwiki.apache.org/confluence/x/mQU0BQ

additionally, here's a draft PR for clarity:
https://github.com/apache/kafka/pull/5257

Please let me know what you think!

Thanks,
-John