Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-06 Thread Christo Lolov
Hello Ismael,

Thank you for the valid points. I have updated the KIP, but do let me know if 
you believe it is still not clear enough.

Best,
Christo

> On 2 Mar 2023, at 15:21, Ismael Juma  wrote:
> 
> Thanks for the KIP. I think the following is a little confusing since it
> doesn't make it clear the the ZooKeeper deployment is separate from Kafka,
> Kafka only includes the ZooKeeper libraries. I think it would be useful to
> explain the upgrade process for someone running Apache Kafka 2.3 and
> ZooKeeper 3.4 (the hardest case) and the same for someone running Apache
> Kafka 2.4 and ZooKeeper 3.5.
> 
> Also, it's worth clarifying that we actually still test direct kafka
> upgrades from 0.8.2 to 3.4. In practice, we have distinguished "providing
> updates" versus "allowing direct upgrades from". Apache Kafka 4.0 will
> change this since you will have to upgrade to a bridge release before
> upgrading to 4.0, but that's a new development.
> 
> "Users who use Kafka clusters with Zookeeper clients older than 3.5.x won't
> be able to communicate with a Zookeeper cluster using 3.8.1. As mentioned
> in the accompanying JIRA ticket Apache Kafka has been using Zookeeper 3.5.x
> since version 2.4 so versions above and including it should be safe for
> this upgrade. It is acceptable to break compatibility with Apache Kafka
> versions prior to 2.4 as they are considered beyond their end of life and
> are not maintained. (source: Time Based Release Plan#WhatIsOurEOLPolicy)."
> 
> Ismael
> 
>> On Wed, Feb 15, 2023 at 1:47 AM Christo Lolov 
>> wrote:
>> 
>> Hello!
>> 
>> I would like to start a discussion for KIP-902: Upgrade Zookeeper to
>> 3.8.1. The Zookeeper version currently used in Kafka reached its end of
>> life in December 2022. You can find the KIP at
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240882784
>> 
>> Thanks in advance for the reviews.
>> 
>> Christo


Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-06 Thread Christo Lolov
Hey Luke,

Thank you for the review! My reasoning for going to ZK 3.8.1 directly is that 
if there isn’t a set date for the Kafka 4.0 release it gives us more time 
before we have to (potentially) upgrade ZK again (similar to what is mentioned 
here https://github.com/apache/kafka/pull/12620#issuecomment-1245590870). ZK 
3.7.1 also doesn’t support earlier client/server combinations different to what 
3.8.1 does.

Best,
Christo

> On 2 Mar 2023, at 07:07, Luke Chen  wrote:
> 
> Hi Christo,
> 
> Thanks for the KIP.
> The motivation of upgrading ZK makes sense.
> And thanks for the great analysis for the ZK upgrading.
> 
> One question:
> Since we are going to remove ZK in v4.0, and we don't need the latest
> feature in the "current release" ZK 3.8.1, why can't we choose the "stable
> release" (3.7.1)?
> 
> Thank you.
> Luke
> 
>> On Wed, Feb 15, 2023 at 5:47 PM Christo Lolov 
>> wrote:
>> 
>> Hello!
>> 
>> I would like to start a discussion for KIP-902: Upgrade Zookeeper to
>> 3.8.1. The Zookeeper version currently used in Kafka reached its end of
>> life in December 2022. You can find the KIP at
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240882784
>> 
>> Thanks in advance for the reviews.
>> 
>> Christo


Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-02 Thread Ismael Juma
Thanks for the KIP. I think the following is a little confusing since it
doesn't make it clear the the ZooKeeper deployment is separate from Kafka,
Kafka only includes the ZooKeeper libraries. I think it would be useful to
explain the upgrade process for someone running Apache Kafka 2.3 and
ZooKeeper 3.4 (the hardest case) and the same for someone running Apache
Kafka 2.4 and ZooKeeper 3.5.

Also, it's worth clarifying that we actually still test direct kafka
upgrades from 0.8.2 to 3.4. In practice, we have distinguished "providing
updates" versus "allowing direct upgrades from". Apache Kafka 4.0 will
change this since you will have to upgrade to a bridge release before
upgrading to 4.0, but that's a new development.

"Users who use Kafka clusters with Zookeeper clients older than 3.5.x won't
be able to communicate with a Zookeeper cluster using 3.8.1. As mentioned
in the accompanying JIRA ticket Apache Kafka has been using Zookeeper 3.5.x
since version 2.4 so versions above and including it should be safe for
this upgrade. It is acceptable to break compatibility with Apache Kafka
versions prior to 2.4 as they are considered beyond their end of life and
are not maintained. (source: Time Based Release Plan#WhatIsOurEOLPolicy)."

Ismael

On Wed, Feb 15, 2023 at 1:47 AM Christo Lolov 
wrote:

> Hello!
>
> I would like to start a discussion for KIP-902: Upgrade Zookeeper to
> 3.8.1. The Zookeeper version currently used in Kafka reached its end of
> life in December 2022. You can find the KIP at
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240882784
>
> Thanks in advance for the reviews.
>
> Christo


Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-01 Thread Luke Chen
Hi Christo,

Thanks for the KIP.
The motivation of upgrading ZK makes sense.
And thanks for the great analysis for the ZK upgrading.

One question:
Since we are going to remove ZK in v4.0, and we don't need the latest
feature in the "current release" ZK 3.8.1, why can't we choose the "stable
release" (3.7.1)?

Thank you.
Luke

On Wed, Feb 15, 2023 at 5:47 PM Christo Lolov 
wrote:

> Hello!
>
> I would like to start a discussion for KIP-902: Upgrade Zookeeper to
> 3.8.1. The Zookeeper version currently used in Kafka reached its end of
> life in December 2022. You can find the KIP at
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240882784
>
> Thanks in advance for the reviews.
>
> Christo


[DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-02-15 Thread Christo Lolov
Hello!

I would like to start a discussion for KIP-902: Upgrade Zookeeper to 3.8.1. The 
Zookeeper version currently used in Kafka reached its end of life in December 
2022. You can find the KIP at 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240882784

Thanks in advance for the reviews.

Christo