Re: [DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Bumping this thread as KIP-641 is now adopted.

Thanks
Fede

On Thu, Feb 16, 2023 at 11:13 AM Federico Valeri  wrote:
>
> On Thu, Feb 16, 2023 at 10:26 AM Luke Chen  wrote:
> >
> > Hi Federico,
> >
> > 1. Sounds good.
> > I think you should make it clear in the KIP.
> >
> > We only have one tool with this issue (kafka.tools.StateChangeLogMerger),
> > which is tracked in KAFKA-7735
> > . This has been broken
> > since 2.0 release, so it means that there is not much interest and we
> > should simply deprecate.
> > It makes me think we're going to abandon this tool since no one is
> > interested in it.
> > Could we make it clear to mention the broken tool will be fixed in an
> > on-going PR, but not included in the scope of this KIP?
> >
>
> Sure. That's a good idea.
>
> > 2. For the SPI argument, currently, KIP-641 is still under discussion, not
> > passing the votes.
> > Do we have any alternative if KIP-641 is rejected?
> >
>
> I think the first rejected alternative could also be used for the SPI
> argument issue.
>
> > Thank you.
> > Luke
> >
> > On Thu, Feb 16, 2023 at 4:56 PM Federico Valeri 
> > wrote:
> >
> > > Hi Luke, thanks for the feedback.
> > >
> > > On Thu, Feb 16, 2023 at 9:33 AM Luke Chen  wrote:
> > > >
> > > > Hi Federico,
> > > >
> > > > Thanks for the KIP.
> > > > It's really helpful to have a general guideline for tools migration so
> > > that
> > > > contributors and reviewers can be clear what to be expected.
> > > >
> > > > One question:
> > > > In the broker link tool, you said we should directly deprecate it.
> > > > But does that mean this tool will keep broken?
> > >
> > > No, as I already did both migration and fix in the following PR:
> > >
> > > https://github.com/apache/kafka/pull/13171
> > >
> > > > Will we fix that during the module movement?
> > > >
> > >
> > > If the above PR is accepted, we will have a deprecated but working
> > > version. The general orientation is to remove it in the next major
> > > release, because it was broker for a long time and nobody complained.
> > >
> > > > Thank you.
> > > > Luke
> > > >
> > > > On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri 
> > > > wrote:
> > > >
> > > > > Sorry for the spam. I had some issue with my mail client.
> > > > >
> > > > > On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri 
> > > > > wrote:
> > > > > >
> > > > > > Hi everyone,
> > > > > >
> > > > > > I opened KIP-906 to have some guidelines around tools migration:
> > > > > >
> > > > > >
> > > > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
> > > > > >
> > > > > > Let me know if you have any feedback or suggestions.
> > > > > >
> > > > > > Thanks
> > > > > > Fede
> > > > >
> > >

Re: [DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

On Thu, Feb 16, 2023 at 10:26 AM Luke Chen  wrote:
>
> Hi Federico,
>
> 1. Sounds good.
> I think you should make it clear in the KIP.
>
> We only have one tool with this issue (kafka.tools.StateChangeLogMerger),
> which is tracked in KAFKA-7735
> . This has been broken
> since 2.0 release, so it means that there is not much interest and we
> should simply deprecate.
> It makes me think we're going to abandon this tool since no one is
> interested in it.
> Could we make it clear to mention the broken tool will be fixed in an
> on-going PR, but not included in the scope of this KIP?
>

Sure. That's a good idea.

> 2. For the SPI argument, currently, KIP-641 is still under discussion, not
> passing the votes.
> Do we have any alternative if KIP-641 is rejected?
>

I think the first rejected alternative could also be used for the SPI
argument issue.

> Thank you.
> Luke
>
> On Thu, Feb 16, 2023 at 4:56 PM Federico Valeri 
> wrote:
>
> > Hi Luke, thanks for the feedback.
> >
> > On Thu, Feb 16, 2023 at 9:33 AM Luke Chen  wrote:
> > >
> > > Hi Federico,
> > >
> > > Thanks for the KIP.
> > > It's really helpful to have a general guideline for tools migration so
> > that
> > > contributors and reviewers can be clear what to be expected.
> > >
> > > One question:
> > > In the broker link tool, you said we should directly deprecate it.
> > > But does that mean this tool will keep broken?
> >
> > No, as I already did both migration and fix in the following PR:
> >
> > https://github.com/apache/kafka/pull/13171
> >
> > > Will we fix that during the module movement?
> > >
> >
> > If the above PR is accepted, we will have a deprecated but working
> > version. The general orientation is to remove it in the next major
> > release, because it was broker for a long time and nobody complained.
> >
> > > Thank you.
> > > Luke
> > >
> > > On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri 
> > > wrote:
> > >
> > > > Sorry for the spam. I had some issue with my mail client.
> > > >
> > > > On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri 
> > > > wrote:
> > > > >
> > > > > Hi everyone,
> > > > >
> > > > > I opened KIP-906 to have some guidelines around tools migration:
> > > > >
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
> > > > >
> > > > > Let me know if you have any feedback or suggestions.
> > > > >
> > > > > Thanks
> > > > > Fede
> > > >
> >

Re: [DISCUSS] KIP-906 Tools migration guidelines

[Luke Chen]

Hi Federico,

1. Sounds good.
I think you should make it clear in the KIP.

We only have one tool with this issue (kafka.tools.StateChangeLogMerger),
which is tracked in KAFKA-7735
. This has been broken
since 2.0 release, so it means that there is not much interest and we
should simply deprecate.
It makes me think we're going to abandon this tool since no one is
interested in it.
Could we make it clear to mention the broken tool will be fixed in an
on-going PR, but not included in the scope of this KIP?

2. For the SPI argument, currently, KIP-641 is still under discussion, not
passing the votes.
Do we have any alternative if KIP-641 is rejected?

Thank you.
Luke

On Thu, Feb 16, 2023 at 4:56 PM Federico Valeri 
wrote:

> Hi Luke, thanks for the feedback.
>
> On Thu, Feb 16, 2023 at 9:33 AM Luke Chen  wrote:
> >
> > Hi Federico,
> >
> > Thanks for the KIP.
> > It's really helpful to have a general guideline for tools migration so
> that
> > contributors and reviewers can be clear what to be expected.
> >
> > One question:
> > In the broker link tool, you said we should directly deprecate it.
> > But does that mean this tool will keep broken?
>
> No, as I already did both migration and fix in the following PR:
>
> https://github.com/apache/kafka/pull/13171
>
> > Will we fix that during the module movement?
> >
>
> If the above PR is accepted, we will have a deprecated but working
> version. The general orientation is to remove it in the next major
> release, because it was broker for a long time and nobody complained.
>
> > Thank you.
> > Luke
> >
> > On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri 
> > wrote:
> >
> > > Sorry for the spam. I had some issue with my mail client.
> > >
> > > On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri 
> > > wrote:
> > > >
> > > > Hi everyone,
> > > >
> > > > I opened KIP-906 to have some guidelines around tools migration:
> > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
> > > >
> > > > Let me know if you have any feedback or suggestions.
> > > >
> > > > Thanks
> > > > Fede
> > >
>

Re: [DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Hi Luke, thanks for the feedback.

On Thu, Feb 16, 2023 at 9:33 AM Luke Chen  wrote:
>
> Hi Federico,
>
> Thanks for the KIP.
> It's really helpful to have a general guideline for tools migration so that
> contributors and reviewers can be clear what to be expected.
>
> One question:
> In the broker link tool, you said we should directly deprecate it.
> But does that mean this tool will keep broken?

No, as I already did both migration and fix in the following PR:

https://github.com/apache/kafka/pull/13171

> Will we fix that during the module movement?
>

If the above PR is accepted, we will have a deprecated but working
version. The general orientation is to remove it in the next major
release, because it was broker for a long time and nobody complained.

> Thank you.
> Luke
>
> On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri 
> wrote:
>
> > Sorry for the spam. I had some issue with my mail client.
> >
> > On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri 
> > wrote:
> > >
> > > Hi everyone,
> > >
> > > I opened KIP-906 to have some guidelines around tools migration:
> > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
> > >
> > > Let me know if you have any feedback or suggestions.
> > >
> > > Thanks
> > > Fede
> >

Re: [DISCUSS] KIP-906 Tools migration guidelines

[Luke Chen]

Hi Federico,

Thanks for the KIP.
It's really helpful to have a general guideline for tools migration so that
contributors and reviewers can be clear what to be expected.

One question:
In the broker link tool, you said we should directly deprecate it.
But does that mean this tool will keep broken?
Will we fix that during the module movement?

Thank you.
Luke

On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri 
wrote:

> Sorry for the spam. I had some issue with my mail client.
>
> On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri 
> wrote:
> >
> > Hi everyone,
> >
> > I opened KIP-906 to have some guidelines around tools migration:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
> >
> > Let me know if you have any feedback or suggestions.
> >
> > Thanks
> > Fede
>

Re: [DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Sorry for the spam. I had some issue with my mail client.

On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri  wrote:
>
> Hi everyone,
>
> I opened KIP-906 to have some guidelines around tools migration:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines
>
> Let me know if you have any feedback or suggestions.
>
> Thanks
> Fede

[DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Hi everyone,

I opened KIP-906 to have some guidelines around tools migration:

https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines

Let me know if you have any feedback or suggestions.

Thanks
Fede

[DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Hi everyone,

I opened KIP-906 to have some guidelines around tools migration:

https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines

Let me know if you have any feedback or suggestions.

Thanks
Fede

[DISCUSS] KIP-906 Tools migration guidelines

[Federico Valeri]

Hi everyone,

I opened KIP-906 to have some guidelines around tools migration:

https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines

Let me know if you have any feedback or suggestions.

Thanks
Fede