[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1202658336 Updated to include a warning about loading a video from a third party -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201532009 @divijvaidya[ I found a free online JS compatibility tester ](https://seedmanc.github.io/jscc/) Here is the result https://user-images.githubusercontent.com/199238/182212411-c3b6aa17-9452-4bb0-a3ae-94f7f72b073c.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201359633 > Thank you for fixing this @bbejeck! > > Two questions: > > 1. How do we know that this code will work on all (or reasonable number of) browsers? > 2. As per the [ASF guideline](https://privacy.apache.org/faq/committers.html), we also need to need to "Make it clear that users who click the image will load a video from a third party." How do we achieve this? 1. It's vanilla javascript, so any of today's standard browsers should support this 2. I can update the text to state as much -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1201356851 > Thanks @bbejeck. > > I tested it locally and it looks good. Can we do the same to the Streams videos on https://kafka.apache.org/32/documentation/streams/ ? Hi @mimaison -yes I plan to have a PR submitted very soon (this week). Actually, the Streams videos go back to the `10` version, so it will cover all of those as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1200264008 @vvcephei I took a stab at putting a play button on the image - I think this version wins. Let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1199926659 >One suggestion if it's not too much trouble, and if you agree... It might be obvious from context that that image is a button that plays a video, but it would be clearer if we superimposed the "play arrow" over the middle on the image. What do you think? I agree, but the "play arrow" on the loaded `iframe` is coming from YouTube. I'm sure there's a way to do it, but that is beyond my CSS skills. I've updated the PR to have some text instructing to click to load the video. The text disappears when a user clicks the image. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #430: MINOR: Add clickable images to load iframe videos
bbejeck commented on PR #430: URL: https://github.com/apache/kafka-site/pull/430#issuecomment-1199820791 ping @divijvaidya, @mimaison , and @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
