[GitHub] [kafka-site] machi1990 commented on a diff in pull request #506: KAFKA-14925: Hosting JS files locally
machi1990 commented on code in PR #506: URL: https://github.com/apache/kafka-site/pull/506#discussion_r1174961543 ## includes/_header.htm: ## @@ -17,7 +17,7 @@ - https://use.fontawesome.com/releases/v5.0.8/js/all.js";> + Review Comment: thanks; The change looks good to me. let's wait to get a review from the committer as well /cc @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] machi1990 commented on a diff in pull request #506: KAFKA-14925: Hosting JS files locally
machi1990 commented on code in PR #506: URL: https://github.com/apache/kafka-site/pull/506#discussion_r1174403250 ## includes/_header.htm: ## @@ -17,7 +17,7 @@ - https://use.fontawesome.com/releases/v5.0.8/js/all.js";> + Review Comment: let's give this file a descriptive name e.g `fontawesome.js` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
