[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-20 Thread guozhangwang 
Github user guozhangwang commented on the issue:

https://github.com/apache/kafka-site/pull/112
  
LGTM. Merged to asf-site.


---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-20 Thread derrickdoo 
Github user derrickdoo commented on the issue:

https://github.com/apache/kafka-site/pull/112
  
👍 💯 LGTM


---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-15 Thread derrickdoo 
Github user derrickdoo commented on the issue:

https://github.com/apache/kafka-site/pull/112
  
@joel-hamill just took a look at your branch. Content looks good, but I'd 
suggest adding that horizontal subnav on the developer guide page for 
consistency and make sure users can easily jump around.

Here's the page I'm looking at:

![image](https://user-images.githubusercontent.com/271961/34065592-185b40c8-e1b8-11e7-93a3-b93198c6053c.png)



---

[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK

2017-12-12 Thread joel-hamill 
Github user joel-hamill commented on the issue:

https://github.com/apache/kafka-site/pull/112
  
ping @guozhangwang 


---