[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/83 KAFKA-1595; Remove deprecated and slower scala JSON parser Tested that we only use Jackson methods introduced in 2.0 in the main codebase by compiling it with the older version locally. We use a constructor introduced in 2.4 in one test, but I didn't remove it as it seemed harmless. The reasoning for this is explained in the mailing list thread: http://search-hadoop.com/m/uyzND1FWbWw1qUbWe You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-1595-remove-deprecated-json-parser-jackson Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit c4af0bccc7b7bb04b4ccd3499a73d7dd1edaaa65 Author: Ismael Juma ism...@juma.me.uk Date: 2015-07-17T10:43:22Z Update to JUnit 4.12. It includes `assertNotEquals`, which is used in a subsequent commit. commit 19033ed3a974a7e35f97ddb35463d6a0a24eab71 Author: Ismael Juma ism...@juma.me.uk Date: 2015-07-17T11:03:00Z Introduce `testJsonParse` Simple test that shows existing behaviour. commit 08ea63deebe88a77f4c54f01eac8cdcda8bb1b01 Author: Ismael Juma ism...@juma.me.uk Date: 2015-07-17T11:05:00Z KAFKA-1595; Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper increases safety while providing a simple, but powerful API through the usage of the `DecodeJson` type class. Even though this has a maintenance cost, it makes the API much more convenient from Scala. A number of tests were added to verify the behaviour of this wrapper. The Scala module for Jackson doesn't provide any help for our current usage, so we don't depend on it. An attempt has been made to maintain the existing behaviour regarding when exceptions are thrown. There are a number of cases where `JsonMappingException` will be thrown instead of `ClassCastException`, however. It is expected that users would not try to catch `ClassCastException`. commit 8cfdec90a2d0c5bbb156512e92fa2cb3ff714d0d Author: Ismael Juma ism...@juma.me.uk Date: 2015-07-17T11:06:00Z Minor clean-ups in `Json.encode` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/74 KAFKA-1595; Remove deprecated and slower scala JSON parser A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper increases safety while providing a simple, but powerful API through the usage of the `DecodeJson` type class. Even though this has a maintenance cost, it makes the API much more convenient from Scala. A number of tests were added to verify the behaviour of this wrapper. The Scala module for Jackson doesn't provide any help for our current usage, so we don't depend on it. An attempt has been made to maintain the existing behaviour regarding when exceptions are thrown. There are a number of cases where `JsonMappingException` will be thrown instead of `ClassCastException`, however. It is expected that users would not try to catch `ClassCastException`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-1595-remove-deprecated-json-parser-jackson Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 61f20cc04a89200c28eb77137671235516c81847 Author: Ismael Juma ism...@juma.me.uk Date: 2015-04-20T20:53:54Z Introduce `testJsonParse` Simple test that shows existing behaviour. commit 4ca0feb37e8be2d388b60efacc19bc6788b6 Author: Ismael Juma ism...@juma.me.uk Date: 2015-04-21T00:15:02Z KAFKA-1595; Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper increases safety while providing a simple, but powerful API through the usage of the `DecodeJson` type class. Even though this has a maintenance cost, it makes the API much more convenient from Scala. A number of tests were added to verify the behaviour of this wrapper. The Scala module for Jackson doesn't provide any help for our current usage, so we don't depend on it. An attempt has been made to maintain the existing behaviour regarding when exceptions are thrown. There are a number of cases where `JsonMappingException` will be thrown instead of `ClassCastException`, however. It is expected that users would not try to catch `ClassCastException`. commit f401990f13bddbd3d97e05756cf2f1abf367677e Author: Ismael Juma ism...@juma.me.uk Date: 2015-04-21T00:23:39Z Minor clean-ups in `Json.encode` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
