[GitHub] kafka pull request: KAFKA-3152; kafka-acl doesn't allow space in p...

[ijuma]

Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/820


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-3152; kafka-acl doesn't allow space in p...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/818


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-3152; kafka-acl doesn't allow space in p...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/820

KAFKA-3152; kafka-acl doesn't allow space in principal name (backport to 
0.9.0)

This is a backport of the trunk PR and it excludes the test
changes due to conflicts and the fact that the changes
were not directly related to the bug in the end
(it was something we did not test for, but the non-shell code
was already correct).

Details:

* Add quotes to `$` in shell scripts
This is necessary for correct processing of quotes in the
user command.

* Minor improvements to AclCommand messages

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-3152-backport-kafka-acl-space-in-principal-name

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #820


commit 20adaf6677c39865b3a288d112079f12f3842737
Author: Ismael Juma 
Date:   2016-01-27T16:23:25Z

KAFKA-3152; kafka-acl doesn't allow space in principal name

This is a backport of the trunk PR and it excludes the test
changes due to conflicts and the fact that the changes
were not directly related to the bug in the end
(it was something we did not test for, but the non-shell code
was already correct).

Details:

* Add quotes to `$` in shell scripts
This is necessary for correct processing of quotes in the
user command.

* Minor improvements to AclCommand messages




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-3152; kafka-acl doesn't allow space in p...

[ijuma]

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/818

KAFKA-3152; kafka-acl doesn't allow space in principal name

* Add quotes to `$@` in shell scripts
This is necessary for correct processing of quotes in the
user command.

* Minor improvements to AclCommand messages

* Use a principal with a space in `SslEndToEndAuthorizationTest`
This passed without any other changes, but good avoid regressions.

* Clean-up `TestSslUtils`:
Remove unused methods, fix unnecessary verbosity and don't set 
security.protocol (it should be done at a higher-level).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-3152-kafka-acl-space-in-principal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #818


commit 376b537f48dd593c68da7b296554b1ffb857ab98
Author: Ismael Juma 
Date:   2016-01-27T09:09:40Z

Add quotes to `$@` in shell scripts

This is necessary for correct processing of quotes in the
user command.

commit 24ca26bd32f763ce3945e0561ded05312594b3b3
Author: Ismael Juma 
Date:   2016-01-27T09:19:19Z

Minor improvements to AclCommand messages

commit 98cd852bb5ecfd4eece25737f1c27f89fdb48c65
Author: Ismael Juma 
Date:   2016-01-27T09:30:50Z

Use a principal with a space in `SslEndToEndAuthorizationTest`

Also clean-up `TestSslUtils`:
* Remove unused methods
* Fix unnecessary verbosity
* Don't set security.protocol (it should be done at a higher-level)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---