GitHub user jcustenborder opened a pull request:
https://github.com/apache/kafka/pull/936
KAFKA-3237 - Remove test cases testInvalidDefaultRange() and testInvaâ¦
Remove test cases testInvalidDefaultRange() and testInvalidDefaultString().
Defaults if not overridden will get checked on parse. Testing the defaults is
unnecessary. This allows you to set that a parameter is required while setting
a validator for that parameter. Added a test case testNullDefaultWithValidator
that allows a null default with a validator for certain strings.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcustenborder/kafka KAFKA-3237
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/936.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #936
commit 249e4d781235311742d270033a13b92bea582745
Author: Jeremy Custenborder
Date: 2016-02-19T06:04:46Z
KAFKA-3237 - Remove test cases testInvalidDefaultRange() and
testInvalidDefaultString(). Defaults if not overridden will get checked on
parse. Testing the defaults is unnecessary. This allows you to set that a
parameter is required while setting a validator for that parameter. Added a
test case testNullDefaultWithValidator that allows a null default with a
validator for certain strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
