[GitHub] kafka pull request #3358: KAFKA-5463: Controller incorrectly logs rack infor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3358


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3358: KAFKA-5463: Controller incorrectly logs rack infor...

[jeffchao]

GitHub user jeffchao opened a pull request:

https://github.com/apache/kafka/pull/3358

KAFKA-5463: Controller incorrectly logs rack information when new brokers 
are added

This change is in response to 
https://issues.apache.org/jira/browse/KAFKA-5463.

When a new broker is added, the `ControllerChannelManager` doesn't log rack 
information even if configured.

This happens because `ControllerChannelManager` always instantiates a 
`Node` using the same constructor whether or not rack-aware is configured and 
causes some confusion when running with rack-aware replica placement.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/heroku/kafka fix-controller-rack-aware-logging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3358.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3358


commit 9259e141d3655fe58c6e10b22b442a86b5ab8158
Author: Jeff Chao 
Date:   2017-06-16T21:46:21Z

Include rack information on UpdateMetadata request.

When a new broker is added, the ControllerChannelManager doesn't log
rack information even if configured.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---