[GitHub] kafka pull request #3747: KAFKA-5787: StoreChangelogReader needs to restore ...

2017-08-29 Thread dguy
Github user dguy closed the pull request at:

https://github.com/apache/kafka/pull/3747


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #3747: KAFKA-5787: StoreChangelogReader needs to restore ...

2017-08-27 Thread dguy
GitHub user dguy opened a pull request:

https://github.com/apache/kafka/pull/3747

KAFKA-5787: StoreChangelogReader needs to restore partitions that were 
added post initialization

If a task fails during initialization due to a LockException, its changelog 
partitions are not immediately added to the StoreChangelogReader as the thread 
doesn't hold the lock. However StoreChangelogReader#restore will be called and 
it sets the initialized flag. On a subsequent successfull call to initialize 
the new tasks the partitions are added to the StoreChangelogReader, however as 
it is already initialized these new partitions will never be restored. So the 
task would remain in a non-running state forever.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dguy/kafka kafka-5787-0.11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3747


commit 5569a472a03dc883e3b79c6c6e232a5dbaec5379
Author: Damian Guy 
Date:   2017-08-27T09:57:20Z

backport fix from trunk




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---