Re: [PR] [WIP] 37: Add latest apache/kafka/3.7 site-docs [kafka-site]

2024-02-22 Thread via GitHub


stanislavkozlovski commented on code in PR #587:
URL: https://github.com/apache/kafka-site/pull/587#discussion_r1500054892


##
37/streams/developer-guide/config-streams.html:
##
@@ -730,7 +713,6 @@ rack.aware.assignment.strategy
   none. This is the default value which means rack 
aware task assignment will be disabled.
   min_traffic. This settings means that the rack aware 
task assigner will compute an assignment which tries to minimize cross rack 
traffic.
-  balance_subtopology. This settings means that the 
rack aware task assigner will compute an assignment which will try to balance 
tasks from same subtopology to different clients and minimize cross rack 
traffic on top of that.

Review Comment:
   need to double check this and the above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [WIP] 37: Add latest apache/kafka/3.7 site-docs [kafka-site]

2024-02-22 Thread via GitHub


stanislavkozlovski commented on code in PR #587:
URL: https://github.com/apache/kafka-site/pull/587#discussion_r1500054892


##
37/streams/developer-guide/config-streams.html:
##
@@ -730,7 +713,6 @@ rack.aware.assignment.strategy
   none. This is the default value which means rack 
aware task assignment will be disabled.
   min_traffic. This settings means that the rack aware 
task assigner will compute an assignment which tries to minimize cross rack 
traffic.
-  balance_subtopology. This settings means that the 
rack aware task assigner will compute an assignment which will try to balance 
tasks from same subtopology to different clients and minimize cross rack 
traffic on top of that.

Review Comment:
   need to double check this and the above



##
37/security.html:
##
@@ -54,7 +54,7 @@ The LISTENER_NAME is usually a descriptive name which 
defines the purpose of
   the listener. For example, many configurations use a separate listener 
for client traffic,
-  so they might refer to the corresponding listener as CLIENT 
in the configuration:
+  so they might refer to the corresponding listener as CLIENT 
in the configuration: - need to fix in apache/kafka



##
37/generated/kafka_config.html:
##
@@ -1357,7 +1357,7 @@ The LISTENER_NAME is usually a descriptive name which 
defines the purpose of
   the listener. For example, many configurations use a separate listener 
for client traffic,
-  so they might refer to the corresponding listener as CLIENT 
in the configuration:
+  so they might refer to the corresponding listener as CLIENT 
in the configuration: - need to fix in apache/kafka



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [WIP] 37: Add latest apache/kafka/3.7 site-docs [kafka-site]

2024-02-22 Thread via GitHub


stanislavkozlovski opened a new pull request, #587:
URL: https://github.com/apache/kafka-site/pull/587

   WIP
   
   This patch adds the latest apache kafka site-docs to the kafka-site repo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org