[REVIEW REQUEST] KAFKA-14591 DeleteRecordsCommand moved to tools

[Николай Ижиков]

Hello.

I prepared PR [1] for ticket [2].
DeleteRecordsCommand rewritten in java and moved to tools module.
Currently, commands doesn’t have any tests so PR adds some tests, also.

Please, review.

[1] https://github.com/apache/kafka/pull/13278
[2] https://issues.apache.org/jira/browse/KAFKA-14591

Re: [REVIEW REQUEST] KAFKA-14591 DeleteRecordsCommand moved to tools

[Federico Valeri]

HI Nikolay, I did the review.

Thanks again for working on this.

Br
Fede

On Mon, Jul 10, 2023 at 12:08 PM Николай Ижиков  wrote:
>
> Hello.
>
> I prepared PR [1] for ticket [2].
> DeleteRecordsCommand rewritten in java and moved to tools module.
> Currently, commands doesn’t have any tests so PR adds some tests, also.
>
> Please, review.
>
> [1] https://github.com/apache/kafka/pull/13278
> [2] https://issues.apache.org/jira/browse/KAFKA-14591
>

Re: [REVIEW REQUEST] KAFKA-14591 DeleteRecordsCommand moved to tools

[Николай Ижиков]

Fixed all comments and checkstyle issues.
Please, make one more round of review.

> 10 июля 2023 г., в 16:17, Federico Valeri  написал(а):
> 
> HI Nikolay, I did the review.
> 
> Thanks again for working on this.
> 
> Br
> Fede
> 
> On Mon, Jul 10, 2023 at 12:08 PM Николай Ижиков  wrote:
>> 
>> Hello.
>> 
>> I prepared PR [1] for ticket [2].
>> DeleteRecordsCommand rewritten in java and moved to tools module.
>> Currently, commands doesn’t have any tests so PR adds some tests, also.
>> 
>> Please, review.
>> 
>> [1] https://github.com/apache/kafka/pull/13278
>> [2] https://issues.apache.org/jira/browse/KAFKA-14591
>> 

Re: [REVIEW REQUEST] KAFKA-14591 DeleteRecordsCommand moved to tools

[Николай Ижиков]

Federico, thanks for the review.

https://github.com/apache/kafka/pull/13278  - committers review required.

Dear committers, please, take a look.

> 10 июля 2023 г., в 17:23, Николай Ижиков  написал(а):
> 
> Fixed all comments and checkstyle issues.
> Please, make one more round of review.
> 
>> 10 июля 2023 г., в 16:17, Federico Valeri  написал(а):
>> 
>> HI Nikolay, I did the review.
>> 
>> Thanks again for working on this.
>> 
>> Br
>> Fede
>> 
>> On Mon, Jul 10, 2023 at 12:08 PM Николай Ижиков  wrote:
>>> 
>>> Hello.
>>> 
>>> I prepared PR [1] for ticket [2].
>>> DeleteRecordsCommand rewritten in java and moved to tools module.
>>> Currently, commands doesn’t have any tests so PR adds some tests, also.
>>> 
>>> Please, review.
>>> 
>>> [1] https://github.com/apache/kafka/pull/13278
>>> [2] https://issues.apache.org/jira/browse/KAFKA-14591
>>> 
>