Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hello, Mickael. Thanks for the reply and reviewing previous patches for this feature :). Just to let all know - I’ve got one approval from non commiter. So, if any committer has spare cycle, please, join the simple review that will help to rewrite tools in java https://github.com/apache/kafka/pull/14217 > 25 авг. 2023 г., в 13:25, Mickael Maison > написал(а): > > Hi Nikolay, > > Thanks for working on this feature. Take into account that many people > are on PTO at the moment and there's a lot of PRs to review. > Not sure why fixVersion was set to 3.6.0. Apart for key features or > fixes, it's usually best to only set the fixVersion once the code has > been merged. I've cleared that field. > > Thanks, > Mickael > > On Fri, Aug 25, 2023 at 9:26 AM Николай Ижиков wrote: >> >> Hello, Luke >> >> Thanks for reply. >> >> Actually, KAFKA-14595 [1] has fixVersion = 3.6.0 >> And the PR is part of the ticket. >> >> Several review required If we want to include java version of >> ReassignPartitionCommand in 3.6.0 >> >> [1] https://issues.apache.org/jira/browse/KAFKA-14595 >> >> >>> 23 авг. 2023 г., в 10:07, Luke Chen написал(а): >>> >>> Hi, >>> >>> Sorry that we're mostly working on features for v3.6.0, which is expected >>> to be released in the following weeks. >>> I'll review your PR after releasing. (Please ping me then if I forget it!) >>> >>> Also, it'd be good if the devs in the community can help on PR review when >>> available. >>> That'll help a lot. >>> Besides, PR review is also one kind of contribution, not just code >>> commitment. >>> >>> Thanks. >>> Luke >>> >>> >>> >>> On Tue, Aug 22, 2023 at 7:15 PM Николай Ижиков wrote: >>> Hello. Please, join the simple review) We have few steps left to completely rewrite ReassignPartitionsCommand in java. > 17 авг. 2023 г., в 17:16, Николай Ижиков написал(а): > > Hello. > > I’m working on [1]. > The goal of ticket is to rewire `ReassignPartitionCommand` in java. > > The PR that moves whole command is pretty big so it makes sense to split it. > I prepared the PR [2] that moves single test (ReassignPartitionsCommandArgsTest) to java. > > It relatively small and simple(touches only 3 files): > > To review - https://github.com/apache/kafka/pull/14217 > Big PR - https://github.com/apache/kafka/pull/13247 > > Please, review. > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > [2] https://github.com/apache/kafka/pull/14217 >>
Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hi Nikolay, Thanks for working on this feature. Take into account that many people are on PTO at the moment and there's a lot of PRs to review. Not sure why fixVersion was set to 3.6.0. Apart for key features or fixes, it's usually best to only set the fixVersion once the code has been merged. I've cleared that field. Thanks, Mickael On Fri, Aug 25, 2023 at 9:26 AM Николай Ижиков wrote: > > Hello, Luke > > Thanks for reply. > > Actually, KAFKA-14595 [1] has fixVersion = 3.6.0 > And the PR is part of the ticket. > > Several review required If we want to include java version of > ReassignPartitionCommand in 3.6.0 > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > > > > 23 авг. 2023 г., в 10:07, Luke Chen написал(а): > > > > Hi, > > > > Sorry that we're mostly working on features for v3.6.0, which is expected > > to be released in the following weeks. > > I'll review your PR after releasing. (Please ping me then if I forget it!) > > > > Also, it'd be good if the devs in the community can help on PR review when > > available. > > That'll help a lot. > > Besides, PR review is also one kind of contribution, not just code > > commitment. > > > > Thanks. > > Luke > > > > > > > > On Tue, Aug 22, 2023 at 7:15 PM Николай Ижиков wrote: > > > >> Hello. > >> > >> Please, join the simple review) > >> We have few steps left to completely rewrite ReassignPartitionsCommand in > >> java. > >> > >>> 17 авг. 2023 г., в 17:16, Николай Ижиков > >> написал(а): > >>> > >>> Hello. > >>> > >>> I’m working on [1]. > >>> The goal of ticket is to rewire `ReassignPartitionCommand` in java. > >>> > >>> The PR that moves whole command is pretty big so it makes sense to split > >> it. > >>> I prepared the PR [2] that moves single test > >> (ReassignPartitionsCommandArgsTest) to java. > >>> > >>> It relatively small and simple(touches only 3 files): > >>> > >>> To review - https://github.com/apache/kafka/pull/14217 > >>> Big PR - https://github.com/apache/kafka/pull/13247 > >>> > >>> Please, review. > >>> > >>> [1] https://issues.apache.org/jira/browse/KAFKA-14595 > >>> [2] https://github.com/apache/kafka/pull/14217 > >> > >> >
Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hello, Luke Thanks for reply. Actually, KAFKA-14595 [1] has fixVersion = 3.6.0 And the PR is part of the ticket. Several review required If we want to include java version of ReassignPartitionCommand in 3.6.0 [1] https://issues.apache.org/jira/browse/KAFKA-14595 > 23 авг. 2023 г., в 10:07, Luke Chen написал(а): > > Hi, > > Sorry that we're mostly working on features for v3.6.0, which is expected > to be released in the following weeks. > I'll review your PR after releasing. (Please ping me then if I forget it!) > > Also, it'd be good if the devs in the community can help on PR review when > available. > That'll help a lot. > Besides, PR review is also one kind of contribution, not just code > commitment. > > Thanks. > Luke > > > > On Tue, Aug 22, 2023 at 7:15 PM Николай Ижиков wrote: > >> Hello. >> >> Please, join the simple review) >> We have few steps left to completely rewrite ReassignPartitionsCommand in >> java. >> >>> 17 авг. 2023 г., в 17:16, Николай Ижиков >> написал(а): >>> >>> Hello. >>> >>> I’m working on [1]. >>> The goal of ticket is to rewire `ReassignPartitionCommand` in java. >>> >>> The PR that moves whole command is pretty big so it makes sense to split >> it. >>> I prepared the PR [2] that moves single test >> (ReassignPartitionsCommandArgsTest) to java. >>> >>> It relatively small and simple(touches only 3 files): >>> >>> To review - https://github.com/apache/kafka/pull/14217 >>> Big PR - https://github.com/apache/kafka/pull/13247 >>> >>> Please, review. >>> >>> [1] https://issues.apache.org/jira/browse/KAFKA-14595 >>> [2] https://github.com/apache/kafka/pull/14217 >> >>
Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hi, Sorry that we're mostly working on features for v3.6.0, which is expected to be released in the following weeks. I'll review your PR after releasing. (Please ping me then if I forget it!) Also, it'd be good if the devs in the community can help on PR review when available. That'll help a lot. Besides, PR review is also one kind of contribution, not just code commitment. Thanks. Luke On Tue, Aug 22, 2023 at 7:15 PM Николай Ижиков wrote: > Hello. > > Please, join the simple review) > We have few steps left to completely rewrite ReassignPartitionsCommand in > java. > > > 17 авг. 2023 г., в 17:16, Николай Ижиков > написал(а): > > > > Hello. > > > > I’m working on [1]. > > The goal of ticket is to rewire `ReassignPartitionCommand` in java. > > > > The PR that moves whole command is pretty big so it makes sense to split > it. > > I prepared the PR [2] that moves single test > (ReassignPartitionsCommandArgsTest) to java. > > > > It relatively small and simple(touches only 3 files): > > > > To review - https://github.com/apache/kafka/pull/14217 > > Big PR - https://github.com/apache/kafka/pull/13247 > > > > Please, review. > > > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > > [2] https://github.com/apache/kafka/pull/14217 > >
Re: [REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hello. Please, join the simple review) We have few steps left to completely rewrite ReassignPartitionsCommand in java. > 17 авг. 2023 г., в 17:16, Николай Ижиков написал(а): > > Hello. > > I’m working on [1]. > The goal of ticket is to rewire `ReassignPartitionCommand` in java. > > The PR that moves whole command is pretty big so it makes sense to split it. > I prepared the PR [2] that moves single test > (ReassignPartitionsCommandArgsTest) to java. > > It relatively small and simple(touches only 3 files): > > To review - https://github.com/apache/kafka/pull/14217 > Big PR - https://github.com/apache/kafka/pull/13247 > > Please, review. > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > [2] https://github.com/apache/kafka/pull/14217
[REVIEW REQUEST] Move ReassignPartitionsCommandArgsTest to java
Hello. I’m working on [1]. The goal of ticket is to rewire `ReassignPartitionCommand` in java. The PR that moves whole command is pretty big so it makes sense to split it. I prepared the PR [2] that moves single test (ReassignPartitionsCommandArgsTest) to java. It relatively small and simple(touches only 3 files): To review - https://github.com/apache/kafka/pull/14217 Big PR - https://github.com/apache/kafka/pull/13247 Please, review. [1] https://issues.apache.org/jira/browse/KAFKA-14595 [2] https://github.com/apache/kafka/pull/14217
