Re:[REVIEW REQUEST] Move ReassignPartitionsIntegrationTest to java
Hi Nikolay, The patch is OK with me. I leaved minor comments at the PR.
Re: [REVIEW REQUEST] Move ReassignPartitionsIntegrationTest to java
Hello. CI seems to be OK. Please, join the review. > 27 сент. 2023 г., в 00:22, Николай Ижиков написал(а): > > Hello. > > Long story short - one scala test of ReassingPartitionCommand remain and I > rewrote it in java - https://github.com/apache/kafka/pull/14456 > > Please, review. > > I’m working on [1]. > The PR that moves whole command is pretty big so it makes sense to split it. > I prepared the PR [2] that moves single test > (ReassignPartitionsIntegrationTest) to java. > > It smaller and simpler(touches only 5 files): > To review - https://github.com/apache/kafka/pull/14456 > Big PR - https://github.com/apache/kafka/pull/13247 > > [1] https://issues.apache.org/jira/browse/KAFKA-14595 > [2] https://github.com/apache/kafka/pull/14456
[REVIEW REQUEST] Move ReassignPartitionsIntegrationTest to java
Hello. Long story short - one scala test of ReassingPartitionCommand remain and I rewrote it in java - https://github.com/apache/kafka/pull/14456 Please, review. I’m working on [1]. The PR that moves whole command is pretty big so it makes sense to split it. I prepared the PR [2] that moves single test (ReassignPartitionsIntegrationTest) to java. It smaller and simpler(touches only 5 files): To review - https://github.com/apache/kafka/pull/14456 Big PR - https://github.com/apache/kafka/pull/13247 [1] https://issues.apache.org/jira/browse/KAFKA-14595 [2] https://github.com/apache/kafka/pull/14456