Re: [VOTE] 3.4.1 RC2

2023-05-25 Thread Luke Chen
Thanks all for helping verify the RC2.

But my team member found a bug that in KRaft mode, we'll log every commit
message in info level, with `handleSnapshot: xxx`.
That means, in KRaft mode, the active controller log will be flooded with
this message every 500ms (default no-op message commit interval).

I've opened a PR to fix it: https://github.com/apache/kafka/pull/13763.
After this PR merged, I'll create another RC.

Thank you.
Luke

On Thu, May 25, 2023 at 2:53 AM Josep Prat 
wrote:

> Hi Luke,
>
> Thanks for your patience during this release.
>
> I ran the following validation steps:
> - Built from source with Java 11 and Scala 2.13
> - Signatures and hashes of the artifacts generated
> - Navigated through Javadoc including links to JDK classes
> - Run the unit tests
> - Run integration tests
> - Run the quickstart in KRaft and Zookeeper mode
> - Checked that the diff in LICENSE-binary (between this and previous RC) is
> correct
> -- For each difference I checked the binary on the scala 2.13 package had
> the version specified in the file
>
> This gets a +1 from me.
>
>
> Best,
>
> On Wed, May 24, 2023 at 6:48 PM Federico Valeri 
> wrote:
>
> > Hi Luke, these are the things I checked:
> >
> > - Source signature, checksum and license file
> > - Build from source with Java 17 and Scala 2.13
> > - Unit and integration test suites
> > - Java app with staging Maven artifacts
> >
> > +1 (non binding)
> >
> > Thanks
> > Fede
> >
> >
> > On Wed, May 24, 2023 at 6:36 PM Chris Egerton 
> > wrote:
> > >
> > > Hi Luke,
> > >
> > > Thanks again for running this release! Echoing your hopes that this
> will
> > be
> > > the final 3.4.1 release candidate :)
> > >
> > > To verify, I:
> > > - Built from source with Java 11 with both:
> > > - - the 3.4.1-rc2 tag on GitHub
> > > - - the kafka-3.4.1-src.tgz artifact from
> > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> > > - Checked signatures and checksums
> > > - Ran the quickstart using the kafka_2.13-3.4.1.tgz artifact from
> > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/ with Java 11 and
> > Scala 13
> > > in KRaft mode
> > > - Ran all unit tests
> > > - - No failures this time! 
> > > - Ran all integration tests for Connect and MM2
> > >
> > > +1 (binding)
> > >
> > > Cheers,
> > >
> > > Chris
> > >
> > > On Wed, May 24, 2023 at 6:12 AM Luke Chen  wrote:
> > >
> > > > Hello Kafka users, developers and client-developers,
> > > >
> > > > This is the 3rd candidate for release of Apache Kafka 3.4.1.
> > > >
> > > > This is a bugfix release with several fixes since the release of
> > 3.4.0. A
> > > > few of the major issues include:
> > > > - core
> > > > KAFKA-14644 
> > Process
> > > > should stop after failure in raft IO thread
> > > > KAFKA-14946 
> KRaft
> > > > controller node shutting down while renouncing leadership
> > > > KAFKA-14887  ZK
> > session
> > > > timeout can cause broker to shutdown
> > > > - client
> > > > KAFKA-14639 
> Kafka
> > > > CooperativeStickyAssignor revokes/assigns partition in one rebalance
> > cycle
> > > > - connect
> > > > KAFKA-12558  MM2
> > may
> > > > not
> > > > sync partition offsets correctly
> > > > KAFKA-14666  MM2
> > should
> > > > translate consumer group offsets behind replication flow
> > > > - stream
> > > > KAFKA-14172  bug:
> > State
> > > > stores lose state when tasks are reassigned under EOS
> > > >
> > > >
> > > > Release notes for the 3.4.1 release:
> > > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/RELEASE_NOTES.html
> > > >
> > > > *** Please download, test and vote by May 31, 2023
> > > >
> > > > Kafka's KEYS file containing PGP keys we use to sign the release:
> > > > https://kafka.apache.org/KEYS
> > > >
> > > > * Release artifacts to be voted upon (source and binary):
> > > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> > > >
> > > > * Maven artifacts to be voted upon:
> > > >
> https://repository.apache.org/content/groups/staging/org/apache/kafka/
> > > >
> > > > * Javadoc:
> > > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/javadoc/
> > > >
> > > > * Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
> > > > https://github.com/apache/kafka/releases/tag/3.4.1-rc2
> > > >
> > > > * Documentation: (will be updated after released)
> > > > https://kafka.apache.org/34/documentation.html
> > > >
> > > > * Protocol: (will be updated after released)
> > > > https://kafka.apache.org/34/protocol.html
> > > > The most recent build has had test failures. These all appear to be
> > due to
> > > > flakiness, but it would be nice if someone more familiar with the
> > failed
> > > > tests could confirm this. I may update this 

Re: [VOTE] 3.4.1 RC2

2023-05-24 Thread Josep Prat
Hi Luke,

Thanks for your patience during this release.

I ran the following validation steps:
- Built from source with Java 11 and Scala 2.13
- Signatures and hashes of the artifacts generated
- Navigated through Javadoc including links to JDK classes
- Run the unit tests
- Run integration tests
- Run the quickstart in KRaft and Zookeeper mode
- Checked that the diff in LICENSE-binary (between this and previous RC) is
correct
-- For each difference I checked the binary on the scala 2.13 package had
the version specified in the file

This gets a +1 from me.


Best,

On Wed, May 24, 2023 at 6:48 PM Federico Valeri 
wrote:

> Hi Luke, these are the things I checked:
>
> - Source signature, checksum and license file
> - Build from source with Java 17 and Scala 2.13
> - Unit and integration test suites
> - Java app with staging Maven artifacts
>
> +1 (non binding)
>
> Thanks
> Fede
>
>
> On Wed, May 24, 2023 at 6:36 PM Chris Egerton 
> wrote:
> >
> > Hi Luke,
> >
> > Thanks again for running this release! Echoing your hopes that this will
> be
> > the final 3.4.1 release candidate :)
> >
> > To verify, I:
> > - Built from source with Java 11 with both:
> > - - the 3.4.1-rc2 tag on GitHub
> > - - the kafka-3.4.1-src.tgz artifact from
> > https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> > - Checked signatures and checksums
> > - Ran the quickstart using the kafka_2.13-3.4.1.tgz artifact from
> > https://home.apache.org/~showuon/kafka-3.4.1-rc2/ with Java 11 and
> Scala 13
> > in KRaft mode
> > - Ran all unit tests
> > - - No failures this time! 
> > - Ran all integration tests for Connect and MM2
> >
> > +1 (binding)
> >
> > Cheers,
> >
> > Chris
> >
> > On Wed, May 24, 2023 at 6:12 AM Luke Chen  wrote:
> >
> > > Hello Kafka users, developers and client-developers,
> > >
> > > This is the 3rd candidate for release of Apache Kafka 3.4.1.
> > >
> > > This is a bugfix release with several fixes since the release of
> 3.4.0. A
> > > few of the major issues include:
> > > - core
> > > KAFKA-14644 
> Process
> > > should stop after failure in raft IO thread
> > > KAFKA-14946  KRaft
> > > controller node shutting down while renouncing leadership
> > > KAFKA-14887  ZK
> session
> > > timeout can cause broker to shutdown
> > > - client
> > > KAFKA-14639  Kafka
> > > CooperativeStickyAssignor revokes/assigns partition in one rebalance
> cycle
> > > - connect
> > > KAFKA-12558  MM2
> may
> > > not
> > > sync partition offsets correctly
> > > KAFKA-14666  MM2
> should
> > > translate consumer group offsets behind replication flow
> > > - stream
> > > KAFKA-14172  bug:
> State
> > > stores lose state when tasks are reassigned under EOS
> > >
> > >
> > > Release notes for the 3.4.1 release:
> > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/RELEASE_NOTES.html
> > >
> > > *** Please download, test and vote by May 31, 2023
> > >
> > > Kafka's KEYS file containing PGP keys we use to sign the release:
> > > https://kafka.apache.org/KEYS
> > >
> > > * Release artifacts to be voted upon (source and binary):
> > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> > >
> > > * Maven artifacts to be voted upon:
> > > https://repository.apache.org/content/groups/staging/org/apache/kafka/
> > >
> > > * Javadoc:
> > > https://home.apache.org/~showuon/kafka-3.4.1-rc2/javadoc/
> > >
> > > * Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
> > > https://github.com/apache/kafka/releases/tag/3.4.1-rc2
> > >
> > > * Documentation: (will be updated after released)
> > > https://kafka.apache.org/34/documentation.html
> > >
> > > * Protocol: (will be updated after released)
> > > https://kafka.apache.org/34/protocol.html
> > > The most recent build has had test failures. These all appear to be
> due to
> > > flakiness, but it would be nice if someone more familiar with the
> failed
> > > tests could confirm this. I may update this thread with passing build
> links
> > > if I can get one, or start a new release vote thread if test failures
> must
> > > be addressed beyond re-running builds until they pass.
> > >
> > > Unit/integration tests:
> > > https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.4/138/
> > >
> > > System tests:
> > > Will update the results later
> > >
> > > Hope this will be the final RC for v3.4.1!
> > >
> > > Thank you.
> > > Luke
> > >
>


-- 
[image: Aiven] 

*Josep Prat*
Open Source Engineering Director, *Aiven*
josep.p...@aiven.io   |   +491715557497
aiven.io    |   
     
*Aiven Deutschland GmbH*

Re: [VOTE] 3.4.1 RC2

2023-05-24 Thread Federico Valeri
Hi Luke, these are the things I checked:

- Source signature, checksum and license file
- Build from source with Java 17 and Scala 2.13
- Unit and integration test suites
- Java app with staging Maven artifacts

+1 (non binding)

Thanks
Fede


On Wed, May 24, 2023 at 6:36 PM Chris Egerton  wrote:
>
> Hi Luke,
>
> Thanks again for running this release! Echoing your hopes that this will be
> the final 3.4.1 release candidate :)
>
> To verify, I:
> - Built from source with Java 11 with both:
> - - the 3.4.1-rc2 tag on GitHub
> - - the kafka-3.4.1-src.tgz artifact from
> https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> - Checked signatures and checksums
> - Ran the quickstart using the kafka_2.13-3.4.1.tgz artifact from
> https://home.apache.org/~showuon/kafka-3.4.1-rc2/ with Java 11 and Scala 13
> in KRaft mode
> - Ran all unit tests
> - - No failures this time! 
> - Ran all integration tests for Connect and MM2
>
> +1 (binding)
>
> Cheers,
>
> Chris
>
> On Wed, May 24, 2023 at 6:12 AM Luke Chen  wrote:
>
> > Hello Kafka users, developers and client-developers,
> >
> > This is the 3rd candidate for release of Apache Kafka 3.4.1.
> >
> > This is a bugfix release with several fixes since the release of 3.4.0. A
> > few of the major issues include:
> > - core
> > KAFKA-14644  Process
> > should stop after failure in raft IO thread
> > KAFKA-14946  KRaft
> > controller node shutting down while renouncing leadership
> > KAFKA-14887  ZK session
> > timeout can cause broker to shutdown
> > - client
> > KAFKA-14639  Kafka
> > CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle
> > - connect
> > KAFKA-12558  MM2 may
> > not
> > sync partition offsets correctly
> > KAFKA-14666  MM2 should
> > translate consumer group offsets behind replication flow
> > - stream
> > KAFKA-14172  bug: State
> > stores lose state when tasks are reassigned under EOS
> >
> >
> > Release notes for the 3.4.1 release:
> > https://home.apache.org/~showuon/kafka-3.4.1-rc2/RELEASE_NOTES.html
> >
> > *** Please download, test and vote by May 31, 2023
> >
> > Kafka's KEYS file containing PGP keys we use to sign the release:
> > https://kafka.apache.org/KEYS
> >
> > * Release artifacts to be voted upon (source and binary):
> > https://home.apache.org/~showuon/kafka-3.4.1-rc2/
> >
> > * Maven artifacts to be voted upon:
> > https://repository.apache.org/content/groups/staging/org/apache/kafka/
> >
> > * Javadoc:
> > https://home.apache.org/~showuon/kafka-3.4.1-rc2/javadoc/
> >
> > * Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
> > https://github.com/apache/kafka/releases/tag/3.4.1-rc2
> >
> > * Documentation: (will be updated after released)
> > https://kafka.apache.org/34/documentation.html
> >
> > * Protocol: (will be updated after released)
> > https://kafka.apache.org/34/protocol.html
> > The most recent build has had test failures. These all appear to be due to
> > flakiness, but it would be nice if someone more familiar with the failed
> > tests could confirm this. I may update this thread with passing build links
> > if I can get one, or start a new release vote thread if test failures must
> > be addressed beyond re-running builds until they pass.
> >
> > Unit/integration tests:
> > https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.4/138/
> >
> > System tests:
> > Will update the results later
> >
> > Hope this will be the final RC for v3.4.1!
> >
> > Thank you.
> > Luke
> >


Re: [VOTE] 3.4.1 RC2

2023-05-24 Thread Chris Egerton
Hi Luke,

Thanks again for running this release! Echoing your hopes that this will be
the final 3.4.1 release candidate :)

To verify, I:
- Built from source with Java 11 with both:
- - the 3.4.1-rc2 tag on GitHub
- - the kafka-3.4.1-src.tgz artifact from
https://home.apache.org/~showuon/kafka-3.4.1-rc2/
- Checked signatures and checksums
- Ran the quickstart using the kafka_2.13-3.4.1.tgz artifact from
https://home.apache.org/~showuon/kafka-3.4.1-rc2/ with Java 11 and Scala 13
in KRaft mode
- Ran all unit tests
- - No failures this time! 
- Ran all integration tests for Connect and MM2

+1 (binding)

Cheers,

Chris

On Wed, May 24, 2023 at 6:12 AM Luke Chen  wrote:

> Hello Kafka users, developers and client-developers,
>
> This is the 3rd candidate for release of Apache Kafka 3.4.1.
>
> This is a bugfix release with several fixes since the release of 3.4.0. A
> few of the major issues include:
> - core
> KAFKA-14644  Process
> should stop after failure in raft IO thread
> KAFKA-14946  KRaft
> controller node shutting down while renouncing leadership
> KAFKA-14887  ZK session
> timeout can cause broker to shutdown
> - client
> KAFKA-14639  Kafka
> CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle
> - connect
> KAFKA-12558  MM2 may
> not
> sync partition offsets correctly
> KAFKA-14666  MM2 should
> translate consumer group offsets behind replication flow
> - stream
> KAFKA-14172  bug: State
> stores lose state when tasks are reassigned under EOS
>
>
> Release notes for the 3.4.1 release:
> https://home.apache.org/~showuon/kafka-3.4.1-rc2/RELEASE_NOTES.html
>
> *** Please download, test and vote by May 31, 2023
>
> Kafka's KEYS file containing PGP keys we use to sign the release:
> https://kafka.apache.org/KEYS
>
> * Release artifacts to be voted upon (source and binary):
> https://home.apache.org/~showuon/kafka-3.4.1-rc2/
>
> * Maven artifacts to be voted upon:
> https://repository.apache.org/content/groups/staging/org/apache/kafka/
>
> * Javadoc:
> https://home.apache.org/~showuon/kafka-3.4.1-rc2/javadoc/
>
> * Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
> https://github.com/apache/kafka/releases/tag/3.4.1-rc2
>
> * Documentation: (will be updated after released)
> https://kafka.apache.org/34/documentation.html
>
> * Protocol: (will be updated after released)
> https://kafka.apache.org/34/protocol.html
> The most recent build has had test failures. These all appear to be due to
> flakiness, but it would be nice if someone more familiar with the failed
> tests could confirm this. I may update this thread with passing build links
> if I can get one, or start a new release vote thread if test failures must
> be addressed beyond re-running builds until they pass.
>
> Unit/integration tests:
> https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.4/138/
>
> System tests:
> Will update the results later
>
> Hope this will be the final RC for v3.4.1!
>
> Thank you.
> Luke
>


[VOTE] 3.4.1 RC2

2023-05-24 Thread Luke Chen
Hello Kafka users, developers and client-developers,

This is the 3rd candidate for release of Apache Kafka 3.4.1.

This is a bugfix release with several fixes since the release of 3.4.0. A
few of the major issues include:
- core
KAFKA-14644  Process
should stop after failure in raft IO thread
KAFKA-14946  KRaft
controller node shutting down while renouncing leadership
KAFKA-14887  ZK session
timeout can cause broker to shutdown
- client
KAFKA-14639  Kafka
CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle
- connect
KAFKA-12558  MM2 may not
sync partition offsets correctly
KAFKA-14666  MM2 should
translate consumer group offsets behind replication flow
- stream
KAFKA-14172  bug: State
stores lose state when tasks are reassigned under EOS


Release notes for the 3.4.1 release:
https://home.apache.org/~showuon/kafka-3.4.1-rc2/RELEASE_NOTES.html

*** Please download, test and vote by May 31, 2023

Kafka's KEYS file containing PGP keys we use to sign the release:
https://kafka.apache.org/KEYS

* Release artifacts to be voted upon (source and binary):
https://home.apache.org/~showuon/kafka-3.4.1-rc2/

* Maven artifacts to be voted upon:
https://repository.apache.org/content/groups/staging/org/apache/kafka/

* Javadoc:
https://home.apache.org/~showuon/kafka-3.4.1-rc2/javadoc/

* Tag to be voted upon (off 3.4 branch) is the 3.4.1 tag:
https://github.com/apache/kafka/releases/tag/3.4.1-rc2

* Documentation: (will be updated after released)
https://kafka.apache.org/34/documentation.html

* Protocol: (will be updated after released)
https://kafka.apache.org/34/protocol.html
The most recent build has had test failures. These all appear to be due to
flakiness, but it would be nice if someone more familiar with the failed
tests could confirm this. I may update this thread with passing build links
if I can get one, or start a new release vote thread if test failures must
be addressed beyond re-running builds until they pass.

Unit/integration tests:
https://ci-builds.apache.org/job/Kafka/job/kafka/job/3.4/138/

System tests:
Will update the results later

Hope this will be the final RC for v3.4.1!

Thank you.
Luke