Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-21 Thread Bruno Cadonna
Hi,

Since the voting passed the 72 hours and the number of binding votes
are reached I will close this voting.

KIP-471 passes with
- 3 binding votes (Bill, Guozhang, Matthias)
- 2 non-binding votes (John, Patrik)

Thank you to all for the discussion and the voting.

Best,
Bruno

On Thu, Jun 20, 2019 at 11:14 PM Matthias J. Sax  wrote:
>
> +1 (binding)
>
>
> On 6/20/19 11:53 AM, Guozhang Wang wrote:
> > +1 (binding)
> >
> > Thanks Bruno!
> >
> > Would also be interested to see how much overhead it may incur by enabling
> > DEBUG metrics now, if it is huge we may consider doing finer-grained
> > metrics enabling, but that would be another follow-up task.
> >
> > Guozhang
> >
> > On Wed, Jun 19, 2019 at 1:37 PM Patrik Kleindl  wrote:
> >
> >> +1 (non-binding)
> >> Thanks!
> >> Best regards
> >> Patrik
> >>
> >>> Am 19.06.2019 um 21:55 schrieb Bill Bejeck :
> >>>
> >>> +1 (binding)
> >>>
> >>> Thanks,
> >>> Bill
> >>>
>  On Wed, Jun 19, 2019 at 1:19 PM John Roesler  wrote:
> 
>  I'm +1 (nonbinding)
> 
>  Thanks!
>  -John
> 
> > On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna 
> >> wrote:
> >
> > Hi,
> >
> > I would like to start the voting on KIP-471:
> >
> 
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
> >
> > You can find the discussion here:
> >
> 
> >> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
> >
> > Best,
> > Bruno
> 
> >>
> >
> >
>


Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-20 Thread Matthias J. Sax
+1 (binding)


On 6/20/19 11:53 AM, Guozhang Wang wrote:
> +1 (binding)
> 
> Thanks Bruno!
> 
> Would also be interested to see how much overhead it may incur by enabling
> DEBUG metrics now, if it is huge we may consider doing finer-grained
> metrics enabling, but that would be another follow-up task.
> 
> Guozhang
> 
> On Wed, Jun 19, 2019 at 1:37 PM Patrik Kleindl  wrote:
> 
>> +1 (non-binding)
>> Thanks!
>> Best regards
>> Patrik
>>
>>> Am 19.06.2019 um 21:55 schrieb Bill Bejeck :
>>>
>>> +1 (binding)
>>>
>>> Thanks,
>>> Bill
>>>
 On Wed, Jun 19, 2019 at 1:19 PM John Roesler  wrote:

 I'm +1 (nonbinding)

 Thanks!
 -John

> On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna 
>> wrote:
>
> Hi,
>
> I would like to start the voting on KIP-471:
>

>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
>
> You can find the discussion here:
>

>> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
>
> Best,
> Bruno

>>
> 
> 



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-20 Thread Guozhang Wang
+1 (binding)

Thanks Bruno!

Would also be interested to see how much overhead it may incur by enabling
DEBUG metrics now, if it is huge we may consider doing finer-grained
metrics enabling, but that would be another follow-up task.

Guozhang

On Wed, Jun 19, 2019 at 1:37 PM Patrik Kleindl  wrote:

> +1 (non-binding)
> Thanks!
> Best regards
> Patrik
>
> > Am 19.06.2019 um 21:55 schrieb Bill Bejeck :
> >
> > +1 (binding)
> >
> > Thanks,
> > Bill
> >
> >> On Wed, Jun 19, 2019 at 1:19 PM John Roesler  wrote:
> >>
> >> I'm +1 (nonbinding)
> >>
> >> Thanks!
> >> -John
> >>
> >>> On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna 
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I would like to start the voting on KIP-471:
> >>>
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
> >>>
> >>> You can find the discussion here:
> >>>
> >>
> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
> >>>
> >>> Best,
> >>> Bruno
> >>
>


-- 
-- Guozhang


Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-19 Thread Patrik Kleindl
+1 (non-binding)
Thanks!
Best regards 
Patrik 

> Am 19.06.2019 um 21:55 schrieb Bill Bejeck :
> 
> +1 (binding)
> 
> Thanks,
> Bill
> 
>> On Wed, Jun 19, 2019 at 1:19 PM John Roesler  wrote:
>> 
>> I'm +1 (nonbinding)
>> 
>> Thanks!
>> -John
>> 
>>> On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna  wrote:
>>> 
>>> Hi,
>>> 
>>> I would like to start the voting on KIP-471:
>>> 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
>>> 
>>> You can find the discussion here:
>>> 
>> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
>>> 
>>> Best,
>>> Bruno
>> 


Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-19 Thread Bill Bejeck
+1 (binding)

Thanks,
Bill

On Wed, Jun 19, 2019 at 1:19 PM John Roesler  wrote:

> I'm +1 (nonbinding)
>
> Thanks!
> -John
>
> On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna  wrote:
> >
> > Hi,
> >
> > I would like to start the voting on KIP-471:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
> >
> > You can find the discussion here:
> >
> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
> >
> > Best,
> > Bruno
>


Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-19 Thread John Roesler
I'm +1 (nonbinding)

Thanks!
-John

On Tue, Jun 18, 2019 at 7:48 AM Bruno Cadonna  wrote:
>
> Hi,
>
> I would like to start the voting on KIP-471:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams
>
> You can find the discussion here:
> https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E
>
> Best,
> Bruno


[VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-18 Thread Bruno Cadonna
Hi,

I would like to start the voting on KIP-471:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-471%3A+Expose+RocksDB+Metrics+in+Kafka+Streams

You can find the discussion here:
https://lists.apache.org/thread.html/125bdd984fe0667962018da6ce10bce6d5895c5103955a8e4c730fef@%3Cdev.kafka.apache.org%3E

Best,
Bruno