Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Thanks everyone for the voting - the PR is now ready for review! https://github.com/apache/kafka/pull/7354 Cheers, Almog On Tue, Sep 17, 2019 at 12:56 PM Guozhang Wang wrote: > +1 (binding). > > Thanks Almog! > > Guozhang > > On Tue, Sep 17, 2019 at 11:56 AM Bill Bejeck wrote: > > > +1 (binding) > > > > On Tue, Sep 17, 2019 at 11:32 AM Matthias J. Sax > > wrote: > > > > > +1 (binding) > > > > > > -Matthias > > > > > > On 9/17/19 12:20 AM, Arjun Satish wrote: > > > > Thanks for the KIP, Almog. > > > > > > > > +1 (non-binding) > > > > > > > > On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch > > wrote: > > > > > > > >> Thanks for the nice improvement, Almog! > > > >> > > > >> +1 (binding) > > > >> > > > >> Randall > > > >> > > > >> On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < > > > >> konstant...@confluent.io> wrote: > > > >> > > > >>> Thanks Almog! > > > >>> Nicely designed and concise KIP. > > > >>> > > > >>> +1 non-binding > > > >>> > > > >>> Konstantine > > > >>> > > > >>> On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra > > > wrote: > > > >>> > > > Hello Everyone, > > > > > > After discussions on > > > > > > > > > >>> > > > >> > > > > > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > > > I've opened this KIP up for formal voting. > > > > > > KIP: > > > > > > > > > >>> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > > > > > Please update the DISCUSS thread with any concerns/comments. > > > > > > Cheers! > > > Almog > > > > > > >>> > > > >> > > > > > > > > > > > > > > > -- > -- Guozhang >
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
+1 (binding). Thanks Almog! Guozhang On Tue, Sep 17, 2019 at 11:56 AM Bill Bejeck wrote: > +1 (binding) > > On Tue, Sep 17, 2019 at 11:32 AM Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 9/17/19 12:20 AM, Arjun Satish wrote: > > > Thanks for the KIP, Almog. > > > > > > +1 (non-binding) > > > > > > On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch > wrote: > > > > > >> Thanks for the nice improvement, Almog! > > >> > > >> +1 (binding) > > >> > > >> Randall > > >> > > >> On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < > > >> konstant...@confluent.io> wrote: > > >> > > >>> Thanks Almog! > > >>> Nicely designed and concise KIP. > > >>> > > >>> +1 non-binding > > >>> > > >>> Konstantine > > >>> > > >>> On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra > > wrote: > > >>> > > Hello Everyone, > > > > After discussions on > > > > > > >>> > > >> > > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > > I've opened this KIP up for formal voting. > > > > KIP: > > > > > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > > > Please update the DISCUSS thread with any concerns/comments. > > > > Cheers! > > Almog > > > > >>> > > >> > > > > > > > > -- -- Guozhang
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Thanks everyone for the comments and discussion! Closing the voting out for this KIP and marking accepted: * 3 Binding (Randall, Matthias, Bill) * 2 Non-Binding (Arjun, Konstantine) Cheers, Almog On Tue, Sep 17, 2019 at 11:56 AM Bill Bejeck wrote: > +1 (binding) > > On Tue, Sep 17, 2019 at 11:32 AM Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 9/17/19 12:20 AM, Arjun Satish wrote: > > > Thanks for the KIP, Almog. > > > > > > +1 (non-binding) > > > > > > On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch > wrote: > > > > > >> Thanks for the nice improvement, Almog! > > >> > > >> +1 (binding) > > >> > > >> Randall > > >> > > >> On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < > > >> konstant...@confluent.io> wrote: > > >> > > >>> Thanks Almog! > > >>> Nicely designed and concise KIP. > > >>> > > >>> +1 non-binding > > >>> > > >>> Konstantine > > >>> > > >>> On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra > > wrote: > > >>> > > Hello Everyone, > > > > After discussions on > > > > > > >>> > > >> > > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > > I've opened this KIP up for formal voting. > > > > KIP: > > > > > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > > > Please update the DISCUSS thread with any concerns/comments. > > > > Cheers! > > Almog > > > > >>> > > >> > > > > > > > >
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
+1 (binding) On Tue, Sep 17, 2019 at 11:32 AM Matthias J. Sax wrote: > +1 (binding) > > -Matthias > > On 9/17/19 12:20 AM, Arjun Satish wrote: > > Thanks for the KIP, Almog. > > > > +1 (non-binding) > > > > On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch wrote: > > > >> Thanks for the nice improvement, Almog! > >> > >> +1 (binding) > >> > >> Randall > >> > >> On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < > >> konstant...@confluent.io> wrote: > >> > >>> Thanks Almog! > >>> Nicely designed and concise KIP. > >>> > >>> +1 non-binding > >>> > >>> Konstantine > >>> > >>> On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra > wrote: > >>> > Hello Everyone, > > After discussions on > > > >>> > >> > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > I've opened this KIP up for formal voting. > > KIP: > > > >>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > Please update the DISCUSS thread with any concerns/comments. > > Cheers! > Almog > > >>> > >> > > > >
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
+1 (binding) -Matthias On 9/17/19 12:20 AM, Arjun Satish wrote: > Thanks for the KIP, Almog. > > +1 (non-binding) > > On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch wrote: > >> Thanks for the nice improvement, Almog! >> >> +1 (binding) >> >> Randall >> >> On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < >> konstant...@confluent.io> wrote: >> >>> Thanks Almog! >>> Nicely designed and concise KIP. >>> >>> +1 non-binding >>> >>> Konstantine >>> >>> On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: >>> Hello Everyone, After discussions on >>> >> https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E I've opened this KIP up for formal voting. KIP: >>> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON Please update the DISCUSS thread with any concerns/comments. Cheers! Almog >>> >> > signature.asc Description: OpenPGP digital signature
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Thanks for the KIP, Almog. +1 (non-binding) On Mon, Sep 16, 2019 at 4:45 PM Randall Hauch wrote: > Thanks for the nice improvement, Almog! > > +1 (binding) > > Randall > > On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Thanks Almog! > > Nicely designed and concise KIP. > > > > +1 non-binding > > > > Konstantine > > > > On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: > > > > > Hello Everyone, > > > > > > After discussions on > > > > > > > > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > > > I've opened this KIP up for formal voting. > > > > > > KIP: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > > > > > Please update the DISCUSS thread with any concerns/comments. > > > > > > Cheers! > > > Almog > > > > > >
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Thanks for the nice improvement, Almog! +1 (binding) Randall On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Thanks Almog! > Nicely designed and concise KIP. > > +1 non-binding > > Konstantine > > On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: > > > Hello Everyone, > > > > After discussions on > > > > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > > I've opened this KIP up for formal voting. > > > > KIP: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > > > Please update the DISCUSS thread with any concerns/comments. > > > > Cheers! > > Almog > > >
Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Thanks Almog! Nicely designed and concise KIP. +1 non-binding Konstantine On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote: > Hello Everyone, > > After discussions on > > https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E > I've opened this KIP up for formal voting. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON > > Please update the DISCUSS thread with any concerns/comments. > > Cheers! > Almog >
[VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON
Hello Everyone, After discussions on https://lists.apache.org/thread.html/fa665a6dc59f73ca294a00bcbef2eaa3ad00cc69626e91c516fa4fca@%3Cdev.kafka.apache.org%3E I've opened this KIP up for formal voting. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-481%3A+SerDe+Improvements+for+Connect+Decimal+type+in+JSON Please update the DISCUSS thread with any concerns/comments. Cheers! Almog
