Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi all, Thanks for participating. The feedback was really useful. I'm closing this vote with three binding +1 and zero -1 votes. Binding +1: — Bruno — Guozhang — Sophie Non-Binding +1: — Myself I hope I closed the vote the right way. Let me know if something I did was not correct. I'll start with the implementation. Best, ——— Josep Prat Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491715557497 w: aiven.io e: josep.p...@aiven.io On Mon, Jun 7, 2021, 22:38 Sophie Blee-Goldman wrote: > Thanks for the KIP! +1 (binding) > > -Sophie > > On Mon, Jun 7, 2021 at 11:19 AM Guozhang Wang wrote: > > > Thanks, that update LGTM. +1! > > > > Guozhang > > > > On Mon, Jun 7, 2021 at 9:45 AM Josep Prat > > wrote: > > > > > Hi Guozhang, > > > Let me know if the updated KIP meets your requests. And thanks again > for > > > your feedback! > > > > > > Thanks, > > > > > > On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > > > > > > > Done, KIP is now updated to reflect this. > > > > > > > > On Sat, Jun 5, 2021 at 4:29 PM Josep Prat > wrote: > > > > > > > >> Hi Guozhang, > > > >> > > > >> Thanks for your review, let's exclude the "localThreadsMetadata > > > returning > > > >> StreamsMetadata" change then. This way, as well, this KIP is > > completely > > > >> consistent on making those Metadata classes interfaces with internal > > > >> implementations. > > > >> I'll update the KIP document right away. > > > >> > > > >> Thanks for replying on Saturday :) > > > >> > > > >> On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang > > > wrote: > > > >> > > > >>> Hi Josep, > > > >>> > > > >>> I think the most significant change would be, > "localThreadsMetadata" > > > >>> returns a StreamsMetadata instead of ThreadMetadata, and > > > StreamsMetadata > > > >>> would expose a new API to return a set of ThreadMetadata. > > > >>> > > > >>> All others (including the repackaging and splitting of interface / > > > impl) > > > >>> are minor indeed. > > > >>> > > > >>> After a second thought, I feel it is not fair to squeeze in this > > > >>> significant change into your KIP, without the community having a > > > >>> separating > > > >>> discussion about it, so I think we can table it for now and only > > align > > > on > > > >>> the other minor things: 1) have a o.a.k.streams.StreamsMetadata > > > interface > > > >>> (along with an internal implementation class), 2) deprecate the > > > >>> o.a.k.streams.state.StreamsMetadata class and also the > corresponding > > > >>> caller > > > >>> of Streams that returns this class. > > > >>> > > > >>> Guozhang > > > >>> > > > >>> On Fri, Jun 4, 2021 at 4:13 PM Josep Prat > > > > > > > > >>> wrote: > > > >>> > > > >>> > Hi Guozhang, > > > >>> > So if I understand correctly, it's only a couple of small changes > > > that > > > >>> need > > > >>> > to be made to this KIP to be aligned with KAFKA-12370, right? > > > >>> > > > > >>> > I'm guessing that StreamsMetadata would not only moved to > > > >>> o.a.k.streams but > > > >>> > also be split with Interface + internal implementation, am I > right? > > > >>> > > > > >>> > > > > >>> > If that's the case, I could, most probably, update the KIP by > > > Saturday > > > >>> > afternoon CEST. > > > >>> > > > > >>> > Let me know if I understood you correctly. > > > >>> > > > > >>> > Thanks for the comments! > > > >>> > > > > >>> > ——— > > > >>> > Josep Prat > > > >>> > > > > >>> > Aiven Deutschland GmbH > > > >>> > > > > >>> > Immanuelkirchstraße 26, 10405 Berlin > > > >>> > > > > >>> > Amtsgericht Charlottenburg, HRB 209739 B > > > >>> > > > > >>> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > >>> > > > > >>> > m: +491715557497 > > > >>> > > > > >>> > w: aiven.io > > > >>> > > > > >>> > e: josep.p...@aiven.io > > > >>> > > > > >>> > On Sat, Jun 5, 2021, 00:11 Guozhang Wang > > wrote: > > > >>> > > > > >>> > > Hello Josep, > > > >>> > > > > > >>> > > Thanks for the proposal! The write-up looks good to me in > > general. > > > >>> I'm > > > >>> > just > > > >>> > > wondering if you feel comfortable to align this with another > > > JIRA/KIP > > > >>> > > further down the road: > > > >>> > > > > > >>> > > https://issues.apache.org/jira/browse/KAFKA-12370 > > > >>> > > > > > >>> > > Which tries to clean up the metadata hierarchy and the callers > as > > > >>> > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most > > Streams > > > >>> APIs > > > >>> > > return the top-level StreamsMetadata. > > > >>> > > > > > >>> > > It just have slight differences with the current proposal: 1) > > > >>> instead of > > > >>> > > returning a ThreadMetadata, "localThreadsMetadata" returns > > > >>> > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be > > moved > > > >>> from > > > >>> > > o.a.k.streams.state to o.a.k.streams. > > > >>> > > > > > >>> > > What do you think about this? It's totally okay if you are not > > > >>> > comforta
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Thanks for the KIP! +1 (binding) -Sophie On Mon, Jun 7, 2021 at 11:19 AM Guozhang Wang wrote: > Thanks, that update LGTM. +1! > > Guozhang > > On Mon, Jun 7, 2021 at 9:45 AM Josep Prat > wrote: > > > Hi Guozhang, > > Let me know if the updated KIP meets your requests. And thanks again for > > your feedback! > > > > Thanks, > > > > On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > > > > > Done, KIP is now updated to reflect this. > > > > > > On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > > > > > >> Hi Guozhang, > > >> > > >> Thanks for your review, let's exclude the "localThreadsMetadata > > returning > > >> StreamsMetadata" change then. This way, as well, this KIP is > completely > > >> consistent on making those Metadata classes interfaces with internal > > >> implementations. > > >> I'll update the KIP document right away. > > >> > > >> Thanks for replying on Saturday :) > > >> > > >> On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang > > wrote: > > >> > > >>> Hi Josep, > > >>> > > >>> I think the most significant change would be, "localThreadsMetadata" > > >>> returns a StreamsMetadata instead of ThreadMetadata, and > > StreamsMetadata > > >>> would expose a new API to return a set of ThreadMetadata. > > >>> > > >>> All others (including the repackaging and splitting of interface / > > impl) > > >>> are minor indeed. > > >>> > > >>> After a second thought, I feel it is not fair to squeeze in this > > >>> significant change into your KIP, without the community having a > > >>> separating > > >>> discussion about it, so I think we can table it for now and only > align > > on > > >>> the other minor things: 1) have a o.a.k.streams.StreamsMetadata > > interface > > >>> (along with an internal implementation class), 2) deprecate the > > >>> o.a.k.streams.state.StreamsMetadata class and also the corresponding > > >>> caller > > >>> of Streams that returns this class. > > >>> > > >>> Guozhang > > >>> > > >>> On Fri, Jun 4, 2021 at 4:13 PM Josep Prat > > > > > >>> wrote: > > >>> > > >>> > Hi Guozhang, > > >>> > So if I understand correctly, it's only a couple of small changes > > that > > >>> need > > >>> > to be made to this KIP to be aligned with KAFKA-12370, right? > > >>> > > > >>> > I'm guessing that StreamsMetadata would not only moved to > > >>> o.a.k.streams but > > >>> > also be split with Interface + internal implementation, am I right? > > >>> > > > >>> > > > >>> > If that's the case, I could, most probably, update the KIP by > > Saturday > > >>> > afternoon CEST. > > >>> > > > >>> > Let me know if I understood you correctly. > > >>> > > > >>> > Thanks for the comments! > > >>> > > > >>> > ——— > > >>> > Josep Prat > > >>> > > > >>> > Aiven Deutschland GmbH > > >>> > > > >>> > Immanuelkirchstraße 26, 10405 Berlin > > >>> > > > >>> > Amtsgericht Charlottenburg, HRB 209739 B > > >>> > > > >>> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > >>> > > > >>> > m: +491715557497 > > >>> > > > >>> > w: aiven.io > > >>> > > > >>> > e: josep.p...@aiven.io > > >>> > > > >>> > On Sat, Jun 5, 2021, 00:11 Guozhang Wang > wrote: > > >>> > > > >>> > > Hello Josep, > > >>> > > > > >>> > > Thanks for the proposal! The write-up looks good to me in > general. > > >>> I'm > > >>> > just > > >>> > > wondering if you feel comfortable to align this with another > > JIRA/KIP > > >>> > > further down the road: > > >>> > > > > >>> > > https://issues.apache.org/jira/browse/KAFKA-12370 > > >>> > > > > >>> > > Which tries to clean up the metadata hierarchy and the callers as > > >>> > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most > Streams > > >>> APIs > > >>> > > return the top-level StreamsMetadata. > > >>> > > > > >>> > > It just have slight differences with the current proposal: 1) > > >>> instead of > > >>> > > returning a ThreadMetadata, "localThreadsMetadata" returns > > >>> > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be > moved > > >>> from > > >>> > > o.a.k.streams.state to o.a.k.streams. > > >>> > > > > >>> > > What do you think about this? It's totally okay if you are not > > >>> > comfortable > > >>> > > changing or expanding the scope of this KIP, that's totally fine > > >>> with me > > >>> > as > > >>> > > well, and we can just change again in the future if necessary --- > > >>> just > > >>> > > trying to see if we can align the direction on the first shot > here > > :) > > >>> > > > > >>> > > > > >>> > > Guozhang > > >>> > > > > >>> > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna > > > >>> wrote: > > >>> > > > > >>> > > > Thanks, Josep! > > >>> > > > > > >>> > > > +1 (binding) > > >>> > > > > > >>> > > > Bruno > > >>> > > > > > >>> > > > On 04.06.21 10:27, Josep Prat wrote: > > >>> > > > > Hi all, > > >>> > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata > > and > > >>> > > > > ThreadMetadata to an interface with internal implementation > > >>> > > > > KIP page can be found here: > > >>> > > https://cwiki.apache.org/confluence/x/XIrOCg > > >>> >
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Thanks, that update LGTM. +1! Guozhang On Mon, Jun 7, 2021 at 9:45 AM Josep Prat wrote: > Hi Guozhang, > Let me know if the updated KIP meets your requests. And thanks again for > your feedback! > > Thanks, > > On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > > > Done, KIP is now updated to reflect this. > > > > On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > > > >> Hi Guozhang, > >> > >> Thanks for your review, let's exclude the "localThreadsMetadata > returning > >> StreamsMetadata" change then. This way, as well, this KIP is completely > >> consistent on making those Metadata classes interfaces with internal > >> implementations. > >> I'll update the KIP document right away. > >> > >> Thanks for replying on Saturday :) > >> > >> On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang > wrote: > >> > >>> Hi Josep, > >>> > >>> I think the most significant change would be, "localThreadsMetadata" > >>> returns a StreamsMetadata instead of ThreadMetadata, and > StreamsMetadata > >>> would expose a new API to return a set of ThreadMetadata. > >>> > >>> All others (including the repackaging and splitting of interface / > impl) > >>> are minor indeed. > >>> > >>> After a second thought, I feel it is not fair to squeeze in this > >>> significant change into your KIP, without the community having a > >>> separating > >>> discussion about it, so I think we can table it for now and only align > on > >>> the other minor things: 1) have a o.a.k.streams.StreamsMetadata > interface > >>> (along with an internal implementation class), 2) deprecate the > >>> o.a.k.streams.state.StreamsMetadata class and also the corresponding > >>> caller > >>> of Streams that returns this class. > >>> > >>> Guozhang > >>> > >>> On Fri, Jun 4, 2021 at 4:13 PM Josep Prat > > >>> wrote: > >>> > >>> > Hi Guozhang, > >>> > So if I understand correctly, it's only a couple of small changes > that > >>> need > >>> > to be made to this KIP to be aligned with KAFKA-12370, right? > >>> > > >>> > I'm guessing that StreamsMetadata would not only moved to > >>> o.a.k.streams but > >>> > also be split with Interface + internal implementation, am I right? > >>> > > >>> > > >>> > If that's the case, I could, most probably, update the KIP by > Saturday > >>> > afternoon CEST. > >>> > > >>> > Let me know if I understood you correctly. > >>> > > >>> > Thanks for the comments! > >>> > > >>> > ——— > >>> > Josep Prat > >>> > > >>> > Aiven Deutschland GmbH > >>> > > >>> > Immanuelkirchstraße 26, 10405 Berlin > >>> > > >>> > Amtsgericht Charlottenburg, HRB 209739 B > >>> > > >>> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > >>> > > >>> > m: +491715557497 > >>> > > >>> > w: aiven.io > >>> > > >>> > e: josep.p...@aiven.io > >>> > > >>> > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > >>> > > >>> > > Hello Josep, > >>> > > > >>> > > Thanks for the proposal! The write-up looks good to me in general. > >>> I'm > >>> > just > >>> > > wondering if you feel comfortable to align this with another > JIRA/KIP > >>> > > further down the road: > >>> > > > >>> > > https://issues.apache.org/jira/browse/KAFKA-12370 > >>> > > > >>> > > Which tries to clean up the metadata hierarchy and the callers as > >>> > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams > >>> APIs > >>> > > return the top-level StreamsMetadata. > >>> > > > >>> > > It just have slight differences with the current proposal: 1) > >>> instead of > >>> > > returning a ThreadMetadata, "localThreadsMetadata" returns > >>> > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved > >>> from > >>> > > o.a.k.streams.state to o.a.k.streams. > >>> > > > >>> > > What do you think about this? It's totally okay if you are not > >>> > comfortable > >>> > > changing or expanding the scope of this KIP, that's totally fine > >>> with me > >>> > as > >>> > > well, and we can just change again in the future if necessary --- > >>> just > >>> > > trying to see if we can align the direction on the first shot here > :) > >>> > > > >>> > > > >>> > > Guozhang > >>> > > > >>> > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna > >>> wrote: > >>> > > > >>> > > > Thanks, Josep! > >>> > > > > >>> > > > +1 (binding) > >>> > > > > >>> > > > Bruno > >>> > > > > >>> > > > On 04.06.21 10:27, Josep Prat wrote: > >>> > > > > Hi all, > >>> > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata > and > >>> > > > > ThreadMetadata to an interface with internal implementation > >>> > > > > KIP page can be found here: > >>> > > https://cwiki.apache.org/confluence/x/XIrOCg > >>> > > > > Discussion thread can be found here: > >>> > > > > > >>> > > > > >>> > > > >>> > > >>> > https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E > >>> > > > > > >>> > > > > As it was pointed out, hopefully this KIP can be approved > before > >>> the > >>> > > 3.0 > >>> > > > > deadline, as we can clean up some non naming compliant methods > >
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi Guozhang, Let me know if the updated KIP meets your requests. And thanks again for your feedback! Thanks, On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > Done, KIP is now updated to reflect this. > > On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > >> Hi Guozhang, >> >> Thanks for your review, let's exclude the "localThreadsMetadata returning >> StreamsMetadata" change then. This way, as well, this KIP is completely >> consistent on making those Metadata classes interfaces with internal >> implementations. >> I'll update the KIP document right away. >> >> Thanks for replying on Saturday :) >> >> On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang wrote: >> >>> Hi Josep, >>> >>> I think the most significant change would be, "localThreadsMetadata" >>> returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata >>> would expose a new API to return a set of ThreadMetadata. >>> >>> All others (including the repackaging and splitting of interface / impl) >>> are minor indeed. >>> >>> After a second thought, I feel it is not fair to squeeze in this >>> significant change into your KIP, without the community having a >>> separating >>> discussion about it, so I think we can table it for now and only align on >>> the other minor things: 1) have a o.a.k.streams.StreamsMetadata interface >>> (along with an internal implementation class), 2) deprecate the >>> o.a.k.streams.state.StreamsMetadata class and also the corresponding >>> caller >>> of Streams that returns this class. >>> >>> Guozhang >>> >>> On Fri, Jun 4, 2021 at 4:13 PM Josep Prat >>> wrote: >>> >>> > Hi Guozhang, >>> > So if I understand correctly, it's only a couple of small changes that >>> need >>> > to be made to this KIP to be aligned with KAFKA-12370, right? >>> > >>> > I'm guessing that StreamsMetadata would not only moved to >>> o.a.k.streams but >>> > also be split with Interface + internal implementation, am I right? >>> > >>> > >>> > If that's the case, I could, most probably, update the KIP by Saturday >>> > afternoon CEST. >>> > >>> > Let me know if I understood you correctly. >>> > >>> > Thanks for the comments! >>> > >>> > ——— >>> > Josep Prat >>> > >>> > Aiven Deutschland GmbH >>> > >>> > Immanuelkirchstraße 26, 10405 Berlin >>> > >>> > Amtsgericht Charlottenburg, HRB 209739 B >>> > >>> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >>> > >>> > m: +491715557497 >>> > >>> > w: aiven.io >>> > >>> > e: josep.p...@aiven.io >>> > >>> > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: >>> > >>> > > Hello Josep, >>> > > >>> > > Thanks for the proposal! The write-up looks good to me in general. >>> I'm >>> > just >>> > > wondering if you feel comfortable to align this with another JIRA/KIP >>> > > further down the road: >>> > > >>> > > https://issues.apache.org/jira/browse/KAFKA-12370 >>> > > >>> > > Which tries to clean up the metadata hierarchy and the callers as >>> > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams >>> APIs >>> > > return the top-level StreamsMetadata. >>> > > >>> > > It just have slight differences with the current proposal: 1) >>> instead of >>> > > returning a ThreadMetadata, "localThreadsMetadata" returns >>> > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved >>> from >>> > > o.a.k.streams.state to o.a.k.streams. >>> > > >>> > > What do you think about this? It's totally okay if you are not >>> > comfortable >>> > > changing or expanding the scope of this KIP, that's totally fine >>> with me >>> > as >>> > > well, and we can just change again in the future if necessary --- >>> just >>> > > trying to see if we can align the direction on the first shot here :) >>> > > >>> > > >>> > > Guozhang >>> > > >>> > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna >>> wrote: >>> > > >>> > > > Thanks, Josep! >>> > > > >>> > > > +1 (binding) >>> > > > >>> > > > Bruno >>> > > > >>> > > > On 04.06.21 10:27, Josep Prat wrote: >>> > > > > Hi all, >>> > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and >>> > > > > ThreadMetadata to an interface with internal implementation >>> > > > > KIP page can be found here: >>> > > https://cwiki.apache.org/confluence/x/XIrOCg >>> > > > > Discussion thread can be found here: >>> > > > > >>> > > > >>> > > >>> > >>> https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E >>> > > > > >>> > > > > As it was pointed out, hopefully this KIP can be approved before >>> the >>> > > 3.0 >>> > > > > deadline, as we can clean up some non naming compliant methods >>> > recently >>> > > > > introduced. >>> > > > > >>> > > > > >>> > > > > Please note that the scope of the KIP increased during the >>> discussion >>> > > to >>> > > > > also include ThreadMetadata. >>> > > > > >>> > > > > Thank you, >>> > > > > >>> > > > >>> > > >>> > > >>> > > -- >>> > > -- Guozhang >>> > > >>> > >>> >>> >>> -- >>> -- Guozhang >>> >> >> >> -- >> >> Josep Prat >> >> *Aiven Deutschland
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Done, KIP is now updated to reflect this. On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > Hi Guozhang, > > Thanks for your review, let's exclude the "localThreadsMetadata returning > StreamsMetadata" change then. This way, as well, this KIP is completely > consistent on making those Metadata classes interfaces with internal > implementations. > I'll update the KIP document right away. > > Thanks for replying on Saturday :) > > On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang wrote: > >> Hi Josep, >> >> I think the most significant change would be, "localThreadsMetadata" >> returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata >> would expose a new API to return a set of ThreadMetadata. >> >> All others (including the repackaging and splitting of interface / impl) >> are minor indeed. >> >> After a second thought, I feel it is not fair to squeeze in this >> significant change into your KIP, without the community having a >> separating >> discussion about it, so I think we can table it for now and only align on >> the other minor things: 1) have a o.a.k.streams.StreamsMetadata interface >> (along with an internal implementation class), 2) deprecate the >> o.a.k.streams.state.StreamsMetadata class and also the corresponding >> caller >> of Streams that returns this class. >> >> Guozhang >> >> On Fri, Jun 4, 2021 at 4:13 PM Josep Prat >> wrote: >> >> > Hi Guozhang, >> > So if I understand correctly, it's only a couple of small changes that >> need >> > to be made to this KIP to be aligned with KAFKA-12370, right? >> > >> > I'm guessing that StreamsMetadata would not only moved to o.a.k.streams >> but >> > also be split with Interface + internal implementation, am I right? >> > >> > >> > If that's the case, I could, most probably, update the KIP by Saturday >> > afternoon CEST. >> > >> > Let me know if I understood you correctly. >> > >> > Thanks for the comments! >> > >> > ——— >> > Josep Prat >> > >> > Aiven Deutschland GmbH >> > >> > Immanuelkirchstraße 26, 10405 Berlin >> > >> > Amtsgericht Charlottenburg, HRB 209739 B >> > >> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> > >> > m: +491715557497 >> > >> > w: aiven.io >> > >> > e: josep.p...@aiven.io >> > >> > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: >> > >> > > Hello Josep, >> > > >> > > Thanks for the proposal! The write-up looks good to me in general. I'm >> > just >> > > wondering if you feel comfortable to align this with another JIRA/KIP >> > > further down the road: >> > > >> > > https://issues.apache.org/jira/browse/KAFKA-12370 >> > > >> > > Which tries to clean up the metadata hierarchy and the callers as >> > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams >> APIs >> > > return the top-level StreamsMetadata. >> > > >> > > It just have slight differences with the current proposal: 1) instead >> of >> > > returning a ThreadMetadata, "localThreadsMetadata" returns >> > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved >> from >> > > o.a.k.streams.state to o.a.k.streams. >> > > >> > > What do you think about this? It's totally okay if you are not >> > comfortable >> > > changing or expanding the scope of this KIP, that's totally fine with >> me >> > as >> > > well, and we can just change again in the future if necessary --- just >> > > trying to see if we can align the direction on the first shot here :) >> > > >> > > >> > > Guozhang >> > > >> > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna >> wrote: >> > > >> > > > Thanks, Josep! >> > > > >> > > > +1 (binding) >> > > > >> > > > Bruno >> > > > >> > > > On 04.06.21 10:27, Josep Prat wrote: >> > > > > Hi all, >> > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and >> > > > > ThreadMetadata to an interface with internal implementation >> > > > > KIP page can be found here: >> > > https://cwiki.apache.org/confluence/x/XIrOCg >> > > > > Discussion thread can be found here: >> > > > > >> > > > >> > > >> > >> https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E >> > > > > >> > > > > As it was pointed out, hopefully this KIP can be approved before >> the >> > > 3.0 >> > > > > deadline, as we can clean up some non naming compliant methods >> > recently >> > > > > introduced. >> > > > > >> > > > > >> > > > > Please note that the scope of the KIP increased during the >> discussion >> > > to >> > > > > also include ThreadMetadata. >> > > > > >> > > > > Thank you, >> > > > > >> > > > >> > > >> > > >> > > -- >> > > -- Guozhang >> > > >> > >> >> >> -- >> -- Guozhang >> > > > -- > > Josep Prat > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491715557497 > > *w:* aiven.io > > *e:* josep.p...@aiven.io > -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 20
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi Guozhang, Thanks for your review, let's exclude the "localThreadsMetadata returning StreamsMetadata" change then. This way, as well, this KIP is completely consistent on making those Metadata classes interfaces with internal implementations. I'll update the KIP document right away. Thanks for replying on Saturday :) On Sat, Jun 5, 2021 at 4:22 PM Guozhang Wang wrote: > Hi Josep, > > I think the most significant change would be, "localThreadsMetadata" > returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata > would expose a new API to return a set of ThreadMetadata. > > All others (including the repackaging and splitting of interface / impl) > are minor indeed. > > After a second thought, I feel it is not fair to squeeze in this > significant change into your KIP, without the community having a separating > discussion about it, so I think we can table it for now and only align on > the other minor things: 1) have a o.a.k.streams.StreamsMetadata interface > (along with an internal implementation class), 2) deprecate the > o.a.k.streams.state.StreamsMetadata class and also the corresponding caller > of Streams that returns this class. > > Guozhang > > On Fri, Jun 4, 2021 at 4:13 PM Josep Prat > wrote: > > > Hi Guozhang, > > So if I understand correctly, it's only a couple of small changes that > need > > to be made to this KIP to be aligned with KAFKA-12370, right? > > > > I'm guessing that StreamsMetadata would not only moved to o.a.k.streams > but > > also be split with Interface + internal implementation, am I right? > > > > > > If that's the case, I could, most probably, update the KIP by Saturday > > afternoon CEST. > > > > Let me know if I understood you correctly. > > > > Thanks for the comments! > > > > ——— > > Josep Prat > > > > Aiven Deutschland GmbH > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > m: +491715557497 > > > > w: aiven.io > > > > e: josep.p...@aiven.io > > > > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > > > > > Hello Josep, > > > > > > Thanks for the proposal! The write-up looks good to me in general. I'm > > just > > > wondering if you feel comfortable to align this with another JIRA/KIP > > > further down the road: > > > > > > https://issues.apache.org/jira/browse/KAFKA-12370 > > > > > > Which tries to clean up the metadata hierarchy and the callers as > > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams > APIs > > > return the top-level StreamsMetadata. > > > > > > It just have slight differences with the current proposal: 1) instead > of > > > returning a ThreadMetadata, "localThreadsMetadata" returns > > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved > from > > > o.a.k.streams.state to o.a.k.streams. > > > > > > What do you think about this? It's totally okay if you are not > > comfortable > > > changing or expanding the scope of this KIP, that's totally fine with > me > > as > > > well, and we can just change again in the future if necessary --- just > > > trying to see if we can align the direction on the first shot here :) > > > > > > > > > Guozhang > > > > > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna > wrote: > > > > > > > Thanks, Josep! > > > > > > > > +1 (binding) > > > > > > > > Bruno > > > > > > > > On 04.06.21 10:27, Josep Prat wrote: > > > > > Hi all, > > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and > > > > > ThreadMetadata to an interface with internal implementation > > > > > KIP page can be found here: > > > https://cwiki.apache.org/confluence/x/XIrOCg > > > > > Discussion thread can be found here: > > > > > > > > > > > > > > > https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E > > > > > > > > > > As it was pointed out, hopefully this KIP can be approved before > the > > > 3.0 > > > > > deadline, as we can clean up some non naming compliant methods > > recently > > > > > introduced. > > > > > > > > > > > > > > > Please note that the scope of the KIP increased during the > discussion > > > to > > > > > also include ThreadMetadata. > > > > > > > > > > Thank you, > > > > > > > > > > > > > > > > > > -- > > > -- Guozhang > > > > > > > > -- > -- Guozhang > -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491715557497 *w:* aiven.io *e:* josep.p...@aiven.io
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi Josep, I think the most significant change would be, "localThreadsMetadata" returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata would expose a new API to return a set of ThreadMetadata. All others (including the repackaging and splitting of interface / impl) are minor indeed. After a second thought, I feel it is not fair to squeeze in this significant change into your KIP, without the community having a separating discussion about it, so I think we can table it for now and only align on the other minor things: 1) have a o.a.k.streams.StreamsMetadata interface (along with an internal implementation class), 2) deprecate the o.a.k.streams.state.StreamsMetadata class and also the corresponding caller of Streams that returns this class. Guozhang On Fri, Jun 4, 2021 at 4:13 PM Josep Prat wrote: > Hi Guozhang, > So if I understand correctly, it's only a couple of small changes that need > to be made to this KIP to be aligned with KAFKA-12370, right? > > I'm guessing that StreamsMetadata would not only moved to o.a.k.streams but > also be split with Interface + internal implementation, am I right? > > > If that's the case, I could, most probably, update the KIP by Saturday > afternoon CEST. > > Let me know if I understood you correctly. > > Thanks for the comments! > > ——— > Josep Prat > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491715557497 > > w: aiven.io > > e: josep.p...@aiven.io > > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > > > Hello Josep, > > > > Thanks for the proposal! The write-up looks good to me in general. I'm > just > > wondering if you feel comfortable to align this with another JIRA/KIP > > further down the road: > > > > https://issues.apache.org/jira/browse/KAFKA-12370 > > > > Which tries to clean up the metadata hierarchy and the callers as > > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams APIs > > return the top-level StreamsMetadata. > > > > It just have slight differences with the current proposal: 1) instead of > > returning a ThreadMetadata, "localThreadsMetadata" returns > > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved from > > o.a.k.streams.state to o.a.k.streams. > > > > What do you think about this? It's totally okay if you are not > comfortable > > changing or expanding the scope of this KIP, that's totally fine with me > as > > well, and we can just change again in the future if necessary --- just > > trying to see if we can align the direction on the first shot here :) > > > > > > Guozhang > > > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna wrote: > > > > > Thanks, Josep! > > > > > > +1 (binding) > > > > > > Bruno > > > > > > On 04.06.21 10:27, Josep Prat wrote: > > > > Hi all, > > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and > > > > ThreadMetadata to an interface with internal implementation > > > > KIP page can be found here: > > https://cwiki.apache.org/confluence/x/XIrOCg > > > > Discussion thread can be found here: > > > > > > > > > > https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E > > > > > > > > As it was pointed out, hopefully this KIP can be approved before the > > 3.0 > > > > deadline, as we can clean up some non naming compliant methods > recently > > > > introduced. > > > > > > > > > > > > Please note that the scope of the KIP increased during the discussion > > to > > > > also include ThreadMetadata. > > > > > > > > Thank you, > > > > > > > > > > > > > -- > > -- Guozhang > > > -- -- Guozhang
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
A summary of the changes from previous version can be seen under Public Interfaces --> UPDATE On Sat, Jun 5, 2021 at 1:39 PM Josep Prat wrote: > Hi Guozhang, > I updated the KIP with, but I'm not so sure about your point 1, as from > the user's perspective, the API available to them will be really different. > If you think it's fine to introduce this change for the users, I'm happy to > do that. If not, I can revert my KIP to remove your point 1). > > Link to the updated KIP: https://cwiki.apache.org/confluence/x/XIrOCg > > I don't know what's customary in these cases regarding the VOTE and > DISCUSS mail threads. Just in case, I will copy the e-mail exchange with a > link to this thread into the DISCUSS thread. > > > > On Sat, Jun 5, 2021 at 12:59 AM Josep Prat wrote: > >> Hi Guozhang, >> So if I understand correctly, it's only a couple of small changes that >> need to be made to this KIP to be aligned with KAFKA-12370, right? >> >> I'm guessing that StreamsMetadata would not only moved to o.a.k.streams >> but also be split with Interface + internal implementation, am I right? >> >> >> If that's the case, I could, most probably, update the KIP by Saturday >> afternoon CEST. >> >> Let me know if I understood you correctly. >> >> Thanks for the comments! >> >> ——— >> Josep Prat >> >> Aiven Deutschland GmbH >> >> Immanuelkirchstraße 26, 10405 Berlin >> >> Amtsgericht Charlottenburg, HRB 209739 B >> >> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> >> m: +491715557497 >> >> w: aiven.io >> >> e: josep.p...@aiven.io >> >> On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: >> >>> Hello Josep, >>> >>> Thanks for the proposal! The write-up looks good to me in general. I'm >>> just >>> wondering if you feel comfortable to align this with another JIRA/KIP >>> further down the road: >>> >>> https://issues.apache.org/jira/browse/KAFKA-12370 >>> >>> Which tries to clean up the metadata hierarchy and the callers as >>> StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams APIs >>> return the top-level StreamsMetadata. >>> >>> It just have slight differences with the current proposal: 1) instead of >>> returning a ThreadMetadata, "localThreadsMetadata" returns >>> a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved from >>> o.a.k.streams.state to o.a.k.streams. >>> >>> What do you think about this? It's totally okay if you are not >>> comfortable >>> changing or expanding the scope of this KIP, that's totally fine with me >>> as >>> well, and we can just change again in the future if necessary --- just >>> trying to see if we can align the direction on the first shot here :) >>> >>> >>> Guozhang >>> >>> On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna wrote: >>> >>> > Thanks, Josep! >>> > >>> > +1 (binding) >>> > >>> > Bruno >>> > >>> > On 04.06.21 10:27, Josep Prat wrote: >>> > > Hi all, >>> > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and >>> > > ThreadMetadata to an interface with internal implementation >>> > > KIP page can be found here: >>> https://cwiki.apache.org/confluence/x/XIrOCg >>> > > Discussion thread can be found here: >>> > > >>> > >>> https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E >>> > > >>> > > As it was pointed out, hopefully this KIP can be approved before the >>> 3.0 >>> > > deadline, as we can clean up some non naming compliant methods >>> recently >>> > > introduced. >>> > > >>> > > >>> > > Please note that the scope of the KIP increased during the >>> discussion to >>> > > also include ThreadMetadata. >>> > > >>> > > Thank you, >>> > > >>> > >>> >>> >>> -- >>> -- Guozhang >>> >> > > -- > > Josep Prat > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491715557497 > > *w:* aiven.io > > *e:* josep.p...@aiven.io > -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491715557497 *w:* aiven.io *e:* josep.p...@aiven.io
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi Guozhang, I updated the KIP with, but I'm not so sure about your point 1, as from the user's perspective, the API available to them will be really different. If you think it's fine to introduce this change for the users, I'm happy to do that. If not, I can revert my KIP to remove your point 1). Link to the updated KIP: https://cwiki.apache.org/confluence/x/XIrOCg I don't know what's customary in these cases regarding the VOTE and DISCUSS mail threads. Just in case, I will copy the e-mail exchange with a link to this thread into the DISCUSS thread. On Sat, Jun 5, 2021 at 12:59 AM Josep Prat wrote: > Hi Guozhang, > So if I understand correctly, it's only a couple of small changes that > need to be made to this KIP to be aligned with KAFKA-12370, right? > > I'm guessing that StreamsMetadata would not only moved to o.a.k.streams > but also be split with Interface + internal implementation, am I right? > > > If that's the case, I could, most probably, update the KIP by Saturday > afternoon CEST. > > Let me know if I understood you correctly. > > Thanks for the comments! > > ——— > Josep Prat > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491715557497 > > w: aiven.io > > e: josep.p...@aiven.io > > On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > >> Hello Josep, >> >> Thanks for the proposal! The write-up looks good to me in general. I'm >> just >> wondering if you feel comfortable to align this with another JIRA/KIP >> further down the road: >> >> https://issues.apache.org/jira/browse/KAFKA-12370 >> >> Which tries to clean up the metadata hierarchy and the callers as >> StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams APIs >> return the top-level StreamsMetadata. >> >> It just have slight differences with the current proposal: 1) instead of >> returning a ThreadMetadata, "localThreadsMetadata" returns >> a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved from >> o.a.k.streams.state to o.a.k.streams. >> >> What do you think about this? It's totally okay if you are not comfortable >> changing or expanding the scope of this KIP, that's totally fine with me >> as >> well, and we can just change again in the future if necessary --- just >> trying to see if we can align the direction on the first shot here :) >> >> >> Guozhang >> >> On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna wrote: >> >> > Thanks, Josep! >> > >> > +1 (binding) >> > >> > Bruno >> > >> > On 04.06.21 10:27, Josep Prat wrote: >> > > Hi all, >> > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and >> > > ThreadMetadata to an interface with internal implementation >> > > KIP page can be found here: >> https://cwiki.apache.org/confluence/x/XIrOCg >> > > Discussion thread can be found here: >> > > >> > >> https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E >> > > >> > > As it was pointed out, hopefully this KIP can be approved before the >> 3.0 >> > > deadline, as we can clean up some non naming compliant methods >> recently >> > > introduced. >> > > >> > > >> > > Please note that the scope of the KIP increased during the discussion >> to >> > > also include ThreadMetadata. >> > > >> > > Thank you, >> > > >> > >> >> >> -- >> -- Guozhang >> > -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491715557497 *w:* aiven.io *e:* josep.p...@aiven.io
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi Guozhang, So if I understand correctly, it's only a couple of small changes that need to be made to this KIP to be aligned with KAFKA-12370, right? I'm guessing that StreamsMetadata would not only moved to o.a.k.streams but also be split with Interface + internal implementation, am I right? If that's the case, I could, most probably, update the KIP by Saturday afternoon CEST. Let me know if I understood you correctly. Thanks for the comments! ——— Josep Prat Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491715557497 w: aiven.io e: josep.p...@aiven.io On Sat, Jun 5, 2021, 00:11 Guozhang Wang wrote: > Hello Josep, > > Thanks for the proposal! The write-up looks good to me in general. I'm just > wondering if you feel comfortable to align this with another JIRA/KIP > further down the road: > > https://issues.apache.org/jira/browse/KAFKA-12370 > > Which tries to clean up the metadata hierarchy and the callers as > StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams APIs > return the top-level StreamsMetadata. > > It just have slight differences with the current proposal: 1) instead of > returning a ThreadMetadata, "localThreadsMetadata" returns > a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved from > o.a.k.streams.state to o.a.k.streams. > > What do you think about this? It's totally okay if you are not comfortable > changing or expanding the scope of this KIP, that's totally fine with me as > well, and we can just change again in the future if necessary --- just > trying to see if we can align the direction on the first shot here :) > > > Guozhang > > On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna wrote: > > > Thanks, Josep! > > > > +1 (binding) > > > > Bruno > > > > On 04.06.21 10:27, Josep Prat wrote: > > > Hi all, > > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and > > > ThreadMetadata to an interface with internal implementation > > > KIP page can be found here: > https://cwiki.apache.org/confluence/x/XIrOCg > > > Discussion thread can be found here: > > > > > > https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E > > > > > > As it was pointed out, hopefully this KIP can be approved before the > 3.0 > > > deadline, as we can clean up some non naming compliant methods recently > > > introduced. > > > > > > > > > Please note that the scope of the KIP increased during the discussion > to > > > also include ThreadMetadata. > > > > > > Thank you, > > > > > > > > -- > -- Guozhang >
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hello Josep, Thanks for the proposal! The write-up looks good to me in general. I'm just wondering if you feel comfortable to align this with another JIRA/KIP further down the road: https://issues.apache.org/jira/browse/KAFKA-12370 Which tries to clean up the metadata hierarchy and the callers as StreamsMetadata -> ThreadMetadata -> TaskMetadata, and most Streams APIs return the top-level StreamsMetadata. It just have slight differences with the current proposal: 1) instead of returning a ThreadMetadata, "localThreadsMetadata" returns a StreamsMetadata, and 2) the `StreamsMetadata` would also be moved from o.a.k.streams.state to o.a.k.streams. What do you think about this? It's totally okay if you are not comfortable changing or expanding the scope of this KIP, that's totally fine with me as well, and we can just change again in the future if necessary --- just trying to see if we can align the direction on the first shot here :) Guozhang On Fri, Jun 4, 2021 at 1:51 AM Bruno Cadonna wrote: > Thanks, Josep! > > +1 (binding) > > Bruno > > On 04.06.21 10:27, Josep Prat wrote: > > Hi all, > > I'd like to call for a vote on KIP-744: Migrate TaskMetadata and > > ThreadMetadata to an interface with internal implementation > > KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg > > Discussion thread can be found here: > > > https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E > > > > As it was pointed out, hopefully this KIP can be approved before the 3.0 > > deadline, as we can clean up some non naming compliant methods recently > > introduced. > > > > > > Please note that the scope of the KIP increased during the discussion to > > also include ThreadMetadata. > > > > Thank you, > > > -- -- Guozhang
Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Thanks, Josep! +1 (binding) Bruno On 04.06.21 10:27, Josep Prat wrote: Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion thread can be found here: https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E As it was pointed out, hopefully this KIP can be approved before the 3.0 deadline, as we can clean up some non naming compliant methods recently introduced. Please note that the scope of the KIP increased during the discussion to also include ThreadMetadata. Thank you,
[VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation
Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion thread can be found here: https://lists.apache.org/x/thread.html/r1d20fb6dbd6b01bb84cbb17e992f4d08308980dfc5f2e0a68d674413@%3Cdev.kafka.apache.org%3E As it was pointed out, hopefully this KIP can be approved before the 3.0 deadline, as we can clean up some non naming compliant methods recently introduced. Please note that the scope of the KIP increased during the discussion to also include ThreadMetadata. Thank you, -- Josep Prat *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491715557497 *w:* aiven.io *e:* josep.p...@aiven.io
