[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146365#comment-14146365 ] Joe Stein edited comment on KAFKA-1490 at 9/24/14 2:33 PM: --- A source release is meant for general public consumption and use and not just for developers. Technically speaking any version we put out is really about the source release the binaries are only an aid for folks that don't have the tools to make their own build from source http://www.apache.org/dev/release.html#what and http://www.apache.org/dev/release.html#what-must-every-release-contain Any chance of the core gradle team making the gradle-wrapper.jar hosted and signed and then it can get downloaded (and signatures checked) if not found? I think this would start to help wider adoption within apache projects and create a better uses experience for everyone always using gradle (assuming that approach satisfies apache requirements I believe it would best to get more Apache folks to verify that which we could do of course). Let me know if you can get that change going and I can kick a discussion off (having a link to your ticketing change would help drive it) to make sure it will be workable within the Apache foundation (prior to you doing the work). was (Author: joestein): A source release is meant for general public consumption and use and not just for developers. Technically speaking any version we put out is really about the source release the binaries are only an aid for folks that don't have the tools to make their own build from source http://www.apache.org/dev/release.html#what and http://www.apache.org/dev/release.html#what-must-every-release-contain Any chance of the core gradle team making the gradle-wrapper.jar hosted and signed and then it can get downloaded (and signatures checked) if not found? I think this would start to help wider adoption within apache projects and create a better uses experience for everyone always using gradle (assuming that approach satisfies apache requirements I believe it would best to get more Apache folks to verify that which we could do of course). Let me know if you can get that change going and I can kick a discussion off (having a link to your ticketing change would help drive it) to make sure it will be workable (prior to you doing the work). > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch, rb25703.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146289#comment-14146289 ] Joe Stein edited comment on KAFKA-1490 at 9/24/14 1:31 PM: --- Thanks [~szczepiq] for jumping in I think the current solution in any form for Apache projects is kludgy. :( Besides Samza I just checked and Aurora does it that way too (keeping jar files checked in but excluding from source release) but I am not sure that is better though. For source releases we have to exclude it and we will have to explain to folks they have to bootstrap (and they will ask). I feel like there would be less confusion and questions from folks using a source release if their experience with the repo is the same. My preference would be to not have to "bootstrap" at all. Maybe the gradle team could modify things so we could pull the wrapper jar first without it being there. Any chance of that? :) It seems like a legitimate ask since "source only releases" are such a big thing it is is kludgy now no matter where you cut it... this solution just makes it consistency kludgy. I think this solution favors consistency of how to interact with the repo and source release which leads to less community confusion. Also, the way we have always done releases https://cwiki.apache.org/confluence/display/KAFKA/Release+Process has been to copy the repository 1:1 for the source release. This means what is tagged is exactly what is in the source release. Technically speaking we could change that (of course) and create a source release task but not sure if we would want to-do that. If we decide to keep the jar in the repo we need to make sure the release manager has a way to create a source release differently than has been done before. was (Author: joestein): Thanks [~szczepiq] for jumping in I think the current solution in any form for Apache projects is kludgy. :( Besides Samza I just checked and Aurora does it that way too (keeping jar files checked in but excluding from source release) but I am not sure that is better though. For source releases we have to exclude it and we will have to explain to folks they have to bootstrap (and they will ask). I feel like there would be less confusion and questions from folks using a source release if their experience with the repo is the same. My preference would be to not have to "bootstrap" at all. Maybe the gradle team could modify things so we could pull the wrapper jar first without it being there. Any chance of that? :) It seems like a legitimate ask since "source only releases" are such a big thing it is is kludgy now no matter where you cut it... this solution just makes it consistency kludgy. I think this solution favors consistency of how to interact with the repo and source release which leads to less community confusion. > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch, rb25703.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145003#comment-14145003 ] Joe Stein edited comment on KAFKA-1490 at 9/23/14 4:46 PM: --- yup, thanks missed the git add, pushed the file now was (Author: joestein): yup, thanks missed the git add > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch, rb25703.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[
https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144953#comment-14144953
]
Joe Stein edited comment on KAFKA-1490 at 9/23/14 4:06 PM:
---
+1 committed to trunk, also minor update to readme
{code}
diff --git a/README.md b/README.md
index 18a65b1..8e50945 100644
--- a/README.md
+++ b/README.md
@@ -2,6 +2,13 @@ Apache Kafka
=
See our [web site](http://kafka.apache.org) for details on the project.
+You need to have [gradle](http://www.gradle.org/installation) installed.
+
+### First bootstrap and download the wrapper ###
+gradle
+
+Now everything else will work
+
### Building a jar and running it ###
./gradlew jar
{code}
was (Author: joestein):
+1 committed to trunk, also update minor updates to readme
{code}
diff --git a/README.md b/README.md
index 18a65b1..8e50945 100644
--- a/README.md
+++ b/README.md
@@ -2,6 +2,13 @@ Apache Kafka
=
See our [web site](http://kafka.apache.org) for details on the project.
+You need to have [gradle](http://www.gradle.org/installation) installed.
+
+### First bootstrap and download the wrapper ###
+gradle
+
+Now everything else will work
+
### Building a jar and running it ###
./gradlew jar
{code}
> remove gradlew initial setup output from source distribution
>
>
> Key: KAFKA-1490
> URL: https://issues.apache.org/jira/browse/KAFKA-1490
> Project: Kafka
> Issue Type: Bug
>Reporter: Joe Stein
>Assignee: Ivan Lyutov
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch, rb25703.patch
>
>
> Our current source releases contains lots of stuff in the gradle folder we do
> not need
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1490) remove gradlew initial setup output from source distribution
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135928#comment-14135928 ] Ivan Lyutov edited comment on KAFKA-1490 at 9/16/14 6:41 PM: - https://reviews.apache.org/r/25703/ was (Author: edgefox): https://reviews.apache.org/r/25697/ > remove gradlew initial setup output from source distribution > > > Key: KAFKA-1490 > URL: https://issues.apache.org/jira/browse/KAFKA-1490 > Project: Kafka > Issue Type: Bug >Reporter: Joe Stein >Assignee: Ivan Lyutov >Priority: Blocker > Fix For: 0.8.2 > > Attachments: KAFKA-1490-2.patch, KAFKA-1490.patch > > > Our current source releases contains lots of stuff in the gradle folder we do > not need -- This message was sent by Atlassian JIRA (v6.3.4#6332)
