[jira] [Comment Edited] (KAFKA-1535) return all live brokers in TopicMetadataResponse
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061766#comment-14061766 ] Nicolae Marasoiu edited comment on KAFKA-1535 at 7/15/14 6:46 AM: -- Which branch should this be done on? Seems trunk == 0.9.0 Should this be done in the "default" branch 0.8.1 ? was (Author: nmarasoiu): Which branch should this be done on? trunk? > return all live brokers in TopicMetadataResponse > > > Key: KAFKA-1535 > URL: https://issues.apache.org/jira/browse/KAFKA-1535 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2 >Reporter: Jun Rao > Labels: newbie > > Currently, we only return the brokers that have assigned replicas for a topic > in TopicMetadataResponse. The new producer will use those brokers for > refreshing metadata. Now suppose that we stop all those brokers, copy all > local data to some new hosts and then restart those hosts (with the original > broker id). There is no way for the new producer to automatically get the > information about the new brokers since all old brokers are gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (KAFKA-1535) return all live brokers in TopicMetadataResponse
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061766#comment-14061766 ] Nicolae Marasoiu edited comment on KAFKA-1535 at 7/15/14 6:48 AM: -- Should this be done in the "default" branch 0.8.1 ? was (Author: nmarasoiu): Which branch should this be done on? Seems trunk == 0.9.0 Should this be done in the "default" branch 0.8.1 ? > return all live brokers in TopicMetadataResponse > > > Key: KAFKA-1535 > URL: https://issues.apache.org/jira/browse/KAFKA-1535 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2 >Reporter: Jun Rao > Labels: newbie > > Currently, we only return the brokers that have assigned replicas for a topic > in TopicMetadataResponse. The new producer will use those brokers for > refreshing metadata. Now suppose that we stop all those brokers, copy all > local data to some new hosts and then restart those hosts (with the original > broker id). There is no way for the new producer to automatically get the > information about the new brokers since all old brokers are gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (KAFKA-1535) return all live brokers in TopicMetadataResponse
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065424#comment-14065424 ] nicu marasoiu edited comment on KAFKA-1535 at 7/17/14 7:32 PM: --- updated trunk patch, tests fine, one question though, I have not find where is the topicMetadataResponse.brokers read in producers (or anywhere in the non-test code)! was (Author: nmarasoi): updated patch, tests fine, one question though, I have not find where is the topicMetadataResponse.brokers read in producers (or anywhere in the non-test code)! > return all live brokers in TopicMetadataResponse > > > Key: KAFKA-1535 > URL: https://issues.apache.org/jira/browse/KAFKA-1535 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2 >Reporter: Jun Rao > Labels: newbie > Attachments: > KAFKA-1535__return_all_live_brokers_in_TopicMetadataResponse_.patch > > > Currently, we only return the brokers that have assigned replicas for a topic > in TopicMetadataResponse. The new producer will use those brokers for > refreshing metadata. Now suppose that we stop all those brokers, copy all > local data to some new hosts and then restart those hosts (with the original > broker id). There is no way for the new producer to automatically get the > information about the new brokers since all old brokers are gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (KAFKA-1535) return all live brokers in TopicMetadataResponse
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065424#comment-14065424 ] nicu marasoiu edited comment on KAFKA-1535 at 7/17/14 7:43 PM: --- updated trunk patch, tests fine, one question though, even if it makes perfect sense for the producers to receive a configured static set of brokers and then get the actual live cluster composition from the brokers that could be contacted, (just like zookeeper client does), I have not find where the topicMetadataResponse.brokers is read in producers (or consumers, or anywhere in the non-test code)! was (Author: nmarasoi): updated trunk patch, tests fine, one question though, I have not find where is the topicMetadataResponse.brokers read in producers (or anywhere in the non-test code)! > return all live brokers in TopicMetadataResponse > > > Key: KAFKA-1535 > URL: https://issues.apache.org/jira/browse/KAFKA-1535 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2 >Reporter: Jun Rao > Labels: newbie > Attachments: > KAFKA-1535__return_all_live_brokers_in_TopicMetadataResponse_.patch > > > Currently, we only return the brokers that have assigned replicas for a topic > in TopicMetadataResponse. The new producer will use those brokers for > refreshing metadata. Now suppose that we stop all those brokers, copy all > local data to some new hosts and then restart those hosts (with the original > broker id). There is no way for the new producer to automatically get the > information about the new brokers since all old brokers are gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (KAFKA-1535) return all live brokers in TopicMetadataResponse
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066791#comment-14066791 ] nicu marasoiu edited comment on KAFKA-1535 at 7/18/14 7:50 PM: --- created KAFKA-1549 with Major priority. I also have KAFKA-1282 (which I like most and I would start first), and KAFKA-1510, both Major priority. What should be the order of doing them (I think they are all major right now) ? I would tackle 1282, 1549 then 1510. was (Author: nmarasoi): created KAFKA-1549 with Major priority. I also have KAFKA-1282 (which I like most and I would start first), KAFKA-1510, both Major priority. What should be the order of doing them (I think they are all major right now) ? I would tackle 1282, 1549 then 1510. > return all live brokers in TopicMetadataResponse > > > Key: KAFKA-1535 > URL: https://issues.apache.org/jira/browse/KAFKA-1535 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.8.2 >Reporter: Jun Rao >Assignee: nicu marasoiu > Labels: newbie > Attachments: > KAFKA-1535__return_all_live_brokers_in_TopicMetadataResponse_.patch > > > Currently, we only return the brokers that have assigned replicas for a topic > in TopicMetadataResponse. The new producer will use those brokers for > refreshing metadata. Now suppose that we stop all those brokers, copy all > local data to some new hosts and then restart those hosts (with the original > broker id). There is no way for the new producer to automatically get the > information about the new brokers since all old brokers are gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
