[ 
https://issues.apache.org/jira/browse/KAFKA-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667548#comment-15667548
 ] 

tony mancill edited comment on KAFKA-559 at 11/15/16 5:20 PM:
--------------------------------------------------------------

Hi [~ewencp].  The attachment 
[KAFKA-559.patch|https://issues.apache.org/jira/secure/attachment/12677332/KAFKA-559.patch]
 deletes bin/kafka-cleanup-obsolete-zk-entries.sh in the 3rd patch - I don't 
think this is intentional, is it?

{code}
>From 1351639d8e7dc2c4b5e869b05960951a82cc629a Mon Sep 17 00:00:00 2001
From: Ewen Cheslack-Postava <m...@ewencp.org>
Date: Thu, 23 Oct 2014 15:03:10 -0700
Subject: [PATCH 3/4] Fix naming: entires -> entries.

---
 bin/kafka-cleanup-obsolete-zk-entires.sh           |  19 --
 .../kafka/tools/CleanupObsoleteZkEntires.scala     | 331 ---------------------
 .../kafka/tools/CleanupObsoleteZkEntries.scala     | 331 +++++++++++++++++++++
 3 files changed, 331 insertions(+), 350 deletions(-)
 delete mode 100755 bin/kafka-cleanup-obsolete-zk-entires.sh
 delete mode 100644 
core/src/main/scala/kafka/tools/CleanupObsoleteZkEntires.scala
 create mode 100644 
core/src/main/scala/kafka/tools/CleanupObsoleteZkEntries.scala

diff --git a/bin/kafka-cleanup-obsolete-zk-entires.sh 
b/bin/kafka-cleanup-obsolete-zk-entires.sh
deleted file mode 100755
index f2c0cb8..0000000
--- a/bin/kafka-cleanup-obsolete-zk-entires.sh
+++ /dev/null
{code}

Instead, the shell script should be updated for the correct classname - 
something like:

{code}
diff --git a/bin/kafka-cleanup-obsolete-zk-entires.sh 
b/bin/kafka-cleanup-obsolete-zk-entires.sh
index f2c0cb8..0625183 100755
--- a/bin/kafka-cleanup-obsolete-zk-entires.sh
+++ b/bin/kafka-cleanup-obsolete-zk-entires.sh
@@ -16,4 +16,4 @@

 base_dir=$(dirname $0)
 export KAFKA_OPTS="-Xmx512M -server -Dcom.sun.management.jmxremote 
-Dlog4j.configuration=file:$base_dir/kafka-console-consumer-log4j.properties"
-$base_dir/kafka-run-class.sh kafka.tools.CleanupObsoleteZkEntires $@
+$base_dir/kafka-run-class.sh kafka.tools.CleanupObsoleteZkEntries $@
{code}


was (Author: tmancill):
Hi [~ewencp].  The attachment 
[KAFKA-559.patch|https://issues.apache.org/jira/secure/attachment/12677332/KAFKA-559.patch]
 deletes bin/kafka-cleanup-obsolete-zk-entries.sh in the 3rd patch - I don't 
think this is intentional, is it?

{code}
>From 1351639d8e7dc2c4b5e869b05960951a82cc629a Mon Sep 17 00:00:00 2001
From: Ewen Cheslack-Postava <m...@ewencp.org>
Date: Thu, 23 Oct 2014 15:03:10 -0700
Subject: [PATCH 3/4] Fix naming: entires -> entries.

---
 bin/kafka-cleanup-obsolete-zk-entires.sh           |  19 --
 .../kafka/tools/CleanupObsoleteZkEntires.scala     | 331 ---------------------
 .../kafka/tools/CleanupObsoleteZkEntries.scala     | 331 +++++++++++++++++++++
 3 files changed, 331 insertions(+), 350 deletions(-)
 delete mode 100755 bin/kafka-cleanup-obsolete-zk-entires.sh
 delete mode 100644 
core/src/main/scala/kafka/tools/CleanupObsoleteZkEntires.scala
 create mode 100644 
core/src/main/scala/kafka/tools/CleanupObsoleteZkEntries.scala

diff --git a/bin/kafka-cleanup-obsolete-zk-entires.sh 
b/bin/kafka-cleanup-obsolete-zk-entires.sh
deleted file mode 100755
index f2c0cb8..0000000
--- a/bin/kafka-cleanup-obsolete-zk-entires.sh
+++ /dev/null
{code}

> Garbage collect old consumer metadata entries
> ---------------------------------------------
>
>                 Key: KAFKA-559
>                 URL: https://issues.apache.org/jira/browse/KAFKA-559
>             Project: Kafka
>          Issue Type: New Feature
>            Reporter: Jay Kreps
>            Assignee: Ewen Cheslack-Postava
>              Labels: newbie, project
>         Attachments: KAFKA-559.patch, KAFKA-559.v1.patch, KAFKA-559.v2.patch
>
>
> Many use cases involve tranient consumers. These consumers create entries 
> under their consumer group in zk and maintain offsets there as well. There is 
> currently no way to delete these entries. It would be good to have a tool 
> that did something like
>   bin/delete-obsolete-consumer-groups.sh [--topic t1] --since [date] 
> --zookeeper [zk_connect]
> This would scan through consumer group entries and delete any that had no 
> offset update since the given date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to