[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733796#comment-13733796
]
Neha Narkhede edited comment on KAFKA-990 at 8/8/13 6:16 PM:
-
Thanks for the rebased patch, Sriram. Overall, the changes look great. +1. One
minor suggestion -
ReassignPartitionsCommand
For determining the replication factor for replica assignment, can we just use
the first or last partition in the map instead of relying on a partition id 0?
That way if we change the assumption that partition id should always start from
0, this will not break. -
topicInfo._2.head._2.size instead of
topicInfo._2.get(TopicAndPartition(topicInfo._1, 0)).get.size
If you are ok with this suggestion, I can make it on checkin.
Also, it seems that #2 in the description above was not really a problem. This
is because onPartitionReassignment checks areReplicasInIsr and hence restarts
the reassignment correctly. This is however not true if we hit #1, which is a
real issue.
was (Author: nehanarkhede):
Thanks for the rebased patch, Sriram. Overall, the changes look great. +1.
One minor suggestion -
ReassignPartitionsCommand
For determining the replication factor for replica assignment, can we just use
the first or last partition in the map instead of relying on a partition id 0?
That way if we change the assumption that partition id should always start from
0, this will not break. -
topicInfo._2.head._2.size instead of
topicInfo._2.get(TopicAndPartition(topicInfo._1, 0)).get.size
Also, it seems that #2 in the description above was not really a problem. This
is because onPartitionReassignment checks areReplicasInIsr and hence restarts
the reassignment correctly. This is however not true if we hit #1, which is a
real issue.
> Fix ReassignPartitionCommand and improve usability
> --
>
> Key: KAFKA-990
> URL: https://issues.apache.org/jira/browse/KAFKA-990
> Project: Kafka
> Issue Type: Bug
>Reporter: Sriram Subramanian
>Assignee: Sriram Subramanian
> Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch
>
>
> 1. The tool does not register for IsrChangeListener on controller failover.
> 2. There is a race condition where the previous listener can fire on
> controller failover and the replicas can be in ISR. Even after re-registering
> the ISR listener after failover, it will never be triggered.
> 3. The input the tool is a static list which is very hard to use. To improve
> this, as a first step the tool needs to take a list of topics and list of
> brokers to do the assignment to and then generate the reassignment plan.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
