[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816877#comment-13816877 ] Neha Narkhede commented on KAFKA-1119: -- Updated reviewboard https://reviews.apache.org/r/15274/ against branch trunk > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Critical > Attachments: KAFKA-1119.patch, KAFKA-1119_2013-11-06_10:13:13.patch, > KAFKA-1119_2013-11-07_09:50:20.patch, KAFKA-1119_2013-11-07_10:17:14.patch, > KAFKA-1119_2013-11-07_17:07:18.patch > > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816200#comment-13816200 ] Neha Narkhede commented on KAFKA-1119: -- Updated reviewboard https://reviews.apache.org/r/15274/ against branch trunk > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Critical > Attachments: KAFKA-1119.patch, KAFKA-1119_2013-11-06_10:13:13.patch, > KAFKA-1119_2013-11-07_09:50:20.patch, KAFKA-1119_2013-11-07_10:17:14.patch > > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816177#comment-13816177 ] Neha Narkhede commented on KAFKA-1119: -- Updated reviewboard https://reviews.apache.org/r/15274/ against branch trunk > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Critical > Attachments: KAFKA-1119.patch, KAFKA-1119_2013-11-06_10:13:13.patch, > KAFKA-1119_2013-11-07_09:50:20.patch > > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815097#comment-13815097 ] Neha Narkhede commented on KAFKA-1119: -- Updated reviewboard https://reviews.apache.org/r/15274/ against branch trunk > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Critical > Attachments: KAFKA-1119.patch, KAFKA-1119_2013-11-06_10:13:13.patch > > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815093#comment-13815093 ] Neha Narkhede commented on KAFKA-1119: -- Created reviewboard https://reviews.apache.org/r/15274/ against branch trunk > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Critical > Attachments: KAFKA-1119.patch > > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813655#comment-13813655 ] Jay Kreps commented on KAFKA-1119: -- Hmm, but it looks like the current behavior is to just blindly set whatever properties are given on the command line as the FULL set of properties. So if I say ./bin/kafka-topics.sh --alter --config retention.ms=18 I might think I am just changing the retention.ms but in reality I am unsetting any previous per-topic configs (whatever they may be) and setting retention.ms. Currently the code looks like this: val configs = parseTopicConfigs(opts) AdminUtils.changeTopicConfig(zkClient, topic, configs) I think it might be more intuitive if we interpreted the args as a diff to apply to the current settings. So the code would be soemthing like: val configs = AdminUtils.fetchTopicConfig(zkClient, topic) configs.addAll(parseTopicConfigs(opts)) AdminUtils.changeTopicConfig(zkClient, topic, configs) This does have a downside, though. How do you remove an override? Let's say there is a default of X, setting X actually sets a topic override of X which is different from having no setting for the config (because if you change the default that topic would be unaffected). This is not hugely important but some options for handling this would be 1. No value means delete the config: --config x= 2. Add a new option for unconfiguring: --config x=12 and --unconfig x > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Blocker > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (KAFKA-1119) Kafka 0.8.1 overwrites previous per topic config changes
[ https://issues.apache.org/jira/browse/KAFKA-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813577#comment-13813577 ] Neha Narkhede commented on KAFKA-1119: -- Turns out the right way to use the existing tool to specify more than one override is - ./bin/kafka-topics.sh --zookeeper localhost:2181 --topic topicconfigtest --alter --config retention.ms=18 --config segment.ms=18 > Kafka 0.8.1 overwrites previous per topic config changes > > > Key: KAFKA-1119 > URL: https://issues.apache.org/jira/browse/KAFKA-1119 > Project: Kafka > Issue Type: Bug > Components: config >Affects Versions: 0.8.1 >Reporter: Neha Narkhede >Assignee: Neha Narkhede >Priority: Blocker > > kafka-topics --alter --config overwrites the previous per topic configs. > There is no way to override more than one per topic config for the same topic -- This message was sent by Atlassian JIRA (v6.1#6144)
