[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892282#comment-15892282
]
Ismael Juma commented on KAFKA-1368:
Differences in the configuration format:
https://logging.apache.org/log4j/2.x/manual/migration.html
> Upgrade log4j
> -
>
> Key: KAFKA-1368
> URL: https://issues.apache.org/jira/browse/KAFKA-1368
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Vladislav Pernin
>Assignee: Mickael Maison
>
> Upgrade log4j to at least 1.2.16 ou 1.2.17.
> Usage of EnhancedPatternLayout will be possible.
> It allows to set delimiters around the full log, stacktrace included, making
> log messages collection easier with tools like Logstash.
> Example : <[%d{}]...[%t] %m%throwable>%n
> <[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
> request for partition [X,6] offset 700 from consumer with correlation id
> 0 (kafka.server.KafkaApis)
> kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
> have log segments in the range 16021 to 16021.
> at kafka.log.Log.read(Log.scala:429)
> ...
> at java.lang.Thread.run(Thread.java:744)>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892271#comment-15892271
]
Edoardo Comar commented on KAFKA-1368:
--
Yes [~ijuma] we will pick this one up. I work together with [~mimaison] who has
self assigned this one.
We will work on this just not yet next week.
What are the compatibility implications?
You mean that users need to switch the jars on which the kafka-client.jar
depends on ?
> Upgrade log4j
> -
>
> Key: KAFKA-1368
> URL: https://issues.apache.org/jira/browse/KAFKA-1368
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Vladislav Pernin
>Assignee: Mickael Maison
>
> Upgrade log4j to at least 1.2.16 ou 1.2.17.
> Usage of EnhancedPatternLayout will be possible.
> It allows to set delimiters around the full log, stacktrace included, making
> log messages collection easier with tools like Logstash.
> Example : <[%d{}]...[%t] %m%throwable>%n
> <[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
> request for partition [X,6] offset 700 from consumer with correlation id
> 0 (kafka.server.KafkaApis)
> kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
> have log segments in the range 16021 to 16021.
> at kafka.log.Log.read(Log.scala:429)
> ...
> at java.lang.Thread.run(Thread.java:744)>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892265#comment-15892265
]
Ismael Juma commented on KAFKA-1368:
[~ecomar], are you interested in picking this up? We could switch the broker's
`Logging` trait to use slf4j (like the clients) and then use the log4j 2.0
adapter: https://logging.apache.org/log4j/2.0/log4j-slf4j-impl/index.html.
Because of the compatibility implications, a KIP would be required. For users
who want to stick with log4j 1.x, they could replace the slf4j adapter.
> Upgrade log4j
> -
>
> Key: KAFKA-1368
> URL: https://issues.apache.org/jira/browse/KAFKA-1368
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Vladislav Pernin
>Assignee: Mickael Maison
>
> Upgrade log4j to at least 1.2.16 ou 1.2.17.
> Usage of EnhancedPatternLayout will be possible.
> It allows to set delimiters around the full log, stacktrace included, making
> log messages collection easier with tools like Logstash.
> Example : <[%d{}]...[%t] %m%throwable>%n
> <[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
> request for partition [X,6] offset 700 from consumer with correlation id
> 0 (kafka.server.KafkaApis)
> kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
> have log segments in the range 16021 to 16021.
> at kafka.log.Log.read(Log.scala:429)
> ...
> at java.lang.Thread.run(Thread.java:744)>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801283#comment-15801283
]
Edoardo Comar commented on KAFKA-1368:
--
Moving to Log4j v2 would allow dynamic reconfiguration of the logging levels
*without restarting the brokers* and without any API changes.
This could be done by a user, switching to the XML format, rather than
properties, and adding a directive like
{code:xml}
{code}
as described here
http://logging.apache.org/log4j/2.x/manual/configuration.html#AutomaticReconfiguration
> Upgrade log4j
> -
>
> Key: KAFKA-1368
> URL: https://issues.apache.org/jira/browse/KAFKA-1368
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Vladislav Pernin
>
> Upgrade log4j to at least 1.2.16 ou 1.2.17.
> Usage of EnhancedPatternLayout will be possible.
> It allows to set delimiters around the full log, stacktrace included, making
> log messages collection easier with tools like Logstash.
> Example : <[%d{}]...[%t] %m%throwable>%n
> <[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
> request for partition [X,6] offset 700 from consumer with correlation id
> 0 (kafka.server.KafkaApis)
> kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
> have log segments in the range 16021 to 16021.
> at kafka.log.Log.read(Log.scala:429)
> ...
> at java.lang.Thread.run(Thread.java:744)>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796263#comment-15796263
]
Gérald Quintana commented on KAFKA-1368:
It would be great to be able to mix time based and size based rolling files and
limit the number of files as well.
* Log4J v2 can do it:
https://logging.apache.org/log4j/2.x/manual/appenders.html#Composite_Triggering_Policy
* Log4J v1 + Log4J extras can mostly do it:
https://logging.apache.org/log4j/extras/apidocs/org/apache/log4j/rolling/package-summary.html
* Logback can also do it:
http://logback.qos.ch/manual/appenders.html#SizeAndTimeBasedRollingPolicy
> Upgrade log4j
> -
>
> Key: KAFKA-1368
> URL: https://issues.apache.org/jira/browse/KAFKA-1368
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.0
>Reporter: Vladislav Pernin
>
> Upgrade log4j to at least 1.2.16 ou 1.2.17.
> Usage of EnhancedPatternLayout will be possible.
> It allows to set delimiters around the full log, stacktrace included, making
> log messages collection easier with tools like Logstash.
> Example : <[%d{}]...[%t] %m%throwable>%n
> <[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
> request for partition [X,6] offset 700 from consumer with correlation id
> 0 (kafka.server.KafkaApis)
> kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
> have log segments in the range 16021 to 16021.
> at kafka.log.Log.read(Log.scala:429)
> ...
> at java.lang.Thread.run(Thread.java:744)>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137492#comment-14137492
]
Abhishek Sharma commented on KAFKA-1368:
Log4j 2 is having many advance features and is very much improved then previous
version.
Are we thinking over the lines to change the dependency to log4j 2??
Upgrade log4j
-
Key: KAFKA-1368
URL: https://issues.apache.org/jira/browse/KAFKA-1368
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8.0
Reporter: Vladislav Pernin
Upgrade log4j to at least 1.2.16 ou 1.2.17.
Usage of EnhancedPatternLayout will be possible.
It allows to set delimiters around the full log, stacktrace included, making
log messages collection easier with tools like Logstash.
Example : [%d{}]...[%t] %m%throwable%n
[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
request for partition [X,6] offset 700 from consumer with correlation id
0 (kafka.server.KafkaApis)
kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
have log segments in the range 16021 to 16021.
at kafka.log.Log.read(Log.scala:429)
...
at java.lang.Thread.run(Thread.java:744)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1368) Upgrade log4j
[
https://issues.apache.org/jira/browse/KAFKA-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14137579#comment-14137579
]
Vladislav Pernin commented on KAFKA-1368:
-
No problem as soon as it is stable (I have no idea if this is the case for the
current version) and an layout with the same feature than EnhancedPatternLayout
does exists.
Upgrade log4j
-
Key: KAFKA-1368
URL: https://issues.apache.org/jira/browse/KAFKA-1368
Project: Kafka
Issue Type: Improvement
Affects Versions: 0.8.0
Reporter: Vladislav Pernin
Upgrade log4j to at least 1.2.16 ou 1.2.17.
Usage of EnhancedPatternLayout will be possible.
It allows to set delimiters around the full log, stacktrace included, making
log messages collection easier with tools like Logstash.
Example : [%d{}]...[%t] %m%throwable%n
[2014-04-08 11:07:20,360] ERROR [KafkaApi-1] Error when processing fetch
request for partition [X,6] offset 700 from consumer with correlation id
0 (kafka.server.KafkaApis)
kafka.common.OffsetOutOfRangeException: Request for offset 700 but we only
have log segments in the range 16021 to 16021.
at kafka.log.Log.read(Log.scala:429)
...
at java.lang.Thread.run(Thread.java:744)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
