[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-22 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070585#comment-14070585
 ] 

Jun Rao commented on KAFKA-1462:


Thanks for the reviews. Committed the followup patch.

 Add new request and response formats for the new consumer and coordinator 
 communication
 ---

 Key: KAFKA-1462
 URL: https://issues.apache.org/jira/browse/KAFKA-1462
 Project: Kafka
  Issue Type: Sub-task
  Components: consumer
Reporter: Guozhang Wang
Assignee: Jun Rao
 Fix For: 0.8.2

 Attachments: KAFKA-1462.patch, KAFKA-1462.patch, 
 KAFKA-1462_2014-07-16_21:39:07.patch


 We need to add the request / response formats according to the new format 
 protocol once their design is final:
 https://cwiki.apache.org/confluence/display/KAFKA
 /Kafka+0.9+Consumer+Rewrite+Design



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-21 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068613#comment-14068613
 ] 

Jun Rao commented on KAFKA-1462:


There is actually an issue with the patch. The server side objects can't use 
the full request header right now since it doesn't include the request id. Will 
submit a followup patch to address this.

 Add new request and response formats for the new consumer and coordinator 
 communication
 ---

 Key: KAFKA-1462
 URL: https://issues.apache.org/jira/browse/KAFKA-1462
 Project: Kafka
  Issue Type: Sub-task
  Components: consumer
Reporter: Guozhang Wang
Assignee: Jun Rao
 Fix For: 0.8.2

 Attachments: KAFKA-1462.patch, KAFKA-1462.patch, 
 KAFKA-1462_2014-07-16_21:39:07.patch


 We need to add the request / response formats according to the new format 
 protocol once their design is final:
 https://cwiki.apache.org/confluence/display/KAFKA
 /Kafka+0.9+Consumer+Rewrite+Design



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-21 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068614#comment-14068614
 ] 

Jun Rao commented on KAFKA-1462:


Created reviewboard https://reviews.apache.org/r/23740/
 against branch origin/trunk

 Add new request and response formats for the new consumer and coordinator 
 communication
 ---

 Key: KAFKA-1462
 URL: https://issues.apache.org/jira/browse/KAFKA-1462
 Project: Kafka
  Issue Type: Sub-task
  Components: consumer
Reporter: Guozhang Wang
Assignee: Jun Rao
 Fix For: 0.8.2

 Attachments: KAFKA-1462.patch, KAFKA-1462.patch, 
 KAFKA-1462_2014-07-16_21:39:07.patch


 We need to add the request / response formats according to the new format 
 protocol once their design is final:
 https://cwiki.apache.org/confluence/display/KAFKA
 /Kafka+0.9+Consumer+Rewrite+Design



--
This message was sent by Atlassian JIRA
(v6.2#6252)