[jira] [Commented] (KAFKA-1560) Make arguments to jira-python API more explicit in kafka-patch-review's get_jira()
[ https://issues.apache.org/jira/browse/KAFKA-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076957#comment-14076957 ] Jonathan Natkins commented on KAFKA-1560: - Created reviewboard https://reviews.apache.org/r/24012/diff/ against branch origin/trunk > Make arguments to jira-python API more explicit in kafka-patch-review's > get_jira() > --- > > Key: KAFKA-1560 > URL: https://issues.apache.org/jira/browse/KAFKA-1560 > Project: Kafka > Issue Type: Improvement >Reporter: Jonathan Natkins >Priority: Minor > Attachments: KAFKA-1560.patch > > > I ran into an issue with kafka-patch-review.py as a result of a change in > parameters for the JIRA() object between jira-python 0.28 and 0.29. A quick > fix is to make parameters more explicit. > As a side note, there is a separate bug affecting the review tool, but I'm > not sure it's fixable without modifying the jira-python source > (https://bitbucket.org/bspeakmon/jira-python/issue/122/clientissue-function-needs-param-removal) > It seems the answer is that people should not use jira-python 0.29 yet, since > it's a little broken. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1560) Make arguments to jira-python API more explicit in kafka-patch-review's get_jira()
[ https://issues.apache.org/jira/browse/KAFKA-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097986#comment-14097986 ] Neha Narkhede commented on KAFKA-1560: -- Created reviewboard https://reviews.apache.org/r/24726/ against branch trunk > Make arguments to jira-python API more explicit in kafka-patch-review's > get_jira() > --- > > Key: KAFKA-1560 > URL: https://issues.apache.org/jira/browse/KAFKA-1560 > Project: Kafka > Issue Type: Improvement >Reporter: Jonathan Natkins >Priority: Minor > Attachments: KAFKA-1560.patch, KAFKA-1560.patch > > > I ran into an issue with kafka-patch-review.py as a result of a change in > parameters for the JIRA() object between jira-python 0.28 and 0.29. A quick > fix is to make parameters more explicit. > As a side note, there is a separate bug affecting the review tool, but I'm > not sure it's fixable without modifying the jira-python source > (https://bitbucket.org/bspeakmon/jira-python/issue/122/clientissue-function-needs-param-removal) > It seems the answer is that people should not use jira-python 0.29 yet, since > it's a little broken. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1560) Make arguments to jira-python API more explicit in kafka-patch-review's get_jira()
[ https://issues.apache.org/jira/browse/KAFKA-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097996#comment-14097996 ] Jonathan Natkins commented on KAFKA-1560: - No problem, thanks! > Make arguments to jira-python API more explicit in kafka-patch-review's > get_jira() > --- > > Key: KAFKA-1560 > URL: https://issues.apache.org/jira/browse/KAFKA-1560 > Project: Kafka > Issue Type: Improvement >Reporter: Jonathan Natkins >Assignee: Jonathan Natkins >Priority: Minor > Attachments: KAFKA-1560.patch, KAFKA-1560.patch > > > I ran into an issue with kafka-patch-review.py as a result of a change in > parameters for the JIRA() object between jira-python 0.28 and 0.29. A quick > fix is to make parameters more explicit. > As a side note, there is a separate bug affecting the review tool, but I'm > not sure it's fixable without modifying the jira-python source > (https://bitbucket.org/bspeakmon/jira-python/issue/122/clientissue-function-needs-param-removal) > It seems the answer is that people should not use jira-python 0.29 yet, since > it's a little broken. -- This message was sent by Atlassian JIRA (v6.2#6252)
