[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260537#comment-14260537 ] Neha Narkhede commented on KAFKA-1781: -- [~charmalloc]. Just checking to see if you had a chance to double commit and make the README changes. This is marked as a blocker for 0.8.2 > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228633#comment-14228633 ] Joe Stein commented on KAFKA-1781: -- +1 to double commit KAFKA-1624 and add the gradle version requirement for JDK 8 in README > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227078#comment-14227078 ] Jun Rao commented on KAFKA-1781: We can probably just double commit KAFKA-1624 to 0.8.2 and add the gradle version requirement for JDK 8 in README. > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215079#comment-14215079 ] Jean-Francois Im commented on KAFKA-1781: - Also, see https://issues.gradle.org/browse/GRADLE-3094 which has been fixed in Gradle 2.0. > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[
https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215074#comment-14215074
]
Jean-Francois Im commented on KAFKA-1781:
-
I think the two are related to JDK 8, but distinct issues. For example, running
with JDK 8, gradle 1.8 and scala version 2.11:
{quote}
$ gradle -version
Gradle 1.8
Build time: 2013-09-24 07:32:33 UTC
Build number: none
Revision: 7970ec3503b4f5767ee1c1c69f8b4186c4763e3d
Groovy: 1.8.6
Ant: Apache Ant(TM) version 1.9.2 compiled on July 8 2013
Ivy: 2.2.0
JVM: 1.8.0_05 (Oracle Corporation 25.5-b02)
OS: Linux 2.6.32-358.6.2.el6.x86_64 amd64
$ gradle -PscalaVersion=2.11
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/1.8/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.11
FAILURE: Build failed with an exception.
* Where:
Build file '/home/jfim/projects/KAFKA-1781/build.gradle' line: 199
* What went wrong:
A problem occurred evaluating root project 'KAFKA-1781'.
> Could not create task of type 'ScalaDoc'.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 7.725 secs
{quote}
I think the takeaway for the wrapper download is that 2.0 is required if
running on JDK 8 and that 1.8 (and potentially lower) work on JDK 7. The rest
of the build is still broken with scala 2.10.1 on JDK 8, even when on gradle
2.0.
I'm not sure what the proper resolution to this issue would be. Requiring 2.0
seems rather safe but is only required on JDK 8 and does not fix KAFKA-1624.
Perhaps adding a note that JDK 8 is not supported at this point in time is the
proper resolution?
> Readme should specify that Gradle 2.0 is required for initial bootstrap
> ---
>
> Key: KAFKA-1781
> URL: https://issues.apache.org/jira/browse/KAFKA-1781
> Project: Kafka
> Issue Type: Bug
> Components: build
>Affects Versions: 0.8.2
>Reporter: Jean-Francois Im
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: gradle-2.0-readme.patch
>
>
> Current README.md says "You need to have gradle installed."
> As the bootstrap procedure doesn't work with gradle 1.12, this needs to say
> that 2.0 or greater is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215040#comment-14215040 ] Joe Stein commented on KAFKA-1781: -- JDK 8 related support information is captured here KAFKA-1624 > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215036#comment-14215036 ] Jean-Francois Im commented on KAFKA-1781: - It seems to work with 1.8 and 1.12 if I switch the JDK to 1.7.0_51. Is JDK 8 supported by Kafka? > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215030#comment-14215030 ] Joe Stein commented on KAFKA-1781: -- I think your issue is related to your JVM being 8 instead of 7 which has some more info here KAFKA-1624 and not gradle versions > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[
https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14215013#comment-14215013
]
Jean-Francois Im commented on KAFKA-1781:
-
It is weird! This is what I get:
{quote}
$ git clone https://git-wip-us.apache.org/repos/asf/kafka.git KAFKA-1781
Cloning into 'KAFKA-1781'...
remote: Counting objects: 21794, done.
remote: Compressing objects: 100% (7216/7216), done.
remote: Total 21794 (delta 12925), reused 19667 (delta 11330)
Receiving objects: 100% (21794/21794), 15.17 MiB | 2.57 MiB/s, done.
Resolving deltas: 100% (12925/12925), done.
$ cd KAFKA-1781
$ git checkout -b 0.8.2 origin/0.8.2
Branch 0.8.2 set up to track remote branch 0.8.2 from origin.
Switched to a new branch '0.8.2'
$ gradle --version
Gradle 1.8
Build time: 2013-09-24 07:32:33 UTC
Build number: none
Revision: 7970ec3503b4f5767ee1c1c69f8b4186c4763e3d
Groovy: 1.8.6
Ant: Apache Ant(TM) version 1.9.2 compiled on July 8 2013
Ivy: 2.2.0
JVM: 1.8.0_05 (Oracle Corporation 25.5-b02)
OS: Linux 2.6.32-358.6.2.el6.x86_64 amd64
$ gradle
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/1.8/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.10.1
FAILURE: Build failed with an exception.
* Where:
Build file '/home/jfim/projects/KAFKA-1781/build.gradle' line: 199
* What went wrong:
A problem occurred evaluating root project 'KAFKA-1781'.
> Could not create task of type 'ScalaDoc'.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 10.612 secs
{quote}
The differences between our setups seem to be JDK version (1.7.0_25 for you,
1.8.0_05 on my end) and OS (Mac OS X vs Linux). 2.0 seems to work fine with the
commands you use.
{quote}
$ rm -rf KAFKA-1781/
$ git clone https://git-wip-us.apache.org/repos/asf/kafka.git KAFKA-1781
Cloning into 'KAFKA-1781'...
remote: Counting objects: 21794, done.
remote: Compressing objects: 100% (7216/7216), done.
remote: Total 21794 (delta 12924), reused 19668 (delta 11330)
Receiving objects: 100% (21794/21794), 15.17 MiB | 2.74 MiB/s, done.
Resolving deltas: 100% (12924/12924), done.
$ cd KAFKA-1781
$ git checkout -b 0.8.2 origin/0.8.2
Branch 0.8.2 set up to track remote branch 0.8.2 from origin.
Switched to a new branch '0.8.2'
$ gradle --version
Gradle 2.0
Build time: 2014-07-01 07:45:34 UTC
Build number: none
Revision: b6ead6fa452dfdadec484059191eb641d817226c
Groovy: 2.3.3
Ant: Apache Ant(TM) version 1.9.3 compiled on December 23 2013
JVM: 1.8.0_05 (Oracle Corporation 25.5-b02)
OS: Linux 2.6.32-358.6.2.el6.x86_64 amd64
$ gradle
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/2.0/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.10.1
:downloadWrapper
BUILD SUCCESSFUL
Total time: 11.341 secs
$ ./gradlew
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/2.0/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.10.1
:downloadWrapper UP-TO-DATE
BUILD SUCCESSFUL
Total time: 7.159 secs
{quote}
I don't mind amending the patch to reflect a lower version, but 2.0 and 2.2
both appear to work on my end, while 1.8 and 1.12 don't.
> Readme should specify that Gradle 2.0 is required for initial bootstrap
> ---
>
> Key: KAFKA-1781
> URL: https://issues.apache.org/jira/browse/KAFKA-1781
> Project: Kafka
> Issue Type: Bug
> Components: build
>Affects Versions: 0.8.2
>Reporter: Jean-Francois Im
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: gradle-2.0-readme.patch
>
>
> Current README.md says "You need to have gradle installed."
> As the bootstrap procedure doesn't work with gradle 1.12, this needs to say
> that 2.0 or greater is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[
https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214978#comment-14214978
]
Joe Stein commented on KAFKA-1781:
--
That is weird, I tried from a fresh clone just now
{code}
new-host:apache_kafka joestein$ git clone
https://git-wip-us.apache.org/repos/asf/kafka.git KAFKA-1781
Cloning into 'KAFKA-1781'...
remote: Counting objects: 21794, done.
remote: Compressing objects: 100% (7216/7216), done.
remote: Total 21794 (delta 12923), reused 19669 (delta 11330)
Receiving objects: 100% (21794/21794), 15.18 MiB | 623 KiB/s, done.
Resolving deltas: 100% (12923/12923), done.
new-host:apache_kafka joestein$ cd KAFKA-1781/
new-host:KAFKA-1781 joestein$ git checkout -b 0.8.2 origin/0.8.2
Branch 0.8.2 set up to track remote branch 0.8.2 from origin.
Switched to a new branch '0.8.2'
new-host:KAFKA-1781 joestein$ gradle --version
Gradle 1.8
Build time: 2013-09-24 07:32:33 UTC
Build number: none
Revision: 7970ec3503b4f5767ee1c1c69f8b4186c4763e3d
Groovy: 1.8.6
Ant: Apache Ant(TM) version 1.9.2 compiled on July 8 2013
Ivy: 2.2.0
JVM: 1.7.0_25 (Oracle Corporation 23.25-b01)
OS: Mac OS X 10.8.5 x86_64
new-host:KAFKA-1781 joestein$ gradle
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/1.8/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.10.1
:downloadWrapper
BUILD SUCCESSFUL
Total time: 18.37 secs
new-host:KAFKA-1781 joestein$ ./gradlew jar
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
http://gradle.org/docs/2.0/userguide/gradle_daemon.html.
Building project 'core' with Scala version 2.10.1
:clients:compileJava
Download
http://repo1.maven.org/maven2/org/xerial/snappy/snappy-java/1.1.1.6/snappy-java-1.1.1.6.pom
Download
http://repo1.maven.org/maven2/org/xerial/snappy/snappy-java/1.1.1.6/snappy-java-1.1.1.6.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:clients:processResources UP-TO-DATE
:clients:classes
:clients:jar
:contrib:compileJava UP-TO-DATE
:contrib:processResources UP-TO-DATE
:contrib:classes UP-TO-DATE
:contrib:jar
:core:compileJava UP-TO-DATE
:core:compileScala
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/admin/AdminUtils.scala:259:
non-variable type argument String in type pattern
scala.collection.Map[String,_] is unchecked since it is eliminated by erasure
case Some(map: Map[String, _]) =>
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/admin/AdminUtils.scala:262:
non-variable type argument String in type pattern
scala.collection.Map[String,String] is unchecked since it is eliminated by
erasure
case Some(config: Map[String, String]) =>
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/server/KafkaServer.scala:168:
a pure expression does nothing in statement position; you may be omitting
necessary parentheses
ControllerStats.uncleanLeaderElectionRate
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/server/KafkaServer.scala:169:
a pure expression does nothing in statement position; you may be omitting
necessary parentheses
ControllerStats.leaderElectionTimer
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/utils/Utils.scala:81: a
pure expression does nothing in statement position; you may be omitting
necessary parentheses
daemonThread(name, runnable(fun))
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/network/SocketServer.scala:361:
Visited SCOPE_EXIT before visiting corresponding SCOPE_ENTER. SI-6049
maybeCloseOldestConnection
^
/opt/apache_kafka/KAFKA-1781/core/src/main/scala/kafka/network/SocketServer.scala:381:
Visited SCOPE_EXIT before visiting corresponding SCOPE_ENTER. SI-6049
try {
^
there were 12 feature warning(s); re-run with -feature for details
8 warnings found
:core:processResources UP-TO-DATE
:core:classes
:core:copyDependantLibs
:core:jar
:examples:compileJava
:examples:processResources UP-TO-DATE
:examples:classes
:examples:jar
:contrib:hadoop-consumer:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:contrib:hadoop-consumer:processResources UP-TO-DATE
:contrib:hadoop-consumer:classes
:contrib:hadoop-consumer:jar
:contrib:hadoop-producer:compileJava
:contrib:hadoop-producer:processResources UP-TO-DATE
:contrib:hadoop-producer:classes
:contrib:had
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[
https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214969#comment-14214969
]
Jean-Francois Im commented on KAFKA-1781:
-
It doesn't seem to work with 1.8.
{quote}
$ rm -rf gradle/wrapper/
$ gradle -version
Gradle 1.8
Build time: 2013-09-24 07:32:33 UTC
Build number: none
Revision: 7970ec3503b4f5767ee1c1c69f8b4186c4763e3d
[snip]
$ gradle
[snip]
Building project 'core' with Scala version 2.10.1
FAILURE: Build failed with an exception.
* Where:
Build file '/home/jfim/projects/kafka/build.gradle' line: 199
* What went wrong:
A problem occurred evaluating root project 'kafka'.
> Could not create task of type 'ScalaDoc'.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 15.229 secs
$ ./gradlew
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
{quote}
This is what happens in 2.0. I also tested with 1.12, it does the same as 1.8.
{quote}
$ rm -rf gradle/wrapper/
$ gradle -version
Gradle 2.0
Build time: 2014-07-01 07:45:34 UTC
Build number: none
Revision: b6ead6fa452dfdadec484059191eb641d817226c
[snip]
$ gradle
Building project 'core' with Scala version 2.10.1
:downloadWrapper
BUILD SUCCESSFUL
Total time: 7.239 secs
$ ./gradlew
Building project 'core' with Scala version 2.10.1
:downloadWrapper UP-TO-DATE
BUILD SUCCESSFUL
Total time: 6.937 secs
{quote}
> Readme should specify that Gradle 2.0 is required for initial bootstrap
> ---
>
> Key: KAFKA-1781
> URL: https://issues.apache.org/jira/browse/KAFKA-1781
> Project: Kafka
> Issue Type: Bug
> Components: build
>Affects Versions: 0.8.2
>Reporter: Jean-Francois Im
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: gradle-2.0-readme.patch
>
>
> Current README.md says "You need to have gradle installed."
> As the bootstrap procedure doesn't work with gradle 1.12, this needs to say
> that 2.0 or greater is needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1781) Readme should specify that Gradle 2.0 is required for initial bootstrap
[ https://issues.apache.org/jira/browse/KAFKA-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214951#comment-14214951 ] Joe Stein commented on KAFKA-1781: -- [~jean-francois.l...@teximus.com] I have this working with Gradle 1.8 on my machine but your point is valid, we should go with the min version (lets set that as 1.8). Do you mind updating the patch? Thanks! > Readme should specify that Gradle 2.0 is required for initial bootstrap > --- > > Key: KAFKA-1781 > URL: https://issues.apache.org/jira/browse/KAFKA-1781 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.8.2 >Reporter: Jean-Francois Im >Priority: Blocker > Fix For: 0.8.2 > > Attachments: gradle-2.0-readme.patch > > > Current README.md says "You need to have gradle installed." > As the bootstrap procedure doesn't work with gradle 1.12, this needs to say > that 2.0 or greater is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
