[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-29 Thread Mayuresh Gharat (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260506#comment-14260506
 ] 

Mayuresh Gharat commented on KAFKA-1784:


I suppose we don't require this ticket. KAFKA-1013 takes care of this. I have 
uploaded a patch for KAFKA-1013 after incorporating the new comments that Joel 
had given. I have also incorporated your comments on merging the the import and 
export offsets tool in to a single tool. 
That patch has an API for fetching and committing offsets that this ticket 
describes. So I suppose this can be closed as duplicate. 

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1784.patch
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-29 Thread Neha Narkhede (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260484#comment-14260484
 ] 

Neha Narkhede commented on KAFKA-1784:
--

[~mgharat] Did you get a chance to address my review comments and use the 
helper methods directly and just add the admin tool script for now? This is 
currently marked as a blocker for 0.8.2

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1784.patch
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-08 Thread Mayuresh Gharat (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238736#comment-14238736
 ] 

Mayuresh Gharat commented on KAFKA-1784:


Yes. We are planning to do that. Actually the patch for KAFKA-1013 has those. 
Currently this patch can be used for admin usage and then we will get back to 
KAFKA-1013 to make it work with KafkaApis and Consumer.

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1784.patch
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-08 Thread Neha Narkhede (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238723#comment-14238723
 ] 

Neha Narkhede commented on KAFKA-1784:
--

[~mgharat] Thanks for the patch. Can you add a little more context on the 
intent and usage of this library? It is meant for admin usage only or do you 
intend to refactor the existing KafkaApis to use this new library?

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1784.patch
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-07 Thread Mayuresh Gharat (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237248#comment-14237248
 ] 

Mayuresh Gharat commented on KAFKA-1784:


Created reviewboard https://reviews.apache.org/r/28793/diff/
 against branch origin/trunk

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: KAFKA-1784.patch
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-02 Thread Neha Narkhede (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232165#comment-14232165
 ] 

Neha Narkhede commented on KAFKA-1784:
--

Thanks [~mgharat] and [~jjkoshy]

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-02 Thread Mayuresh Gharat (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232086#comment-14232086
 ] 

Mayuresh Gharat commented on KAFKA-1784:


Separating out the client will not be a big change. I suppose it is already 
their in the earlier patch in KAFKA-1013. I will discuss this with Joel today. 
I think I should be able to complete this before the deadline.

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-02 Thread Neha Narkhede (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232071#comment-14232071
 ] 

Neha Narkhede commented on KAFKA-1784:
--

[~mgharat] Are you actively working on this? How long do you think this will 
take given that we are shooting for end of the month for the 0.8.2 release?

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-02 Thread Joel Koshy (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232060#comment-14232060
 ] 

Joel Koshy commented on KAFKA-1784:
---

It does not need to be a blocker but would be good to get it in as it makes the 
offset management APIs a lot easier to use. This is mostly done in KAFKA-1013 
but I would like to separate out the client in that patch. If this ends up 
being the last blocker we can move it out but if we have enough cycles to get 
it in we should.

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-01 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230877#comment-14230877
 ] 

Jun Rao commented on KAFKA-1784:


Joel, does this need to be a blocker for 0.8.2?

> Implement a ConsumerOffsetClient library
> 
>
> Key: KAFKA-1784
> URL: https://issues.apache.org/jira/browse/KAFKA-1784
> Project: Kafka
>  Issue Type: New Feature
>Reporter: Joel Koshy
>Assignee: Mayuresh Gharat
>Priority: Blocker
> Fix For: 0.8.2
>
>
> I think it would be useful to provide an offset client library. It would make 
> the documentation a lot simpler. Right now it is non-trivial to commit/fetch 
> offsets to/from kafka.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)