[jira] [Commented] (KAFKA-1812) Allow IpV6 in configuration with parseCsvMap
[ https://issues.apache.org/jira/browse/KAFKA-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243745#comment-14243745 ] Gwen Shapira commented on KAFKA-1812: - [~joestein] - this patch tests look good to me. If you can take a look and commit if it looks good to you as well (LGTY2?), I'd appreciate. Allow IpV6 in configuration with parseCsvMap - Key: KAFKA-1812 URL: https://issues.apache.org/jira/browse/KAFKA-1812 Project: Kafka Issue Type: Bug Reporter: Jeff Holoman Assignee: Jeff Holoman Priority: Minor Labels: newbie Fix For: 0.8.3 Attachments: KAFKA-1812_2014-12-10_21:38:59.patch The current implementation of parseCsvMap in Utils expects k:v,k:v. This modifies that function to accept a string with multiple : characters and splitting on the last occurrence per pair. This limitation is noted in the Reviewboard comments for KAFKA-1512 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1812) Allow IpV6 in configuration with parseCsvMap
[ https://issues.apache.org/jira/browse/KAFKA-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242036#comment-14242036 ] Jeff Holoman commented on KAFKA-1812: - Updated reviewboard https://reviews.apache.org/r/28859/diff/ against branch origin/trunk Allow IpV6 in configuration with parseCsvMap - Key: KAFKA-1812 URL: https://issues.apache.org/jira/browse/KAFKA-1812 Project: Kafka Issue Type: Bug Reporter: Jeff Holoman Assignee: Jeff Holoman Priority: Minor Labels: newbie Fix For: 0.8.3 Attachments: KAFKA-1812_2014-12-10_21:38:59.patch The current implementation of parseCsvMap in Utils expects k:v,k:v. This modifies that function to accept a string with multiple : characters and splitting on the last occurrence per pair. This limitation is noted in the Reviewboard comments for KAFKA-1512 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1812) Allow IpV6 in configuration with parseCsvMap
[ https://issues.apache.org/jira/browse/KAFKA-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240070#comment-14240070 ] Jeff Holoman commented on KAFKA-1812: - https://reviews.apache.org/r/28859/diff/ Allow IpV6 in configuration with parseCsvMap - Key: KAFKA-1812 URL: https://issues.apache.org/jira/browse/KAFKA-1812 Project: Kafka Issue Type: Bug Reporter: Jeff Holoman Assignee: Jeff Holoman Priority: Minor Labels: newbie Fix For: 0.8.3 The current implementation of parseCsvMap in Utils expects k:v,k:v. This modifies that function to accept a string with multiple : characters and splitting on the last occurrence per pair. This limitation is noted in the Reviewboard comments for KAFKA-1512 -- This message was sent by Atlassian JIRA (v6.3.4#6332)