[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345612#comment-14345612 ] Joel Koshy commented on KAFKA-1852: --- (As noted in RB we need a separate jira to handle for commits that occur while deleting topics) > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch, KAFKA-1852_2015-02-16_13:21:46.patch, > KAFKA-1852_2015-02-18_13:13:17.patch, KAFKA-1852_2015-02-27_13:50:34.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340874#comment-14340874 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch, KAFKA-1852_2015-02-16_13:21:46.patch, > KAFKA-1852_2015-02-18_13:13:17.patch, KAFKA-1852_2015-02-27_13:50:34.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340163#comment-14340163 ] Sriharsha Chintalapani commented on KAFKA-1852: --- [~jjkoshy] Updated the patch as per your suggestions can you please take a look.Thanks > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch, KAFKA-1852_2015-02-16_13:21:46.patch, > KAFKA-1852_2015-02-18_13:13:17.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326566#comment-14326566 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch, KAFKA-1852_2015-02-16_13:21:46.patch, > KAFKA-1852_2015-02-18_13:13:17.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323316#comment-14323316 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch, KAFKA-1852_2015-02-16_13:21:46.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319332#comment-14319332 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Thanks [~jjkoshy] for the review. I added your suggestion please take a look when you get a chance. > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319327#comment-14319327 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch, > KAFKA-1852_2015-02-12_16:46:10.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316739#comment-14316739 ] Joel Koshy commented on KAFKA-1852: --- Thanks for the ping - will take a look. > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316447#comment-14316447 ] Sriharsha Chintalapani commented on KAFKA-1852: --- [~jjkoshy] pinging for a review. Thanks. > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291407#comment-14291407 ] Neha Narkhede commented on KAFKA-1852: -- [~jjkoshy] would you like to take a look at this patch? > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282844#comment-14282844 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Updated reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch, KAFKA-1852_2015-01-19_10:44:01.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278081#comment-14278081 ] Sriharsha Chintalapani commented on KAFKA-1852: --- Created reviewboard https://reviews.apache.org/r/29912/diff/ against branch origin/trunk > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao >Assignee: Sriharsha Chintalapani > Attachments: KAFKA-1852.patch > > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1852) OffsetCommitRequest can commit offset on unknown topic
[ https://issues.apache.org/jira/browse/KAFKA-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271884#comment-14271884 ] Jun Rao commented on KAFKA-1852: Another weird thing this causes is that we can commit an offset to a non-existing topic, but will get an UnknownTopic error when fetching the offset. > OffsetCommitRequest can commit offset on unknown topic > -- > > Key: KAFKA-1852 > URL: https://issues.apache.org/jira/browse/KAFKA-1852 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.3 >Reporter: Jun Rao > > Currently, we allow an offset to be committed to Kafka, even when the > topic/partition for the offset doesn't exist. We probably should disallow > that and send an error back in that case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
