[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484196#comment-14484196 ] Gwen Shapira commented on KAFKA-1992: - oh wow, thanks :) Totally forgot about this one, or I would have bugged you earlier ;) > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Fix For: 0.8.3 > > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch, > KAFKA-1992_2015-03-03_17:17:43.patch, KAFKA-1992_2015-03-06_13:34:20.patch, > KAFKA-1992_2015-03-06_13:36:32.patch, KAFKA-1992_2015-03-06_13:37:39.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350942#comment-14350942 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch, > KAFKA-1992_2015-03-03_17:17:43.patch, KAFKA-1992_2015-03-06_13:34:20.patch, > KAFKA-1992_2015-03-06_13:36:32.patch, KAFKA-1992_2015-03-06_13:37:39.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350940#comment-14350940 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch, > KAFKA-1992_2015-03-03_17:17:43.patch, KAFKA-1992_2015-03-06_13:34:20.patch, > KAFKA-1992_2015-03-06_13:36:32.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350933#comment-14350933 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch, > KAFKA-1992_2015-03-03_17:17:43.patch, KAFKA-1992_2015-03-06_13:34:20.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346162#comment-14346162 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch, > KAFKA-1992_2015-03-03_17:17:43.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345866#comment-14345866 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Gwen Shapira > Attachments: KAFKA-1992.patch, KAFKA-1992_2015-03-03_14:16:34.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks
[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342042#comment-14342042 ] Gwen Shapira commented on KAFKA-1992: - Created reviewboard https://reviews.apache.org/r/31591/diff/ against branch trunk > Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get > requiredAcks > - > > Key: KAFKA-1992 > URL: https://issues.apache.org/jira/browse/KAFKA-1992 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira > Attachments: KAFKA-1992.patch > > > Follow up from Jun's review: > "Should we just remove requiredAcks completely since > checkEnoughReplicasReachOffset() will only be called when requiredAcks is -1?" > Answer is: Yes, we should :) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
