[jira] [Commented] (KAFKA-2149) fix default InterBrokerProtocolVersion
[ https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511899#comment-14511899 ] Onur Karaman commented on KAFKA-2149: - Okay that sounds fair. I hadn't seen the upgrade docs you provided before. I had only read KIP-2, which included the line bq. The idea is that in 0.8.3, we will default wire.protocol.version to 0.8.2 Can you update the KIP? fix default InterBrokerProtocolVersion -- Key: KAFKA-2149 URL: https://issues.apache.org/jira/browse/KAFKA-2149 Project: Kafka Issue Type: Bug Reporter: Onur Karaman Assignee: Onur Karaman Attachments: KAFKA-2149.patch Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2149) fix default InterBrokerProtocolVersion
[ https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511937#comment-14511937 ] Gwen Shapira commented on KAFKA-2149: - Oops, the kip actually contained both options and we never removed the one we didn't implement. Sorry about it. You probably noticed that the configuration name is wrong there too. KIP-2 now has the correct version of the upgrade instructions, but I still recommend using the docs for reference. fix default InterBrokerProtocolVersion -- Key: KAFKA-2149 URL: https://issues.apache.org/jira/browse/KAFKA-2149 Project: Kafka Issue Type: Bug Reporter: Onur Karaman Assignee: Onur Karaman Attachments: KAFKA-2149.patch Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2149) fix default InterBrokerProtocolVersion
[ https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511943#comment-14511943 ] Onur Karaman commented on KAFKA-2149: - Cool thanks! fix default InterBrokerProtocolVersion -- Key: KAFKA-2149 URL: https://issues.apache.org/jira/browse/KAFKA-2149 Project: Kafka Issue Type: Bug Reporter: Onur Karaman Assignee: Onur Karaman Attachments: KAFKA-2149.patch Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2149) fix default InterBrokerProtocolVersion
[ https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511657#comment-14511657 ] Onur Karaman commented on KAFKA-2149: - Created reviewboard https://reviews.apache.org/r/33532/diff/ against branch origin/trunk fix default InterBrokerProtocolVersion -- Key: KAFKA-2149 URL: https://issues.apache.org/jira/browse/KAFKA-2149 Project: Kafka Issue Type: Bug Reporter: Onur Karaman Assignee: Onur Karaman Attachments: KAFKA-2149.patch Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2149) fix default InterBrokerProtocolVersion
[ https://issues.apache.org/jira/browse/KAFKA-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511790#comment-14511790 ] Gwen Shapira commented on KAFKA-2149: - Actually the decision to default to latest version for inter-broker protocol was a design decision, not a bug. The idea is that if the default is 0.8.2, we have the following problems: 1. New installations will not have new features out-of-the-box, they'll need to change configuration. Making life easier for experienced admins upgrading vs new users installing doesn't sound right. 2. We'll need to keep track of the default with every release We do have the upgrade process in the docs: https://kafka.apache.org/083/documentation.html#upgrade fix default InterBrokerProtocolVersion -- Key: KAFKA-2149 URL: https://issues.apache.org/jira/browse/KAFKA-2149 Project: Kafka Issue Type: Bug Reporter: Onur Karaman Assignee: Onur Karaman Attachments: KAFKA-2149.patch Fix the default InterBrokerProtocolVersion to be KAFKA_082 as specified in KIP-2. We hit wire-protocol problems (BufferUnderflowException) with upgrading brokers to include KAFKA-1809. This specifically happened when an older broker receives a UpdateMetadataRequest from a controller with the patch and the controller didn't explicitly set their inter.broker.protocol.version to 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
