[jira] [Commented] (KAFKA-2309) ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209534#comment-15209534
 ] 

ASF GitHub Bot commented on KAFKA-2309:
---

GitHub user auradkar reopened a pull request:

https://github.com/apache/kafka/pull/185

KAFKA-2309; ISR shrink rate not updated on LeaderAndIsr request with shrunk 
ISR

Currently, a LeaderAndIsrRequest does not mark the isrShrinkRate if the 
received ISR is smaller than the existing ISR. This can happen if one of the 
replicas is shut down.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/auradkar/kafka K-2309

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #185


commit 090a78284478ba57c655fe7a931e8318641bceae
Author: Aditya Auradkar 
Date:   2015-09-02T01:16:53Z

Fixing KAFKA-2309

commit 7d60319a99feadc0c13fd7639d39b6af786515e5
Author: Aditya Auradkar 
Date:   2015-10-07T01:54:19Z

Addressing Joels comment

commit bd8dc02e28b94422735114275737f3efcf667a8b
Author: Aditya Auradkar 
Date:   2015-10-07T02:00:21Z

addressing comments




> ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR
> ---
>
> Key: KAFKA-2309
> URL: https://issues.apache.org/jira/browse/KAFKA-2309
> Project: Kafka
>  Issue Type: Bug
>Reporter: Joel Koshy
>Assignee: Aditya Auradkar
>Priority: Minor
>
> If a broker receives a LeaderAndIsr request with a shrunk ISR (say, when a 
> follower shuts down) it needs to mark the isr shrink rate meter when it 
> updates its ISR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2309) ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209490#comment-15209490
 ] 

ASF GitHub Bot commented on KAFKA-2309:
---

Github user auradkar closed the pull request at:

https://github.com/apache/kafka/pull/185


> ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR
> ---
>
> Key: KAFKA-2309
> URL: https://issues.apache.org/jira/browse/KAFKA-2309
> Project: Kafka
>  Issue Type: Bug
>Reporter: Joel Koshy
>Assignee: Aditya Auradkar
>Priority: Minor
>
> If a broker receives a LeaderAndIsr request with a shrunk ISR (say, when a 
> follower shuts down) it needs to mark the isr shrink rate meter when it 
> updates its ISR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2309) ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726546#comment-14726546
 ] 

ASF GitHub Bot commented on KAFKA-2309:
---

GitHub user auradkar opened a pull request:

https://github.com/apache/kafka/pull/185

Fixing KAFKA-2309

Currently, a LeaderAndIsrRequest does not mark the isrShrinkRate if the 
received ISR is smaller than the existing ISR. This can happen if one of the 
replicas is shut down.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/auradkar/kafka K-2309

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #185






> ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR
> ---
>
> Key: KAFKA-2309
> URL: https://issues.apache.org/jira/browse/KAFKA-2309
> Project: Kafka
>  Issue Type: Bug
>Reporter: Joel Koshy
>Assignee: Aditya Auradkar
>Priority: Minor
>
> If a broker receives a LeaderAndIsr request with a shrunk ISR (say, when a 
> follower shuts down) it needs to mark the isr shrink rate meter when it 
> updates its ISR.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)