[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726262#comment-14726262 ] ASF GitHub Bot commented on KAFKA-2332: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/176 > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Fix For: 0.8.3 > > Attachments: KAFKA-2332.patch, KAFKA-2332.patch, > KAFKA-2332_2015-08-03_18:22:53.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720510#comment-14720510 ] ASF GitHub Bot commented on KAFKA-2332: --- GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/176 KAFKA-2332; Add quota metrics to old producer and consumer You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFKA-2332 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/176.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #176 commit 8bd032e577a8d51bd2346f402ba96842c3a680dd Author: Dong Lin Date: 2015-08-28T20:23:14Z KAFKA-2332; Add quota metrics to old producer and consumer > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch, > KAFKA-2332_2015-08-03_18:22:53.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652915#comment-14652915 ] Dong Lin commented on KAFKA-2332: - Updated reviewboard https://reviews.apache.org/r/36722/diff/ against branch origin/trunk > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch, > KAFKA-2332_2015-08-03_18:22:53.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639116#comment-14639116 ] Ismael Juma commented on KAFKA-2332: OK, thanks. > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639113#comment-14639113 ] Dong Lin commented on KAFKA-2332: - [~ijuma] I think the intent is to support existing consumer and old producer until they can be retired. We need to support quota in existing consumer and old producer since LinkedIn and probably many other company are still using them. This patch is part of KAFKA-2083 Quotas for Kafka. > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639013#comment-14639013 ] Ismael Juma commented on KAFKA-2332: Is the intent to keep adding features to the existing consumer and old producer? > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2332) Add quota metrics to old producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638348#comment-14638348 ] Dong Lin commented on KAFKA-2332: - Created reviewboard https://reviews.apache.org/r/36722/diff/ against branch origin/trunk > Add quota metrics to old producer and consumer > -- > > Key: KAFKA-2332 > URL: https://issues.apache.org/jira/browse/KAFKA-2332 > Project: Kafka > Issue Type: Sub-task >Reporter: Aditya Auradkar >Assignee: Dong Lin > Labels: quotas > Attachments: KAFKA-2332.patch, KAFKA-2332.patch > > > Quota metrics have only been added to the new producer and consumer. It may > be beneficial to add these to the existing consumer and old producer also for > clients using the older versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
