[jira] [Commented] (KAFKA-2648) Coordinator should not allow empty groupIds
[ https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979228#comment-14979228 ] ASF GitHub Bot commented on KAFKA-2648: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/362 > Coordinator should not allow empty groupIds > --- > > Key: KAFKA-2648 > URL: https://issues.apache.org/jira/browse/KAFKA-2648 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jason Gustafson >Assignee: Jason Gustafson > Fix For: 0.9.0.0 > > > The coordinator currently allows consumer groups with empty groupIds, but > there probably aren't any cases where this is actually a good idea and it > tends to mask problems where different groups have simply not configured a > groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, > which the coordinator can return when it encounters an empty groupID. We > should also make groupId a required property in consumer configuration and > enforce that it is non-empty. > It's a little unclear whether this change would have compatibility concerns. > The old consumer will fail with an empty groupId (because it cannot create > the zookeeper paths), but other clients may allow it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2648) Coordinator should not allow empty groupIds
[ https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977130#comment-14977130 ] Guozhang Wang commented on KAFKA-2648: -- We can just check non-empty group-id in join-group / sync-group requests, but not in offset commit / fetch requests. > Coordinator should not allow empty groupIds > --- > > Key: KAFKA-2648 > URL: https://issues.apache.org/jira/browse/KAFKA-2648 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jason Gustafson >Assignee: Jason Gustafson > > The coordinator currently allows consumer groups with empty groupIds, but > there probably aren't any cases where this is actually a good idea and it > tends to mask problems where different groups have simply not configured a > groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, > which the coordinator can return when it encounters an empty groupID. We > should also make groupId a required property in consumer configuration and > enforce that it is non-empty. > It's a little unclear whether this change would have compatibility concerns. > The old consumer will fail with an empty groupId (because it cannot create > the zookeeper paths), but other clients may allow it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2648) Coordinator should not allow empty groupIds
[ https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975482#comment-14975482 ] Jason Gustafson commented on KAFKA-2648: [~guozhang] I would actually prefer checking this on the server side, and I agree that it would be nice to not have to set groupId in cases where you don't actually need it. The only concern I had was whether there were any existing applications that depended on being able to use empty groupId for offset commits. > Coordinator should not allow empty groupIds > --- > > Key: KAFKA-2648 > URL: https://issues.apache.org/jira/browse/KAFKA-2648 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jason Gustafson >Assignee: Jason Gustafson > > The coordinator currently allows consumer groups with empty groupIds, but > there probably aren't any cases where this is actually a good idea and it > tends to mask problems where different groups have simply not configured a > groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, > which the coordinator can return when it encounters an empty groupID. We > should also make groupId a required property in consumer configuration and > enforce that it is non-empty. > It's a little unclear whether this change would have compatibility concerns. > The old consumer will fail with an empty groupId (because it cannot create > the zookeeper paths), but other clients may allow it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2648) Coordinator should not allow empty groupIds
[ https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975075#comment-14975075 ] Guozhang Wang commented on KAFKA-2648: -- The new consumer consolidates the old high-level and simple consumers, and for old simple consumer one does not need to specify group ids since it does not require any coordination at all. But given that I feel we do not need to be concerned about compatibility since the new consumer does not need to be compatible with the old consumer's APIs. The concerns I have, though, is about enforcing group id at the consumer side as the submitted PR: consumer instances may be used by tooling / admin / high-level services like streaming etc, which does not necessarily need to specify group ids since they do not need coordination. An alternative is to do exactly this ticket's title suggested: let the coordinator check if group id is empty, but not necessarily enforce non-empty group ids at the consumer side, and document "if you EVER want to subscribe during the lifetime of your consumer, you need to specify the group-id or otherwise subscribe() can throw a runtime exception". > Coordinator should not allow empty groupIds > --- > > Key: KAFKA-2648 > URL: https://issues.apache.org/jira/browse/KAFKA-2648 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jason Gustafson >Assignee: Jason Gustafson > > The coordinator currently allows consumer groups with empty groupIds, but > there probably aren't any cases where this is actually a good idea and it > tends to mask problems where different groups have simply not configured a > groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, > which the coordinator can return when it encounters an empty groupID. We > should also make groupId a required property in consumer configuration and > enforce that it is non-empty. > It's a little unclear whether this change would have compatibility concerns. > The old consumer will fail with an empty groupId (because it cannot create > the zookeeper paths), but other clients may allow it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2648) Coordinator should not allow empty groupIds
[ https://issues.apache.org/jira/browse/KAFKA-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974878#comment-14974878 ] ASF GitHub Bot commented on KAFKA-2648: --- GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/362 KAFKA-2648: group.id is required for new consumer and cannot be empty You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-2648 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 commit 5a419664f36fcbb955e250ebfe8c531e50fff981 Author: Jason Gustafson Date: 2015-10-26T19:40:02Z KAFKA-2648: group.id is required for new consumer and cannot be empty > Coordinator should not allow empty groupIds > --- > > Key: KAFKA-2648 > URL: https://issues.apache.org/jira/browse/KAFKA-2648 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.9.0.0 >Reporter: Jason Gustafson >Assignee: Jason Gustafson > > The coordinator currently allows consumer groups with empty groupIds, but > there probably aren't any cases where this is actually a good idea and it > tends to mask problems where different groups have simply not configured a > groupId. To address this, we can add a new error code, say INVALID_GROUP_ID, > which the coordinator can return when it encounters an empty groupID. We > should also make groupId a required property in consumer configuration and > enforce that it is non-empty. > It's a little unclear whether this change would have compatibility concerns. > The old consumer will fail with an empty groupId (because it cannot create > the zookeeper paths), but other clients may allow it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
