[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976652#comment-14976652 ] Edward Maxwell-Lyte commented on KAFKA-2696: Great, will do. > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976628#comment-14976628 ] Gwen Shapira commented on KAFKA-2696: - If you'll look at ProducerConfig, you'll see it has a "main" method. Running this generates docs from the doc strings in the file. Those are added to the documentation as part of the release process (we have a JIRA open for adding this step to Gradle so it will happen on build). So to improve the docs you want to edit the actual configuration file. > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976621#comment-14976621 ] ASF GitHub Bot commented on KAFKA-2696: --- Github user edwardmlyte closed the pull request at: https://github.com/apache/kafka/pull/367 > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976618#comment-14976618 ] Edward Maxwell-Lyte commented on KAFKA-2696: Ok, I'll remove the pull request. Any insight to how that magic works, so I can be more useful in the future? > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976606#comment-14976606 ] Gwen Shapira commented on KAFKA-2696: - These docs are generated "automagically" from the code. So fixing this in the docs won't do much... it will be resolved in the next release as the docs will be updated from latest code. > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2696) New KafkaProducer documentation doesn't include all necessary config properties
[ https://issues.apache.org/jira/browse/KAFKA-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976600#comment-14976600 ] ASF GitHub Bot commented on KAFKA-2696: --- GitHub user edwardmlyte opened a pull request: https://github.com/apache/kafka/pull/367 KAFKA-2696: New KafkaProducer documentation doesn't include all necessary config properties Added in documentation to add missing properties, as well as highlight those minimum required properties. You can merge this pull request into a Git repository by running: $ git pull https://github.com/edwardmlyte/kafka docsUpdate Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/367.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #367 commit 68938ab2470c699a2471c5eacc7451cc122b330a Author: edwardmlyte Date: 2015-10-27T15:38:50Z KAFKA-2696: New KafkaProducer documentation doesn't include all necessary config properties Added in documentation. > New KafkaProducer documentation doesn't include all necessary config > properties > --- > > Key: KAFKA-2696 > URL: https://issues.apache.org/jira/browse/KAFKA-2696 > Project: Kafka > Issue Type: Bug > Components: website >Affects Versions: 0.8.2.2 >Reporter: Edward Maxwell-Lyte > > It's missing the definitions for key.serializer and value.serializer. And it > would be good to highlight the necessary properties for the new KafkaProducer > to work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
