[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990643#comment-14990643 ] ASF GitHub Bot commented on KAFKA-2697: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/414 > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Jason Gustafson > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988601#comment-14988601 ] ASF GitHub Bot commented on KAFKA-2697: --- GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/414 KAFKA-2697: client-side support for leave group You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA-2697 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #414 commit 0fa0bdb4887538e939c7dcc2b830bba5e8fffdae Author: Jason Gustafson Date: 2015-11-03T22:13:47Z KAFKA-2697: client-side support for leave group > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Jason Gustafson > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988276#comment-14988276 ] Jason Gustafson commented on KAFKA-2697: [~onurkaraman] Ah, didn't see your comment from yesterday. Assigning to myself. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988271#comment-14988271 ] Jason Gustafson commented on KAFKA-2697: [~onurkaraman] I was thinking something with naive error handling like this could work: https://github.com/hachikuji/kafka/commit/c064110b5792dca583190e54d0fa90ae0d245954. The only question as you mentioned before is whether KafkaConsumer should have a close(timeout) method like KafkaProducer does. If you don't have time for this, I can probably try to polish up this patch. It would be a pity if we couldn't get this into the release after finally getting the server-side code in. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986555#comment-14986555 ] Onur Karaman commented on KAFKA-2697: - Unfortunately on a tight schedule for something else at work. You can take this ticket if you want. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986229#comment-14986229 ] Guozhang Wang commented on KAFKA-2697: -- [~onurkaraman] assigning the ticket to you now, please let me know if you are busy so I can help. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman >Assignee: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983052#comment-14983052 ] Onur Karaman commented on KAFKA-2697: - Hi Jun. I have some scrap code that I used while testing the broker side changes here: https://github.com/onurkaraman/kafka/commit/cdb559f0c73417aa69ef750f06b791822bae4a48 I could try to get something out this weekend. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2697) add leave group logic to the consumer
[ https://issues.apache.org/jira/browse/KAFKA-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983047#comment-14983047 ] Jun Rao commented on KAFKA-2697: [~onurkaraman], do you plan to work on this before the 0.9.0 release? We plan to cut the release branch in a week or so. > add leave group logic to the consumer > - > > Key: KAFKA-2697 > URL: https://issues.apache.org/jira/browse/KAFKA-2697 > Project: Kafka > Issue Type: Sub-task > Components: consumer >Reporter: Onur Karaman > Fix For: 0.9.0.0 > > > KAFKA-2397 added logic on the coordinator to handle LeaveGroupRequests. We > need to add logic to KafkaConsumer to send out a LeaveGroupRequest on close. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
