[jira] [Commented] (KAFKA-2721) Avoid handling duplicate LeaderAndISR requests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007647#comment-15007647
 ] 

ASF GitHub Bot commented on KAFKA-2721:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/436


> Avoid handling duplicate LeaderAndISR requests
> --
>
> Key: KAFKA-2721
> URL: https://issues.apache.org/jira/browse/KAFKA-2721
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Dong Lin
> Fix For: 0.9.0.0
>
>
> Upon controller migration, the new controller will try to resend all the 
> LeaderAndISR requests for any on-going partition reassignments. This can then 
> lead to duplicate such requests sent to the same broker.
> Upon receiving such requests, today brokers do not detect if, for example, it 
> is already the leader for the requested becoming-leader-partition, and does 
> the logic such as 1) stop fetching 2) coordinator migration, etc which is not 
> necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2721) Avoid handling duplicate LeaderAndISR requests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992520#comment-14992520
 ] 

ASF GitHub Bot commented on KAFKA-2721:
---

GitHub user lindong28 opened a pull request:

https://github.com/apache/kafka/pull/436

KAFKA-2721; Avoid handling duplicate LeaderAndISR requests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindong28/kafka KAFKA-2721

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #436


commit eb62763d2e6ef04a013eb15e381278a84041abd2
Author: Dong Lin 
Date:   2015-11-05T21:32:51Z

KAFKA-2721; Avoid handling duplicate LeaderAndISR requests




> Avoid handling duplicate LeaderAndISR requests
> --
>
> Key: KAFKA-2721
> URL: https://issues.apache.org/jira/browse/KAFKA-2721
> Project: Kafka
>  Issue Type: Bug
>Reporter: Guozhang Wang
>Assignee: Dong Lin
> Fix For: 0.9.0.1
>
>
> Upon controller migration, the new controller will try to resend all the 
> LeaderAndISR requests for any on-going partition reassignments. This can then 
> lead to duplicate such requests sent to the same broker.
> Upon receiving such requests, today brokers do not detect if, for example, it 
> is already the leader for the requested becoming-leader-partition, and does 
> the logic such as 1) stop fetching 2) coordinator migration, etc which is not 
> necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)