[
https://issues.apache.org/jira/browse/KAFKA-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997453#comment-14997453
]
ASF GitHub Bot commented on KAFKA-2769:
---
GitHub user apovzner opened a pull request:
https://github.com/apache/kafka/pull/472
KAFKA-2769: Multi-consumer integration tests for consumer assignment incl.
session timeouts and corresponding fixes
-- Refactored multi-consumer integration group assignment validation tests
for round-robin assignment
-- Added multi-consumer integration tests for session timeout expiration:
1. When a consumer stops polling
2. When a consumer calls close()
-- Fixes to issues found with session timeout expiration tests woth help
from Jason Gustafson: Try to avoid SendFailedException exception by cancelling
the scheduled tasks and ensuring metadata update before sending group leave
requests + send leave group request with retries.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apovzner/kafka cpkafka-81
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #472
commit 0dc57aa7bed768559da19707e672dfbb55c0460b
Author: Anna Povzner
Date: 2015-11-06T04:02:55Z
KAFKA-2769: Multi-consumer integration tests for consumer group subsribe
and timeouts and consumer timeout fixes.
-- Refactored multi-consumer integration group assignment validation tests
for round-robin assignment
-- Added multi-consumer integration tests for session timeout expiration
-- Fixes to issues found with session timeout expiration tests woth help
from Jason Gustafson.
1. shouldKeepMemberAlive(): when we are in the sync phase, we do want
to expire members if we don't get any response
2. Try to avoid SendFailedException exception by cancelling the
scheduled tasks and ensuring metadata update before sending group leave
requests.
commit 87554675c0ad5e51602c4cc37a40a9bb273b6dd0
Author: Anna Povzner
Date: 2015-11-07T00:10:04Z
KAFKA-2769: More reliable sending of leave group request in the consumer on
consumer close().
commit 353ef1c079f39ad15a91ba26f64f95c541d517f1
Author: Anna Povzner
Date: 2015-11-09T19:56:36Z
Reverted a change in shouldKeepMemberAlive() to check for sync callback set
commit 83f703d6cb8720ac12e25692ce273e15813e89f6
Author: Anna Povzner
Date: 2015-11-09T20:52:15Z
fixed minor test issues
> Integration tests for multi-consumer assignment including session timeouts
> --
>
> Key: KAFKA-2769
> URL: https://issues.apache.org/jira/browse/KAFKA-2769
> Project: Kafka
> Issue Type: Test
>Reporter: Anna Povzner
>Assignee: Anna Povzner
>
> We currently don't have integration tests for multi-consumer range assignment
> and session timeout expiration scenarios.
> This card is to add multi-consumer integration tests for range assignment:
> -- initial assignment
> -- adding a new consumer to an existing group
> -- adding and removing a topic to/from subscription
> -- session timeout expiration when consumer stops polling and on consumer
> close().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
