[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025371#comment-15025371 ] Guozhang Wang commented on KAFKA-2881: -- @Jun has already fixed 1) above, this patch only targets at 2). > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025552#comment-15025552 ] ASF GitHub Bot commented on KAFKA-2881: --- GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka-site/pull/5 KAFKA-2881: Organized Consumer APIs and Configs You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka-site K2881 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 3ef0a03449b79b3e61947408c3e6987580efad22 Author: Guozhang Wang Date: 2015-11-24T22:16:06Z v1 > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025554#comment-15025554 ] ASF GitHub Bot commented on KAFKA-2881: --- Github user guozhangwang commented on the pull request: https://github.com/apache/kafka-site/pull/5#issuecomment-159424104 Ping @gwenshap @junrao for reviews. > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025610#comment-15025610 ] ASF GitHub Bot commented on KAFKA-2881: --- Github user gwenshap commented on the pull request: https://github.com/apache/kafka-site/pull/5#issuecomment-159430950 The patch looks good, but I'm concerned that by committing to kafka-site directly, we will lose sync with the docs in the trunk. Mind making this a kafka trunk PR and then we can push the change to both repos? > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025735#comment-15025735 ] ASF GitHub Bot commented on KAFKA-2881: --- Github user guozhangwang commented on the pull request: https://github.com/apache/kafka-site/pull/5#issuecomment-159441903 Good point, will do that. > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025741#comment-15025741 ] ASF GitHub Bot commented on KAFKA-2881: --- Github user guozhangwang closed the pull request at: https://github.com/apache/kafka-site/pull/5 > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025835#comment-15025835 ] ASF GitHub Bot commented on KAFKA-2881: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/584 > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > Fix For: 0.9.0.0, 0.9.1.0 > > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025845#comment-15025845 ] Gwen Shapira commented on KAFKA-2881: - Committed, but then noticed that Jun's fix for #1 is only in Kafka-Site... I'll bring it over to trunk in a "minor" PR to avoid trampling over it when copying your changes... > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > Fix For: 0.9.0.0, 0.9.1.0 > > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2881) Documentation improvement
[ https://issues.apache.org/jira/browse/KAFKA-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025879#comment-15025879 ] Gwen Shapira commented on KAFKA-2881: - never mind, it was in trunk. I missed that commit. > Documentation improvement > - > > Key: KAFKA-2881 > URL: https://issues.apache.org/jira/browse/KAFKA-2881 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.9.0.0 >Reporter: Gwen Shapira >Assignee: Guozhang Wang > Fix For: 0.9.0.0, 0.9.1.0 > > > 1. We seem to be missing section 4.9 (Quotas) in the table of contents > 2. The consumer documentation could use a little meta-guidance. There are > three sections "High Level Consumer", "Simple Consumer", "New Consumer". If I > came into this fresh, I would be super confused as to what these things were > and which I should use. I think we need to add a section that introduces the > state of things--i.e. when should you use each? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
