[jira] [Commented] (KAFKA-3045) ZkNodeChangeNotificationListener shouldn't log interrupted exception as error
[ https://issues.apache.org/jira/browse/KAFKA-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081237#comment-15081237 ] Ismael Juma commented on KAFKA-3045: AclChangedNotificationHandler also has a similar issue. Both cases can be seen when running `AclCommandTest`. > ZkNodeChangeNotificationListener shouldn't log interrupted exception as error > - > > Key: KAFKA-3045 > URL: https://issues.apache.org/jira/browse/KAFKA-3045 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao > Labels: security > Fix For: 0.9.0.1 > > > Saw the following when running /opt/kafka/bin/kafka-acls.sh --authorizer > kafka.security.auth.SimpleAclAuthorizer. > [2015-12-28 08:04:39,382] ERROR Error processing notification change for path > = /kafka-acl-changes and notification= [acl_changes_04, > acl_changes_03, acl_changes_02, acl_changes_01, > acl_changes_00] : (kafka.common.ZkNodeChangeNotificationListener) > org.I0Itec.zkclient.exception.ZkInterruptedException: > java.lang.InterruptedException > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:997) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1085) > at kafka.utils.ZkUtils.readDataMaybeNull(ZkUtils.scala:525) > at > kafka.security.auth.SimpleAclAuthorizer.kafka$security$auth$SimpleAclAuthorizer$$getAclsFromZk(SimpleAclAuthorizer.scala:213) > at > kafka.security.auth.SimpleAclAuthorizer$AclChangedNotificaitonHandler$.processNotification(SimpleAclAuthorizer.scala:273) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at scala.Option.map(Option.scala:146) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:79) > at > scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) > at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) > at > kafka.common.ZkNodeChangeNotificationListener.kafka$common$ZkNodeChangeNotificationListener$$processNotifications(ZkNodeChangeNotificationListener.scala:79) > at > kafka.common.ZkNodeChangeNotificationListener$NodeChangeListener$.handleChildChange(ZkNodeChangeNotificationListener.scala:121) > at org.I0Itec.zkclient.ZkClient$10.run(ZkClient.java:842) > at org.I0Itec.zkclient.ZkEventThread.run(ZkEventThread.java:71) > Caused by: java.lang.InterruptedException > at java.lang.Object.wait(Native Method) > at java.lang.Object.wait(Object.java:502) > at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1153) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1184) > at org.I0Itec.zkclient.ZkConnection.readData(ZkConnection.java:119) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1094) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:985) > When SimpleAclAuthorizer terminates, we close zkclient, which interrupts the > watcher processor thread. Since this is expected, we shouldn't log this as an > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3045) ZkNodeChangeNotificationListener shouldn't log interrupted exception as error
[ https://issues.apache.org/jira/browse/KAFKA-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082243#comment-15082243 ] ASF GitHub Bot commented on KAFKA-3045: --- GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/731 KAFKA-3045; ZkNodeChangeNotificationListener shouldn't log InterruptedException as error You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFKA-3045 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/731.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #731 commit c140a114c4d86ef5ecc408f38a4640f3e8cef5f3 Author: Dong Lin Date: 2016-01-05T02:23:30Z KAFKA-3045; ZkNodeChangeNotificationListener shouldn't log interrupted exception as error > ZkNodeChangeNotificationListener shouldn't log interrupted exception as error > - > > Key: KAFKA-3045 > URL: https://issues.apache.org/jira/browse/KAFKA-3045 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Dong Lin > Labels: security > Fix For: 0.9.0.1 > > > Saw the following when running /opt/kafka/bin/kafka-acls.sh --authorizer > kafka.security.auth.SimpleAclAuthorizer. > [2015-12-28 08:04:39,382] ERROR Error processing notification change for path > = /kafka-acl-changes and notification= [acl_changes_04, > acl_changes_03, acl_changes_02, acl_changes_01, > acl_changes_00] : (kafka.common.ZkNodeChangeNotificationListener) > org.I0Itec.zkclient.exception.ZkInterruptedException: > java.lang.InterruptedException > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:997) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1085) > at kafka.utils.ZkUtils.readDataMaybeNull(ZkUtils.scala:525) > at > kafka.security.auth.SimpleAclAuthorizer.kafka$security$auth$SimpleAclAuthorizer$$getAclsFromZk(SimpleAclAuthorizer.scala:213) > at > kafka.security.auth.SimpleAclAuthorizer$AclChangedNotificaitonHandler$.processNotification(SimpleAclAuthorizer.scala:273) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at scala.Option.map(Option.scala:146) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:79) > at > scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) > at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) > at > kafka.common.ZkNodeChangeNotificationListener.kafka$common$ZkNodeChangeNotificationListener$$processNotifications(ZkNodeChangeNotificationListener.scala:79) > at > kafka.common.ZkNodeChangeNotificationListener$NodeChangeListener$.handleChildChange(ZkNodeChangeNotificationListener.scala:121) > at org.I0Itec.zkclient.ZkClient$10.run(ZkClient.java:842) > at org.I0Itec.zkclient.ZkEventThread.run(ZkEventThread.java:71) > Caused by: java.lang.InterruptedException > at java.lang.Object.wait(Native Method) > at java.lang.Object.wait(Object.java:502) > at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1153) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1184) > at org.I0Itec.zkclient.ZkConnection.readData(ZkConnection.java:119) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1094) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:985) > When SimpleAclAuthorizer terminates, we close zkclient, which interrupts the > watcher processor thread. Since this is expected, we shouldn't log this as an > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3045) ZkNodeChangeNotificationListener shouldn't log interrupted exception as error
[ https://issues.apache.org/jira/browse/KAFKA-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083691#comment-15083691 ] ASF GitHub Bot commented on KAFKA-3045: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/731 > ZkNodeChangeNotificationListener shouldn't log interrupted exception as error > - > > Key: KAFKA-3045 > URL: https://issues.apache.org/jira/browse/KAFKA-3045 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.9.0.0 >Reporter: Jun Rao >Assignee: Dong Lin > Labels: security > Fix For: 0.9.0.1 > > > Saw the following when running /opt/kafka/bin/kafka-acls.sh --authorizer > kafka.security.auth.SimpleAclAuthorizer. > [2015-12-28 08:04:39,382] ERROR Error processing notification change for path > = /kafka-acl-changes and notification= [acl_changes_04, > acl_changes_03, acl_changes_02, acl_changes_01, > acl_changes_00] : (kafka.common.ZkNodeChangeNotificationListener) > org.I0Itec.zkclient.exception.ZkInterruptedException: > java.lang.InterruptedException > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:997) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.readData(ZkClient.java:1085) > at kafka.utils.ZkUtils.readDataMaybeNull(ZkUtils.scala:525) > at > kafka.security.auth.SimpleAclAuthorizer.kafka$security$auth$SimpleAclAuthorizer$$getAclsFromZk(SimpleAclAuthorizer.scala:213) > at > kafka.security.auth.SimpleAclAuthorizer$AclChangedNotificaitonHandler$.processNotification(SimpleAclAuthorizer.scala:273) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2$$anonfun$apply$2.apply(ZkNodeChangeNotificationListener.scala:84) > at scala.Option.map(Option.scala:146) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:84) > at > kafka.common.ZkNodeChangeNotificationListener$$anonfun$kafka$common$ZkNodeChangeNotificationListener$$processNotifications$2.apply(ZkNodeChangeNotificationListener.scala:79) > at > scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59) > at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48) > at > kafka.common.ZkNodeChangeNotificationListener.kafka$common$ZkNodeChangeNotificationListener$$processNotifications(ZkNodeChangeNotificationListener.scala:79) > at > kafka.common.ZkNodeChangeNotificationListener$NodeChangeListener$.handleChildChange(ZkNodeChangeNotificationListener.scala:121) > at org.I0Itec.zkclient.ZkClient$10.run(ZkClient.java:842) > at org.I0Itec.zkclient.ZkEventThread.run(ZkEventThread.java:71) > Caused by: java.lang.InterruptedException > at java.lang.Object.wait(Native Method) > at java.lang.Object.wait(Object.java:502) > at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1342) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1153) > at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1184) > at org.I0Itec.zkclient.ZkConnection.readData(ZkConnection.java:119) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1094) > at org.I0Itec.zkclient.ZkClient$12.call(ZkClient.java:1090) > at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:985) > When SimpleAclAuthorizer terminates, we close zkclient, which interrupts the > watcher processor thread. Since this is expected, we shouldn't log this as an > error. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
